* [PATCH] sandbox: enable support for the unlz4 command
@ 2024-05-25 8:10 Jonathan Liu
2024-05-29 16:29 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Liu @ 2024-05-25 8:10 UTC (permalink / raw)
To: u-boot; +Cc: Tom Rini, Simon Glass, Jonathan Liu
This does not work with sandbox at present. Fix it up to use map_sysmem()
to convert an address to a pointer.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
cmd/unlz4.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/unlz4.c b/cmd/unlz4.c
index 5f20838e899..4b66794a72c 100644
--- a/cmd/unlz4.c
+++ b/cmd/unlz4.c
@@ -7,6 +7,7 @@
#include <common.h>
#include <command.h>
#include <env.h>
+#include <mapmem.h>
#include <u-boot/lz4.h>
static int do_unlz4(struct cmd_tbl *cmdtp, int flag, int argc,
@@ -26,7 +27,7 @@ static int do_unlz4(struct cmd_tbl *cmdtp, int flag, int argc,
return CMD_RET_USAGE;
}
- ret = ulz4fn((void *)src, src_len, (void *)dst, &dst_len);
+ ret = ulz4fn(map_sysmem(src, 0), src_len, map_sysmem(dst, dst_len), &dst_len);
if (ret) {
printf("Uncompressed err :%d\n", ret);
return 1;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sandbox: enable support for the unlz4 command
2024-05-25 8:10 [PATCH] sandbox: enable support for the unlz4 command Jonathan Liu
@ 2024-05-29 16:29 ` Simon Glass
2024-07-15 13:31 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2024-05-29 16:29 UTC (permalink / raw)
To: Jonathan Liu; +Cc: u-boot, Tom Rini
On Sat, 25 May 2024 at 02:11, Jonathan Liu <net147@gmail.com> wrote:
>
> This does not work with sandbox at present. Fix it up to use map_sysmem()
> to convert an address to a pointer.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> cmd/unlz4.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sandbox: enable support for the unlz4 command
2024-05-29 16:29 ` Simon Glass
@ 2024-07-15 13:31 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2024-07-15 13:31 UTC (permalink / raw)
To: Simon Glass; +Cc: u-boot, Tom Rini, Jonathan Liu
On Sat, 25 May 2024 at 02:11, Jonathan Liu <net147@gmail.com> wrote:
>
> This does not work with sandbox at present. Fix it up to use map_sysmem()
> to convert an address to a pointer.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> cmd/unlz4.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-15 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-25 8:10 [PATCH] sandbox: enable support for the unlz4 command Jonathan Liu
2024-05-29 16:29 ` Simon Glass
2024-07-15 13:31 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.