From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>, Peter Xu <peterx@redhat.com>,
Fabiano Rosas <farosas@suse.de>, Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org
Subject: [PATCH v2 1/6] tests/qtest/migration: Run test_mode_reboot outside gitlab CI
Date: Tue, 28 May 2024 10:42:05 +1000 [thread overview]
Message-ID: <20240528004211.564010-2-npiggin@gmail.com> (raw)
In-Reply-To: <20240528004211.564010-1-npiggin@gmail.com>
As Fabiano points out, this test isn't flaky it just can't run under
gitlab CI since runners have a very small shm size.
Suggested-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
tests/qtest/migration-test.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index b7e3406471..04bf1c0092 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -706,6 +706,14 @@ static int test_migrate_start(QTestState **from, QTestState **to,
g_test_skip("/dev/shm is not supported");
return -1;
}
+ if (getenv("GITLAB_CI")) {
+ /*
+ * Gitlab runners are limited to 64MB shm size. See:
+ * https://lore.kernel.org/all/87ttq5fvh7.fsf@suse.de/
+ */
+ g_test_skip("/dev/shm is not supported in Gitlab CI environment");
+ return -1;
+ }
}
dst_state = (QTestMigrationState) { };
@@ -3506,15 +3514,7 @@ int main(int argc, char **argv)
test_precopy_file_offset);
migration_test_add("/migration/precopy/file/offset/bad",
test_precopy_file_offset_bad);
-
- /*
- * Our CI system has problems with shared memory.
- * Don't run this test until we find a workaround.
- */
- if (getenv("QEMU_TEST_FLAKY_TESTS")) {
- migration_test_add("/migration/mode/reboot", test_mode_reboot);
- }
-
+ migration_test_add("/migration/mode/reboot", test_mode_reboot);
migration_test_add("/migration/precopy/file/mapped-ram",
test_precopy_file_mapped_ram);
migration_test_add("/migration/precopy/file/mapped-ram/live",
--
2.43.0
next prev parent reply other threads:[~2024-05-28 0:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 0:42 [PATCH v2 0/6] tests/qtest/migration-test: Improve and enable on ppc64 Nicholas Piggin
2024-05-28 0:42 ` Nicholas Piggin [this message]
2024-05-28 6:35 ` [PATCH v2 1/6] tests/qtest/migration: Run test_mode_reboot outside gitlab CI Thomas Huth
2024-05-28 0:42 ` [PATCH v2 2/6] tests/qtest/migration-test: Fix and enable test_ignore_shared Nicholas Piggin
2024-05-28 19:21 ` Peter Xu
2024-05-28 0:42 ` [PATCH v2 3/6] tests/qtest: Move common define from libqos-spapr.h to new ppc-util.h Nicholas Piggin
2024-05-28 6:37 ` Thomas Huth
2024-05-28 0:42 ` [PATCH v2 4/6] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns Nicholas Piggin
2024-05-28 6:38 ` Thomas Huth
2024-05-28 0:42 ` [PATCH v2 5/6] tests/qtest/migration-test: Enable on ppc64 TCG Nicholas Piggin
2024-05-28 0:42 ` [PATCH v2 6/6] tests/qtest/migration-test: Use custom asm bios for ppc64 Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528004211.564010-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.