From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>, Peter Xu <peterx@redhat.com>,
Fabiano Rosas <farosas@suse.de>, Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, Yury Kotov <yury-kotov@yandex-team.ru>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [PATCH v2 2/6] tests/qtest/migration-test: Fix and enable test_ignore_shared
Date: Tue, 28 May 2024 10:42:06 +1000 [thread overview]
Message-ID: <20240528004211.564010-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240528004211.564010-1-npiggin@gmail.com>
This test is already starting to bitrot, so first remove it from ifdef
and fix compile issues. ppc64 transfers about 2MB, so bump the size
threshold too.
It was said to be broken on aarch64 but it may have been the limited shm
size under gitlab CI. The test is now excluded from running on CI so it
shouldn't cause too much annoyance.
So let's try enable it.
Cc: Yury Kotov <yury-kotov@yandex-team.ru>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
tests/qtest/migration-test.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 04bf1c0092..8247ed98f2 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1893,14 +1893,15 @@ static void test_precopy_unix_tls_x509_override_host(void)
#endif /* CONFIG_TASN1 */
#endif /* CONFIG_GNUTLS */
-#if 0
-/* Currently upset on aarch64 TCG */
static void test_ignore_shared(void)
{
g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
QTestState *from, *to;
+ MigrateStart args = {
+ .use_shmem = true,
+ };
- if (test_migrate_start(&from, &to, uri, false, true, NULL, NULL)) {
+ if (test_migrate_start(&from, &to, uri, &args)) {
return;
}
@@ -1925,11 +1926,11 @@ static void test_ignore_shared(void)
wait_for_migration_complete(from);
/* Check whether shared RAM has been really skipped */
- g_assert_cmpint(read_ram_property_int(from, "transferred"), <, 1024 * 1024);
+ g_assert_cmpint(read_ram_property_int(from, "transferred"), <,
+ 4 * 1024 * 1024);
test_migrate_end(from, to, true);
}
-#endif
static void *
test_migrate_xbzrle_start(QTestState *from,
@@ -3580,7 +3581,8 @@ int main(int argc, char **argv)
#endif /* CONFIG_TASN1 */
#endif /* CONFIG_GNUTLS */
- /* migration_test_add("/migration/ignore_shared", test_ignore_shared); */
+ migration_test_add("/migration/ignore_shared", test_ignore_shared);
+
#ifndef _WIN32
migration_test_add("/migration/precopy/fd/tcp",
test_migrate_precopy_fd_socket);
--
2.43.0
next prev parent reply other threads:[~2024-05-28 0:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 0:42 [PATCH v2 0/6] tests/qtest/migration-test: Improve and enable on ppc64 Nicholas Piggin
2024-05-28 0:42 ` [PATCH v2 1/6] tests/qtest/migration: Run test_mode_reboot outside gitlab CI Nicholas Piggin
2024-05-28 6:35 ` Thomas Huth
2024-05-28 0:42 ` Nicholas Piggin [this message]
2024-05-28 19:21 ` [PATCH v2 2/6] tests/qtest/migration-test: Fix and enable test_ignore_shared Peter Xu
2024-05-28 0:42 ` [PATCH v2 3/6] tests/qtest: Move common define from libqos-spapr.h to new ppc-util.h Nicholas Piggin
2024-05-28 6:37 ` Thomas Huth
2024-05-28 0:42 ` [PATCH v2 4/6] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns Nicholas Piggin
2024-05-28 6:38 ` Thomas Huth
2024-05-28 0:42 ` [PATCH v2 5/6] tests/qtest/migration-test: Enable on ppc64 TCG Nicholas Piggin
2024-05-28 0:42 ` [PATCH v2 6/6] tests/qtest/migration-test: Use custom asm bios for ppc64 Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528004211.564010-3-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=dgilbert@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
--cc=yury-kotov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.