* [PATCH] nouveau/uconn: drop WARN_ON and pointless ret setting.
@ 2024-05-28 6:47 Dave Airlie
0 siblings, 0 replies; only message in thread
From: Dave Airlie @ 2024-05-28 6:47 UTC (permalink / raw)
To: dri-devel; +Cc: nouveau
From: Dave Airlie <airlied@redhat.com>
With GSP on my laptop I get an 0xff connector type, it appears
this is normal behaviour and we should ignore that connector.
Now we don't handle that all properly, but anywhere I try to
ignore it at that point causes driver load to fail, so let's
not do that, and just drop the warn and ret setting (which gets
set to 0 a few lines later).
Cc: stable@vger.kernel.org
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
index 2dab6612c4fc..5f460e3d1bb5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
@@ -211,8 +211,6 @@ nvkm_uconn_new(const struct nvkm_oclass *oclass, void *argv, u32 argc, struct nv
case DCB_CONNECTOR_HDMI_1 :
case DCB_CONNECTOR_HDMI_C : args->v0.type = NVIF_CONN_V0_HDMI; break;
default:
- WARN_ON(1);
- ret = -EINVAL;
break;
}
--
2.45.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-28 6:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 6:47 [PATCH] nouveau/uconn: drop WARN_ON and pointless ret setting Dave Airlie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.