All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	netdev@vger.kernel.org, Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	intel-wired-lan@lists.osuosl.org,
	Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP
Date: Tue, 28 May 2024 13:00:55 -0700	[thread overview]
Message-ID: <20240528130055.4ecf339a@kernel.org> (raw)
In-Reply-To: <20240528112301.5374-12-mateusz.polchlopek@intel.com>

On Tue, 28 May 2024 07:23:00 -0400 Mateusz Polchlopek wrote:
> +	.ndo_eth_ioctl		= iavf_do_ioctl,

Please use the new ndos:

 * int (*ndo_hwtstamp_get)(struct net_device *dev,
 *			   struct kernel_hwtstamp_config *kernel_config);
 *	Get the currently configured hardware timestamping parameters for the
 *	NIC device.
 *
 * int (*ndo_hwtstamp_set)(struct net_device *dev,
 *			   struct kernel_hwtstamp_config *kernel_config,
 *			   struct netlink_ext_ack *extack);
 *	Change the hardware timestamping parameters for NIC device.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Jacob Keller <jacob.e.keller@intel.com>,
	Wojciech Drewek <wojciech.drewek@intel.com>,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP
Date: Tue, 28 May 2024 13:00:55 -0700	[thread overview]
Message-ID: <20240528130055.4ecf339a@kernel.org> (raw)
In-Reply-To: <20240528112301.5374-12-mateusz.polchlopek@intel.com>

On Tue, 28 May 2024 07:23:00 -0400 Mateusz Polchlopek wrote:
> +	.ndo_eth_ioctl		= iavf_do_ioctl,

Please use the new ndos:

 * int (*ndo_hwtstamp_get)(struct net_device *dev,
 *			   struct kernel_hwtstamp_config *kernel_config);
 *	Get the currently configured hardware timestamping parameters for the
 *	NIC device.
 *
 * int (*ndo_hwtstamp_set)(struct net_device *dev,
 *			   struct kernel_hwtstamp_config *kernel_config,
 *			   struct netlink_ext_ack *extack);
 *	Change the hardware timestamping parameters for NIC device.

  reply	other threads:[~2024-05-28 20:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 11:22 [Intel-wired-lan] [PATCH iwl-next v6 00/12] Add support for Rx timestamping for both ice and iavf drivers Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 01/12] virtchnl: add support for enabling PTP on iAVF Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 02/12] ice: support Rx timestamp on flex descriptor Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 03/12] virtchnl: add enumeration for the rxdid format Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 04/12] iavf: add support for negotiating flexible RXDID format Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 05/12] iavf: negotiate PTP capabilities Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 06/12] iavf: add initial framework for registering PTP clock Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 07/12] iavf: add support for indirect access to PHC time Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 08/12] iavf: periodically cache " Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:22 ` [Intel-wired-lan] [PATCH iwl-next v6 10/12] iavf: Implement checking DD desc field Mateusz Polchlopek
2024-05-28 11:22   ` Mateusz Polchlopek
2024-05-28 11:23 ` [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP Mateusz Polchlopek
2024-05-28 11:23   ` Mateusz Polchlopek
2024-05-28 20:00   ` Jakub Kicinski [this message]
2024-05-28 20:00     ` Jakub Kicinski
2024-05-28 23:54     ` Keller, Jacob E
2024-05-28 23:54       ` Keller, Jacob E
2024-05-29 13:12       ` Mateusz Polchlopek
2024-05-29 13:12         ` Mateusz Polchlopek
2024-05-28 11:23 ` [Intel-wired-lan] [PATCH iwl-next v6 12/12] iavf: add support for Rx timestamps to hotpath Mateusz Polchlopek
2024-05-28 11:23   ` Mateusz Polchlopek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528130055.4ecf339a@kernel.org \
    --to=kuba@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=mateusz.polchlopek@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=rrameshbabu@nvidia.com \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.