[rgushchin:memcontrol_v1.1-stable 14/15] mm/memcontrol.c:1628 mem_cgroup_oom() error: uninitialized symbol 'locked'.

[rgushchin:memcontrol_v1.1-stable 14/15] mm/memcontrol.c:1628 mem_cgroup_oom() error: uninitialized symbol 'locked'.

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Roman Gushchin <roman.gushchin@linux.dev>

tree:   https://github.com/rgushchin/linux.git memcontrol_v1.1-stable
head:   4df98e6b1ec64282ccd12b3bb1d863bf296cf86b
commit: 241d95ae7e072750faca6825aa9b5041e8834ce6 [14/15] mm: memcg: put cgroup v1-related members of task_struct under config option
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-161-20240530 (https://download.01.org/0day-ci/archive/20240530/202405301608.8i9hgexO-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202405301608.8i9hgexO-lkp@intel.com/

smatch warnings:
mm/memcontrol.c:1628 mem_cgroup_oom() error: uninitialized symbol 'locked'.

vim +/locked +1628 mm/memcontrol.c

9cbb78bb314360 David Rientjes    2012-07-31  1609  
becdf89d776c8f Shakeel Butt      2022-03-22  1610  /*
becdf89d776c8f Shakeel Butt      2022-03-22  1611   * Returns true if successfully killed one or more processes. Though in some
becdf89d776c8f Shakeel Butt      2022-03-22  1612   * corner cases it can return true even without killing any process.
becdf89d776c8f Shakeel Butt      2022-03-22  1613   */
becdf89d776c8f Shakeel Butt      2022-03-22  1614  static bool mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order)
867578cbccb089 KAMEZAWA Hiroyuki 2010-03-10  1615  {
becdf89d776c8f Shakeel Butt      2022-03-22  1616  	bool locked, ret;
7056d3a37d2c6a Michal Hocko      2018-12-28  1617  
29ef680ae7c211 Michal Hocko      2018-08-17  1618  	if (order > PAGE_ALLOC_COSTLY_ORDER)
becdf89d776c8f Shakeel Butt      2022-03-22  1619  		return false;
29ef680ae7c211 Michal Hocko      2018-08-17  1620  
7a1adfddaf0d11 Roman Gushchin    2018-10-26  1621  	memcg_memory_event(memcg, MEMCG_OOM);
7a1adfddaf0d11 Roman Gushchin    2018-10-26  1622  
a0861053f33ce1 Roman Gushchin    2024-05-08  1623  	if (!memcg1_oom_prepare(memcg, &locked))
becdf89d776c8f Shakeel Butt      2022-03-22  1624  		return false;
29ef680ae7c211 Michal Hocko      2018-08-17  1625  
becdf89d776c8f Shakeel Butt      2022-03-22  1626  	ret = mem_cgroup_out_of_memory(memcg, mask, order);
7056d3a37d2c6a Michal Hocko      2018-12-28  1627  
a0861053f33ce1 Roman Gushchin    2024-05-08 @1628  	memcg1_oom_finish(memcg, locked);
29ef680ae7c211 Michal Hocko      2018-08-17  1629  
7056d3a37d2c6a Michal Hocko      2018-12-28  1630  	return ret;
3812c8c8f39539 Johannes Weiner   2013-09-12  1631  }
3812c8c8f39539 Johannes Weiner   2013-09-12  1632  

:::::: The code at line 1628 was first introduced by commit
:::::: a0861053f33ce10fc6e36c20b13e1c915eae4c9a mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c

:::::: TO: Roman Gushchin <roman.gushchin@linux.dev>
:::::: CC: Roman Gushchin <roman.gushchin@linux.dev>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki