All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	"Köry Maincent" <kory.maincent@bootlin.com>,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Nicolò Veronese" <nicveronese@gmail.com>,
	"Simon Horman" <horms@kernel.org>,
	mwojtas@chromium.org, "Nathan Chancellor" <nathan@kernel.org>,
	"Antoine Tenart" <atenart@kernel.org>
Subject: Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect
Date: Thu, 6 Jun 2024 08:57:34 +0200	[thread overview]
Message-ID: <20240606085734.73334c68@fedora> (raw)
In-Reply-To: <20240605201025.764f0881@kernel.org>

Hello Jakub,

On Wed, 5 Jun 2024 20:10:25 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Wed,  5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote:
> > +/**
> > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY
> > + * @upstream: pointer to the upstream phy device
> > + * @phy: pointer to the SFP module's phy device
> > + *
> > + * This helper allows keeping track of PHY devices on the link. It adds the
> > + * SFP module's phy to the phy namespace of the upstream phy
> > + */
> > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy)  
> 
> We run scripts/kernel-doc with -Wall now, it wants return values
> to be documented, too. 

OK, I'll address that and make sure to run this script on all the
patches in the series.

Thanks,

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	"Köry Maincent" <kory.maincent@bootlin.com>,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Nicolò Veronese" <nicveronese@gmail.com>,
	"Simon Horman" <horms@kernel.org>,
	mwojtas@chromium.org, "Nathan Chancellor" <nathan@kernel.org>,
	"Antoine Tenart" <atenart@kernel.org>
Subject: Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect
Date: Thu, 6 Jun 2024 08:57:34 +0200	[thread overview]
Message-ID: <20240606085734.73334c68@fedora> (raw)
In-Reply-To: <20240605201025.764f0881@kernel.org>

Hello Jakub,

On Wed, 5 Jun 2024 20:10:25 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Wed,  5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote:
> > +/**
> > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY
> > + * @upstream: pointer to the upstream phy device
> > + * @phy: pointer to the SFP module's phy device
> > + *
> > + * This helper allows keeping track of PHY devices on the link. It adds the
> > + * SFP module's phy to the phy namespace of the upstream phy
> > + */
> > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy)  
> 
> We run scripts/kernel-doc with -Wall now, it wants return values
> to be documented, too. 

OK, I'll address that and make sure to run this script on all the
patches in the series.

Thanks,

Maxime

  reply	other threads:[~2024-06-06  6:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 12:49 [PATCH net-next v12 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
2024-06-05 12:49 ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 01/13] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-06  3:10   ` Jakub Kicinski
2024-06-06  3:10     ` Jakub Kicinski
2024-06-06  6:57     ` Maxime Chevallier [this message]
2024-06-06  6:57       ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 04/13] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 05/13] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 06/13] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 07/13] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 08/13] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 09/13] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 10/13] net: ethtool: pse-pd: " Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-06  8:41   ` Kory Maincent
2024-06-06  8:41     ` Kory Maincent
2024-06-05 12:49 ` [PATCH net-next v12 11/13] net: ethtool: cable-test: " Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 12/13] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier
2024-06-05 12:49 ` [PATCH net-next v12 13/13] Documentation: networking: document phy_link_topology Maxime Chevallier
2024-06-05 12:49   ` Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606085734.73334c68@fedora \
    --to=maxime.chevallier@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=herve.codina@bootlin.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kabel@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mwojtas@chromium.org \
    --cc=nathan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicveronese@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=piergiorgio.beruto@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.