From: Michael Walle <mwalle@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Li Yang <leoyang.li@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Priit Laes <plaes@plaes.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Michael Walle <mwalle@kernel.org>
Subject: [PATCH v2 02/13] ARM: dts: imx6qdl-kontron-samx6i: fix PHY reset
Date: Thu, 6 Jun 2024 11:01:55 +0200 [thread overview]
Message-ID: <20240606090206.2021237-3-mwalle@kernel.org> (raw)
In-Reply-To: <20240606090206.2021237-1-mwalle@kernel.org>
The PHY reset line is connected to both the SoC (GPIO1_25) and
the CPLD. We must not use the GPIO1_25 as it will drive against
the output buffer of the CPLD. Instead there is another GPIO
(GPIO2_01), an input to the CPLD, which will tell the CPLD to
assert the PHY reset line.
Fixes: 2a51f9dae13d ("ARM: dts: imx6qdl-kontron-samx6i: Add iMX6-based Kontron SMARC-sAMX6i module")
Fixes: 5694eed98cca ("ARM: dts: imx6qdl-kontron-samx6i: move phy reset into phy-node")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
index d8c1dfb8c9ab..d6c049b9a9c6 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
@@ -269,7 +269,7 @@ mdio {
ethphy: ethernet-phy@1 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <1>;
- reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
reset-assert-us = <1000>;
};
};
@@ -516,7 +516,7 @@ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0
MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0
MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1b0b0
- MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0 /* RST_GBE0_PHY# */
+ MX6QDL_PAD_NANDF_D1__GPIO2_IO01 0x1b0b0 /* RST_GBE0_PHY# */
>;
};
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <mwalle@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Li Yang <leoyang.li@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Priit Laes <plaes@plaes.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Michael Walle <mwalle@kernel.org>
Subject: [PATCH v2 02/13] ARM: dts: imx6qdl-kontron-samx6i: fix PHY reset
Date: Thu, 6 Jun 2024 11:01:55 +0200 [thread overview]
Message-ID: <20240606090206.2021237-3-mwalle@kernel.org> (raw)
In-Reply-To: <20240606090206.2021237-1-mwalle@kernel.org>
The PHY reset line is connected to both the SoC (GPIO1_25) and
the CPLD. We must not use the GPIO1_25 as it will drive against
the output buffer of the CPLD. Instead there is another GPIO
(GPIO2_01), an input to the CPLD, which will tell the CPLD to
assert the PHY reset line.
Fixes: 2a51f9dae13d ("ARM: dts: imx6qdl-kontron-samx6i: Add iMX6-based Kontron SMARC-sAMX6i module")
Fixes: 5694eed98cca ("ARM: dts: imx6qdl-kontron-samx6i: move phy reset into phy-node")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
index d8c1dfb8c9ab..d6c049b9a9c6 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
@@ -269,7 +269,7 @@ mdio {
ethphy: ethernet-phy@1 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <1>;
- reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
reset-assert-us = <1000>;
};
};
@@ -516,7 +516,7 @@ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0
MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0
MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1b0b0
- MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0 /* RST_GBE0_PHY# */
+ MX6QDL_PAD_NANDF_D1__GPIO2_IO01 0x1b0b0 /* RST_GBE0_PHY# */
>;
};
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-06 9:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 9:01 [PATCH v2 00/13] ARM: dts: kontron-samx6i: various fixes Michael Walle
2024-06-06 9:01 ` Michael Walle
2024-06-06 9:01 ` [PATCH v2 01/13] ARM: dts: imx6qdl-kontron-samx6i: fix phy-mode Michael Walle
2024-06-06 9:01 ` Michael Walle
2024-06-17 1:39 ` Shawn Guo
2024-06-06 9:01 ` Michael Walle [this message]
2024-06-06 9:01 ` [PATCH v2 02/13] ARM: dts: imx6qdl-kontron-samx6i: fix PHY reset Michael Walle
2024-06-06 9:01 ` [PATCH v2 03/13] ARM: dts: imx6qdl-kontron-samx6i: fix board reset Michael Walle
2024-06-06 9:01 ` Michael Walle
2024-06-17 1:39 ` Shawn Guo
2024-06-06 9:01 ` [PATCH v2 04/13] ARM: dts: imx6qdl-kontron-samx6i: cleanup the PMIC node Michael Walle
2024-06-06 9:01 ` Michael Walle
2024-06-06 9:01 ` [PATCH v2 05/13] ARM: dts: imx6qdl-kontron-samx6i: fix SPI0 chip selects Michael Walle
2024-06-06 9:01 ` Michael Walle
2024-06-06 9:01 ` [PATCH v2 06/13] ARM: dts: imx6qdl-kontron-samx6i: fix product name Michael Walle
2024-06-06 9:01 ` Michael Walle
2024-06-06 9:02 ` [PATCH v2 07/13] ARM: dts: imx6qdl-kontron-samx6i: always enable eMMC Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-06 9:02 ` [PATCH v2 08/13] ARM: dts: imx6qdl-kontron-samx6i: add SDIO_PWR_EN support Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-17 1:40 ` Shawn Guo
2024-06-06 9:02 ` [PATCH v2 09/13] ARM: dts: imx6qdl-kontron-samx6i: fix node names Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-17 1:41 ` Shawn Guo
2024-06-06 9:02 ` [PATCH v2 10/13] ARM: dts: imx6qdl-kontron-samx6i: fix PCIe reset polarity Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-06 9:02 ` [PATCH v2 11/13] ARM: dts: imx6qdl-kontron-samx6i: remove wake-up-gpio property Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-06 9:02 ` [PATCH v2 12/13] dt-bindings: arm: fsl: document Kontron SMARC-sAMX6i boards Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-06 9:02 ` [PATCH v2 13/13] ARM: dts: imx6qdl-kontron-samx6i: add actual device trees Michael Walle
2024-06-06 9:02 ` Michael Walle
2024-06-17 1:51 ` Shawn Guo
2024-06-06 15:56 ` [PATCH v2 00/13] ARM: dts: kontron-samx6i: various fixes Rob Herring (Arm)
2024-06-06 15:56 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606090206.2021237-3-mwalle@kernel.org \
--to=mwalle@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=plaes@plaes.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.