All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes
@ 2024-06-07  8:58 Ricardo Ribalda
  2024-06-07  8:58 ` [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Ricardo Ribalda @ 2024-06-07  8:58 UTC (permalink / raw)
  To: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Marcel Apfelbaum,
	Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-devel,
	Andrea Righi
  Cc: Ricardo Ribalda

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..b2c2c10cbc 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT",
-- 
2.45.2.505.gda0bf45e8d-goog



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table
  2024-06-07  8:58 [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
@ 2024-06-07  8:58 ` Ricardo Ribalda
  2024-06-07  9:30   ` Michael S. Tsirkin
  2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
  2024-06-07  9:33 ` [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Michael S. Tsirkin
  2 siblings, 1 reply; 6+ messages in thread
From: Ricardo Ribalda @ 2024-06-07  8:58 UTC (permalink / raw)
  To: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Marcel Apfelbaum,
	Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-devel,
	Andrea Righi
  Cc: Ricardo Ribalda

When qemu runs without kvm acceleration the ACPI executions take a great
amount of time. If they take more than the default time (30sec), the
ACPI calls fail and the system might not behave correctly.

Now the _PRT table is computed on the fly. We can drastically reduce the
execution of the _PRT method if we return a pre-computed table.

Without this patch:
[   51.343484] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
[   51.527032] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
[   51.530049] virtio-pci 0000:00:02.0: can't derive routing for PCI INT A
[   51.530797] virtio-pci 0000:00:02.0: PCI INT A: no GSI
[   81.922901] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
[   82.103534] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
[   82.106088] virtio-pci 0000:00:04.0: can't derive routing for PCI INT A
[   82.106761] virtio-pci 0000:00:04.0: PCI INT A: no GSI
[  112.192568] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
[  112.486687] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
[  112.489554] virtio-pci 0000:00:05.0: can't derive routing for PCI INT A
[  112.490027] virtio-pci 0000:00:05.0: PCI INT A: no GSI
[  142.559448] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
[  142.718596] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
[  142.722889] virtio-pci 0000:00:06.0: can't derive routing for PCI INT A
[  142.724578] virtio-pci 0000:00:06.0: PCI INT A: no GSI

With this patch:
[   22.938076] ACPI: \_SB_.LNKB: Enabled at IRQ 10
[   24.214002] ACPI: \_SB_.LNKD: Enabled at IRQ 11
[   25.465170] ACPI: \_SB_.LNKA: Enabled at IRQ 10
[   27.944920] ACPI: \_SB_.LNKC: Enabled at IRQ 11

ACPI disassembly:
        Scope (PCI0)
        {
            Method (_PRT, 0, NotSerialized)  // _PRT: PCI Routing Table
            {
                Return (Package (0x80)
                {
                    Package (0x04)
                    {
                        0xFFFF,
                        Zero,
                        LNKD,
                        Zero
                    },

                    Package (0x04)
                    {
                        0xFFFF,
                        One,
                        LNKA,
                        Zero
                    },

                    Package (0x04)
                    {
                        0xFFFF,
                        0x02,
                        LNKB,
                        Zero
                    },

                    Package (0x04)
                    {
                        0xFFFF,
                        0x03,
                        LNKC,
                        Zero
                    },

                    Package (0x04)
                    {
                        0x0001FFFF,
                        Zero,
                        LNKS,
                        Zero
                    },
Context: https://lore.kernel.org/virtualization/20240417145544.38d7b482@imammedo.users.ipa.redhat.com/T/#t

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 hw/i386/acpi-build.c | 118 ++++++++-----------------------------------
 1 file changed, 21 insertions(+), 97 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 53f804ac16..4c14d39173 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -725,40 +725,7 @@ static Aml *aml_pci_pdsm(void)
     return method;
 }
 
-/**
- * build_prt_entry:
- * @link_name: link name for PCI route entry
- *
- * build AML package containing a PCI route entry for @link_name
- */
-static Aml *build_prt_entry(const char *link_name)
-{
-    Aml *a_zero = aml_int(0);
-    Aml *pkg = aml_package(4);
-    aml_append(pkg, a_zero);
-    aml_append(pkg, a_zero);
-    aml_append(pkg, aml_name("%s", link_name));
-    aml_append(pkg, a_zero);
-    return pkg;
-}
-
-/*
- * initialize_route - Initialize the interrupt routing rule
- * through a specific LINK:
- *  if (lnk_idx == idx)
- *      route using link 'link_name'
- */
-static Aml *initialize_route(Aml *route, const char *link_name,
-                             Aml *lnk_idx, int idx)
-{
-    Aml *if_ctx = aml_if(aml_equal(lnk_idx, aml_int(idx)));
-    Aml *pkg = build_prt_entry(link_name);
-
-    aml_append(if_ctx, aml_store(pkg, route));
-
-    return if_ctx;
-}
-
+#define N_ROUTES 128
 /*
  * build_prt - Define interrupt rounting rules
  *
@@ -771,74 +738,31 @@ static Aml *initialize_route(Aml *route, const char *link_name,
  */
 static Aml *build_prt(bool is_pci0_prt)
 {
-    Aml *method, *while_ctx, *pin, *res;
+    Aml *rt_pkg, *method;
+    const char link_name[][2] = {"D", "A", "B", "C"};
+    int i;
 
     method = aml_method("_PRT", 0, AML_NOTSERIALIZED);
-    res = aml_local(0);
-    pin = aml_local(1);
-    aml_append(method, aml_store(aml_package(128), res));
-    aml_append(method, aml_store(aml_int(0), pin));
+    rt_pkg = aml_varpackage(N_ROUTES);
 
-    /* while (pin < 128) */
-    while_ctx = aml_while(aml_lless(pin, aml_int(128)));
-    {
-        Aml *slot = aml_local(2);
-        Aml *lnk_idx = aml_local(3);
-        Aml *route = aml_local(4);
-
-        /* slot = pin >> 2 */
-        aml_append(while_ctx,
-                   aml_store(aml_shiftright(pin, aml_int(2), NULL), slot));
-        /* lnk_idx = (slot + pin) & 3 */
-        aml_append(while_ctx,
-            aml_store(aml_and(aml_add(pin, slot, NULL), aml_int(3), NULL),
-                      lnk_idx));
-
-        /* route[2] = "LNK[D|A|B|C]", selection based on pin % 3  */
-        aml_append(while_ctx, initialize_route(route, "LNKD", lnk_idx, 0));
-        if (is_pci0_prt) {
-            Aml *if_device_1, *if_pin_4, *else_pin_4;
-
-            /* device 1 is the power-management device, needs SCI */
-            if_device_1 = aml_if(aml_equal(lnk_idx, aml_int(1)));
-            {
-                if_pin_4 = aml_if(aml_equal(pin, aml_int(4)));
-                {
-                    aml_append(if_pin_4,
-                        aml_store(build_prt_entry("LNKS"), route));
-                }
-                aml_append(if_device_1, if_pin_4);
-                else_pin_4 = aml_else();
-                {
-                    aml_append(else_pin_4,
-                        aml_store(build_prt_entry("LNKA"), route));
-                }
-                aml_append(if_device_1, else_pin_4);
-            }
-            aml_append(while_ctx, if_device_1);
-        } else {
-            aml_append(while_ctx, initialize_route(route, "LNKA", lnk_idx, 1));
+    for (i = 0; i < N_ROUTES; i++) {
+        Aml *pkg = aml_package(4);
+        const char *name;
+
+        name = link_name[((i >> 2) + i) & 3];
+
+        if (is_pci0_prt && i == 4) {
+            name = "S";
         }
-        aml_append(while_ctx, initialize_route(route, "LNKB", lnk_idx, 2));
-        aml_append(while_ctx, initialize_route(route, "LNKC", lnk_idx, 3));
-
-        /* route[0] = 0x[slot]FFFF */
-        aml_append(while_ctx,
-            aml_store(aml_or(aml_shiftleft(slot, aml_int(16)), aml_int(0xFFFF),
-                             NULL),
-                      aml_index(route, aml_int(0))));
-        /* route[1] = pin & 3 */
-        aml_append(while_ctx,
-            aml_store(aml_and(pin, aml_int(3), NULL),
-                      aml_index(route, aml_int(1))));
-        /* res[pin] = route */
-        aml_append(while_ctx, aml_store(route, aml_index(res, pin)));
-        /* pin++ */
-        aml_append(while_ctx, aml_increment(pin));
+
+        aml_append(pkg, aml_int((i << 14) | 0xFFFF));
+        aml_append(pkg, aml_int(i & 3));
+        aml_append(pkg, aml_name("LNK%s", name));
+        aml_append(pkg, aml_int(0));
+        aml_append(rt_pkg, pkg);
     }
-    aml_append(method, while_ctx);
-    /* return res*/
-    aml_append(method, aml_return(res));
+
+    aml_append(method, aml_return(rt_pkg));
 
     return method;
 }
-- 
2.45.2.505.gda0bf45e8d-goog



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT
  2024-06-07  8:58 [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
  2024-06-07  8:58 ` [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
@ 2024-06-07  8:58 ` Ricardo Ribalda
  2024-06-07  9:33   ` Michael S. Tsirkin
  2024-06-07  9:33 ` [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Michael S. Tsirkin
  2 siblings, 1 reply; 6+ messages in thread
From: Ricardo Ribalda @ 2024-06-07  8:58 UTC (permalink / raw)
  To: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Marcel Apfelbaum,
	Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-devel,
	Andrea Righi
  Cc: Ricardo Ribalda

--- /tmp/asl-87N0O2.dsl	2024-06-07 07:20:54.081576394 +0000
+++ /tmp/asl-4Q0YO2.dsl	2024-06-07 07:20:54.077576397 +0000
@@ -1,30 +1,30 @@
 /*
  * Intel ACPI Component Architecture
  * AML/ASL+ Disassembler version 20230628 (64-bit version)
  * Copyright (c) 2000 - 2023 Intel Corporation
  *
  * Disassembling to symbolic ASL+ operators
  *
- * Disassembly of tests/data/acpi/pc/DSDT, Fri Jun  7 07:20:54 2024
+ * Disassembly of /tmp/aml-NF1YO2, Fri Jun  7 07:20:54 2024
  *
  * Original Table Header:
  *     Signature        "DSDT"
- *     Length           0x00001AAE (6830)
+ *     Length           0x0000214F (8527)
  *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
- *     Checksum         0x0B
+ *     Checksum         0x59
  *     OEM ID           "BOCHS "
  *     OEM Table ID     "BXPC    "
  *     OEM Revision     0x00000001 (1)
  *     Compiler ID      "BXPC"
  *     Compiler Version 0x00000001 (1)
  */
 DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    ", 0x00000001)
 {
     Scope (\)
     {
         OperationRegion (DBG, SystemIO, 0x0402, One)
         Field (DBG, ByteAcc, NoLock, Preserve)
         {
             DBGB,   8
         }

@@ -168,102 +168,1058 @@
                         ""
                     }
                 Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
                     ))
                 Local0 [Zero] = Local2
                 Return (Local0)
             }
         }
     }

     Scope (_SB)
     {
         Scope (PCI0)
         {
             Method (_PRT, 0, NotSerialized)  // _PRT: PCI Routing Table
             {
-                Local0 = Package (0x80){}
-                Local1 = Zero
-                While ((Local1 < 0x80))
+                Return (Package (0x80)
                 {
-                    Local2 = (Local1 >> 0x02)
-                    Local3 = ((Local1 + Local2) & 0x03)
-                    If ((Local3 == Zero))
-                    {
-                        Local4 = Package (0x04)
-                            {
-                                Zero,
-                                Zero,
-                                LNKD,
-                                Zero
-                            }
-                    }
+                    Package (0x04)
+                    {
+                        0xFFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },

-                    If ((Local3 == One))
+                    Package (0x04)
                     {
-                        If ((Local1 == 0x04))
-                        {
-                            Local4 = Package (0x04)
-                                {
-                                    Zero,
-                                    Zero,
-                                    LNKS,
-                                    Zero
-                                }
-                        }
-                        Else
-                        {
-                            Local4 = Package (0x04)
-                                {
-                                    Zero,
-                                    Zero,
-                                    LNKA,
-                                    Zero
-                                }
-                        }
-                    }
+                        0xFFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },

-                    If ((Local3 == 0x02))
+                    Package (0x04)
                     {
-                        Local4 = Package (0x04)
-                            {
-                                Zero,
-                                Zero,
-                                LNKB,
-                                Zero
-                            }
-                    }
+                        0xFFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },

-                    If ((Local3 == 0x03))
+                    Package (0x04)
                     {
-                        Local4 = Package (0x04)
-                            {
-                                Zero,
-                                Zero,
-                                LNKC,
-                                Zero
-                            }
-                    }
+                        0xFFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },

-                    Local4 [Zero] = ((Local2 << 0x10) | 0xFFFF)
-                    Local4 [One] = (Local1 & 0x03)
-                    Local0 [Local1] = Local4
-                    Local1++
-                }
+                    Package (0x04)
+                    {
+                        0x0001FFFF,
+                        Zero,
+                        LNKS,
+                        Zero
+                    },

-                Return (Local0)
+                    Package (0x04)
+                    {
+                        0x0001FFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0001FFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0001FFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0002FFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0002FFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0002FFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0002FFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0003FFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0003FFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0003FFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0003FFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0004FFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0004FFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0004FFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0004FFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0005FFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0005FFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0005FFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0005FFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0006FFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0006FFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0006FFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0006FFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0007FFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0007FFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0007FFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0007FFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0008FFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0008FFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0008FFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0008FFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0009FFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0009FFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0009FFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0009FFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000AFFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000AFFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000AFFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000AFFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000BFFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000BFFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000BFFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000BFFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000CFFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000CFFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000CFFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000CFFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000DFFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000DFFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000DFFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000DFFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000EFFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000EFFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000EFFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000EFFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000FFFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000FFFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000FFFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x000FFFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0010FFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0010FFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0010FFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0010FFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0011FFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0011FFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0011FFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0011FFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0012FFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0012FFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0012FFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0012FFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0013FFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0013FFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0013FFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0013FFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0014FFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0014FFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0014FFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0014FFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0015FFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0015FFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0015FFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0015FFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0016FFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0016FFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0016FFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0016FFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0017FFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0017FFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0017FFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0017FFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0018FFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0018FFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0018FFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0018FFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0019FFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0019FFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0019FFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x0019FFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001AFFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001AFFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001AFFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001AFFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001BFFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001BFFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001BFFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001BFFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001CFFFF,
+                        Zero,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001CFFFF,
+                        One,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001CFFFF,
+                        0x02,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001CFFFF,
+                        0x03,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001DFFFF,
+                        Zero,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001DFFFF,
+                        One,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001DFFFF,
+                        0x02,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001DFFFF,
+                        0x03,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001EFFFF,
+                        Zero,
+                        LNKB,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001EFFFF,
+                        One,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001EFFFF,
+                        0x02,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001EFFFF,
+                        0x03,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001FFFFF,
+                        Zero,
+                        LNKC,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001FFFFF,
+                        One,
+                        LNKD,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001FFFFF,
+                        0x02,
+                        LNKA,
+                        Zero
+                    },
+
+                    Package (0x04)
+                    {
+                        0x001FFFFF,
+                        0x03,
+                        LNKB,
+                        Zero
+                    }
+                })
             }
         }

         Method (IQST, 1, NotSerialized)
         {
             If ((0x80 & Arg0))
             {
                 Return (0x09)
             }

             Return (0x0B)
         }

         Method (IQCR, 1, Serialized)
         {
             Name (PRR0, ResourceTemplate ()
**

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 tests/data/acpi/pc/DSDT                     | Bin 6830 -> 8527 bytes
 tests/data/acpi/pc/DSDT.acpierst            | Bin 6741 -> 8438 bytes
 tests/data/acpi/pc/DSDT.acpihmat            | Bin 8155 -> 9852 bytes
 tests/data/acpi/pc/DSDT.bridge              | Bin 13701 -> 15398 bytes
 tests/data/acpi/pc/DSDT.cphp                | Bin 7294 -> 8991 bytes
 tests/data/acpi/pc/DSDT.dimmpxm             | Bin 8484 -> 10181 bytes
 tests/data/acpi/pc/DSDT.hpbridge            | Bin 6781 -> 8478 bytes
 tests/data/acpi/pc/DSDT.hpbrroot            | Bin 3337 -> 5034 bytes
 tests/data/acpi/pc/DSDT.ipmikcs             | Bin 6902 -> 8599 bytes
 tests/data/acpi/pc/DSDT.memhp               | Bin 8189 -> 9886 bytes
 tests/data/acpi/pc/DSDT.nohpet              | Bin 6688 -> 8385 bytes
 tests/data/acpi/pc/DSDT.numamem             | Bin 6836 -> 8533 bytes
 tests/data/acpi/pc/DSDT.roothp              | Bin 10623 -> 12320 bytes
 tests/data/acpi/q35/DSDT.cxl                | Bin 9714 -> 13148 bytes
 tests/data/acpi/q35/DSDT.viot               | Bin 9464 -> 14615 bytes
 tests/qtest/bios-tables-test-allowed-diff.h |   1 -
 16 files changed, 1 deletion(-)

diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
index c93ad6b7f83a168a1833d7dba1112dd2ab8a431f..92225236e717b2e522a2ee00492fb0ded418dc7b 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPmVc7`lmCBo0R=kA0^&G>phg?inPg;S4auBYNk<(QD7uD@yN<4c
zy?hjfcW1ixyAY2k+COjp9<$Ts^z`+EF^%V6*~i2_e7|0f*U|ay@$TW%^#1Mo`0dI3
zn4Dj;_cBj&=gj%b=aUK74P4)vvhbg03BoakCc>R5`)T1^!}!jnPQHb~LHJI37!A>y
z%vW&(sU}jzaFu*D&L&2x7?mobZ(=zz+mvQpLeuzW9BqasMx}}9n{pS6^`=sdOGu>}
zXVXxP%SY7GmNerMTGEW8t<a3CN7T@E1+`)IZK=lDHcJt;v_sMkNjoe>tfhc<3EK5d
z>mQ&zl`cyWwX{dl9!YyFMby%)k_Ko-(9Brc(~PA#Npq6sEJf7Pf~18sBec*^>m0I{
z_DR|&X`iKtS~?)<fTV-ajBg~OZ{C_}|A!<Ul61&YL@gbWbVSmTmO6*1p<~~a{g(qY
zCh3@^h+0~bv?OWCQp6w)`#&M*#8`b!CoDzO(kV%&B%QJpQA=mijK_4Qq1Me<im0V?
zlFmswXDOnVE=anNX59Wo4YhLikhOG4(j`fkEJf7P6-ifG>Q)RzMAOzky=#)LNxEh!
zqLyw*x*_SNmI@S6L$}6Oe=qV1Zb`ajDWaC{NV+5Gj-`mc8GqpS8v5e)B;B(VQA-ab
RJ&^RkQp6zr{V(~m_z%ZI%zOX<

delta 204
zcmX@_w9b^vCD<ioofHEDBlkuwU8Z^ullWk#cmZ#&0B27F5f`rbfS?eD0wJb`gaU@d
zMNXVk6S*1+suH=F7?KLAixQI<xR@D|7YIyF1}frYVPNp_^LAlKS)ejGnQ?*O<U}qO
zxNtB-%0gZ^&k?9daB?yi6I{dzBw`E{VulMjGo%#MRwi)?FmV6>&(M*=z)(<~2(+*x
Wg^{5kr6VDcp)_$x!saf{qv8OZMKp8(

diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
index f643fa2d034053fa07f74f095565b64f021d4290..25b39955059409b177870800949eaf937cd39005 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPmVc7`lmGv2pg;%NfD>mB)F^^Db0hQ4nmMzQ42o``=vumnZXi?k
z@=+Ato$1=|LOh~q|GoJ*W~a;P`Qwu@ji0}>&xw6_zg}*yqx0+I-NTpZ{p<Dd>Dm06
zoPT6*WuE5Fne(@=Cljt4xIUV)@SkT1!fgyqggaCA)55ui@tsSZd<%nv@SXH98lp9s
zui^$$O{9w9D*0-hO^j4ADpf?^#ByY|Db2Wqrt!@<+6+yMN)ypH<t`TMO{E%_kV-Yq
zrlA^_kEo?BX~reAq!~wBp&3_?sG;o&YQyT=QjN21mLh6thol{nc36s7O9AZ?wCkJJ
zKR|gZU6vwhX^*5mlJ;1NsHIsY4bY6BnX$B|8B24L<|NHoim0UpNegL4XrZCjIb<#E
zleACLK1&g`bU@MpNe7`B-$+E?Jeq3%ha?@6bjVUfEgg|`MADI#I)|vCW8akhmjg5=
z>6oR6T3V8{Bx%V~#2^j(KOyMESba_>EJf7PDM_a!ow5{BOJ~xI$8@Hl*3DRosHJm~
z&Ph6FDWaAxNV<?_-2O!kwQ}~5wRB0+B}tboMby$2Nmp9xRt!Z%)7C$|Ym%->x@IY&
zmTpM8A?c=;3KUU8x5id~FY*d*NxEezqL%JRx+Ce1rHH;6f8h5T`r`H^-Ln)?OAjPH
Qko3S(#323iFZsUs5AYbxUH||9

delta 204
zcmez7c-4f<CD<h-REmLtF?b`FE>pdSNqn$Vynr`XfU~E8hznPIKu`!nfe=$eLIFeK
zA}7wNiChf@Rf$|o3`qsmMTtoaT+9r~3j`)70~K+yFfjP|dAl&AEKr%8%(y^sav~QC
zTsW8^Wg#z|=Ll3JI60Y%2`=IU5-|n}F~fzN8Bz*rE0eec7`XrcXXr>_U?`|g1X|dU
W!pKmN(vgtJP@1?TVRIK}jyM3xel%79

diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
index 9d3695ff289036856886a093733926667a32a058..73a9ce59e9426b180fea0ec5820c4841ebdb6700 100644
GIT binary patch
delta 1914
zcmY+_OODe(6a~<V<NV6b&-wpn%#hdt>h3UT5uq08dBhs%AyTmtMr;7F99F=TaZAOm
zS1#+_nQ!v0T*u`~{=9#^*z@)L{Oye~t>rKKHgk_ZZrA(U<nr?L@c3^2;pO)9`PuxO
zUB24yRgo9oo6Dz<XA`emxV|%089uie!hH&Dga=a%^V0j437u<`LJNbV_?`4H8ly8d
zRB;2TW>Up)okBIuW=5(Ql`3LrVmUI~mS$Q)+k|EsZO0}?rHL4tau<j7=2A^d$fcTQ
z^H@#GN7T}eG}96~(oCbB*i5TO)X;7Xb#e7wsixU3OA)oSN75cidn`q4q=5Db+7C?^
z9-usxK1&g`bU@MpNe3)N)KXhZBh(Vq8b^C-Sz3^^AZfu;L@g~zT1qoPOAU42BWvl9
zq(hPpS&FEoBa)6tI*QHoMk0phovHVKOwut)$1FwE(g{f?B%Nrf_lO!g4Ncj9IY3jA
zPFaemr4>mll2$B5jMBLOGlI^H)8}-?QbaAClXOnfIZF|>bRo@jOcxsJ{DP&3TDm0Z
zlB7$PB5LW1q$_Er?O!!eCua{?OV=b_lXT5eL@nKrbfcwy!%##tUGvksCFz!=Tb3ef
z>5im3lI|L*KoK=`Z(RNNBCp_{q<fYkYUzQb2a+CGiWr*d2mYv`U;L4zN0uUL>4~H#
QlAc(K7^T1eX8-p80f2$c3jhEB

delta 204
zcmez4bK9QFCD<k8wmbs^<B5%2x=i&RCh@^e@dDml0nVNVA}(C<0YM=Q1wu>>2?Y#^
zi<~&8CUP|tR3&mTF(egK7bPY!a4|C^FA$iV3{=F)!oc9;=k3CfvOr~WGUEcl$%$Mn
zaN%Hvl!d%-o+D6^;N)a3Cb)<bNW>T@#0(d5W=JWhtxVz)VBr4$pP?g#fuW!}5olpY
W3L`^7N=HH>LuulYgw0)?pJV{0Fg61K

diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
index 840b45f354ac14c858d0af8fbd31e97949a65d4b..4cef454e379e1009141694e0f4036a2a701c80d7 100644
GIT binary patch
delta 1914
zcmY+_J8#=C6a`>fmS2+mlHc#GTY#W*mn7~G)Cht&yV0pb#$@QmF8vopr=ok&U)5j1
z9$t#VJ)4ew55!Lt?e8zYzh=kt@%h~cV;W!nWLJs3|9LszUPh<4$GiLM>BqOr<I}VG
zH95Uz-^x7AoinG0Pe&838@RqPW#K>15`^0rnh1BM?5Blu4dXlKI{6j`2jM&EVKhW*
zGGE0Fq?$+-!&UOtIGY%$VpOV#zKP|?Y*U(X2~FdhakLql7?mcXZ^~UP)|*N-E+Lg_
zoJ~VDE+0`#Thfe6Xh}1Uwn8(m9#KQv71V~+x1}0q+bl)Y(hf;GB<-*iv6cebC1}?-
zt$%>>RJtrh)Y2YFdnE0#6j4jFN*bUUK{I1%PcxS0B+W^hvlLNF3z8PnjL<?ut#im)
z+9zqBq<xkmYUzNa1CkCxGrp0CzIkJ+{U4HaNYWuo5w&zg(h*5VTIw94hK_wx_FoRr
zn51KtB5G+#(vqYlOA&)K?Ei$I6Jzx`ov;*9OQ$5Al61;aL@k|3Gal2KhFUjcDWaCn
zNjfL#oTZ3bx*+L7nsNIVHPp)4L)OwINtYyDvJ_EES0r6&sar7=5lvhF^sY&|Ch3}`
zh+4WK>4v16S}IUP4c!`B{k_O5xFzY9rHER(Bk7K$JC-8)X8eKQYv^aUC+VK0h+29e
S>4BsNmLdk}-+#%E_x}Nim&}L&

delta 204
zcmZ2h(VETW66_MvYRbUCD7leKm#N;vBtF<FUcj3xz}eG4#Dyz9ASi^PK!~X!p@1QA
zkrU_CM6QN{szfd(hNOb(qQoQyE@p=01p<?kfr>a;7#Mu~yj>Vl7N|^4W?UdRIgyJ6
zE*#8|vXB?fa|9|9oSe+X1Q&4vi5LTgnBhXs3@HV*l}TIz4BY?!GjyadFcefL0xj%F
WVPq&s=}1UqC{0|Fu(^wKju8N_-!y;#

diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
index dbc0141b2bbc77a6d806ff046dc137992c59a899..1dc928333d7ae7e4df6bb51d850af5e1cb480158 100644
GIT binary patch
delta 1914
zcmY+_yN=U97zN;o<J`v1&AHzTY9vb9-3>@9BD5mgM?3@D4=+Ir4KIMGc_3bb;mkiC
z>pz`O@*jCVk0<%}_Q!jBzMh{?uZ(H^`DI^c?(zHWdViZ-UY;Hv-^|~=+@3x?o1e4G
z7yGp;^1^#_`S{^%;&ltxccv=C=QcyQPoa(QV5(tWdfzgkb8S*+VQ>_`lO9H6bjF4%
zZXnf6su-?QsHWM>NEM?}MGQ?WM`qj7OiO5+&`hK4*u<zb5kph%;;`Oas%Z(iRMTu8
zt7-X&TH29jT0%#fX|xlYY4wO2+O453uD&bPG}~n<qL%hZ+9PR?rHG9b&^|%?q3OZ{
zl&8{XDWaARNID?tfTf69YHMkPT7p{RXiqIm3z8NjEm(@Er6oyAX(ni?q0W0`Egh0{
zNYWuo5w&zg(h*5Vv6<dT#L&Dm_5P1ZIwt9urHEQOA?bvq6D{=~QA4MpDf=%6XiCy4
zOA)oSB56g^ilvBA8ux!j(3x@ioX%K^sHJm~&Ph6FDWaAxq?wNCLPMQjuoO{Cmn2=1
zbjeagEnSgxCC#+`s|M=i>>+FEnxt!zu33txr5loNwA61HiioCbetNeg-I8?6QbaA?
zk#tAWT_Y7JqK58`tN&i)72K0_&r(D!J&^Q3(gRBoLo@xrA2sx|Ka%vwQba91k@Q5;
O6H5`J^!MNF+vY!d*vzW{

delta 204
zcmX}lKMR6T9EIWIpT%DU8ZAL%YY^1Xno1N#NV@CQyLSm1N-9Tby*Ovl7l^)JWsBo^
zc;VdUpDDS48=m`svVGA|y(}hCU`M7$zOx*4U5flo2+>jVSb#ljqhyqeBO?`w$aX9N
zX-F$mrgdcKz-sNe;MG8;N@Yn#dcy(uz1^%?9a%CZwGsO-<C?UF9B^?uBxIuX{i5K2
V$XI<?a0P-FF~goc<M-7ldq3fNG@}3j

diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
index 1294f655d418dbdccc095e0d47ab220869a61a07..9f71d2e58b1707e733584e38dab7f73f9bda5eb7 100644
GIT binary patch
delta 1914
zcmY+_J8s)R6a~-`Mg2(XNB#e0ssQO-S(XbULTp&>g{&d&$E`P!${Pr>1}`S7nA~~8
zA>QqHrFX$O9FFvH{Cvz#m($DV7h@Xlf3mNMefWL79IvDE>(kxCx9R=s_38P=d`!;2
zvbQo%bLY(Y$M=&7*9~0XnzHbpX9>bFh9<(DDf?;RT*LUzrB1$u!9n;=dKeASn#@;m
z1F0rb#c-8;HO?kRsu-0jqHkh3GTW49Ttd_MW*lvXCPt-+=$mpEi}j{bjY~+S8fVi`
zjmt;W(v~#i5?a!Xqpi@4t4Gw(b_KOz^=+xf*)~fNwX{Rh4oN#KMXaTOb_v?`P3s?^
zJe4j>5w)~O(jG~BEJf7Ptda(3M$pVy+S81sIZ1Pp<}5|j(t@OgG$XXoQ0pABmi9^7
zCuyIhh*~-z>42nz(2Q>+qHo@sYX65M9g=j&Qba8sk#t1Tk(N4#sG(!ul>L_jG$!eo
zrHEQulC&gg$x_514f{VK=)_okPA4oy)Y2(QrzD-S6j4iO(u~J+rlHo&Sc<5nbCS+U
zI%g@OmM%!TkY?QeMGdub_K>x7Nzx@rmn=op(iKTpTIyB|MMTrqKfP;`u1UIPDWaBc
zNV*~Erj`m6QA4-JR(~(@3T{cdWhtVT?nt^L>5ip{z8Qbu_Zs@s?Mb?4DWaAhNO~aY
Ofu)E+`uAUQv;PnBGR&(0

delta 204
zcmX@=zr=~lCD<iIMUjDl(P|@?E>pdSNqn$Vynr`XfU~E8hznPIKu`!nfe=$eLIFeK
zA}7wNiChf@Rf$|o3`qsmMTtoaT+9r~3j`)70~K+yFfjP|dAl&AEKr%8%(y^sav~QC
zTsW8^Wg#z|=Ll3JI60Y%2`=IU5-|n}F~fzN8Bz*rE0eec7`XrcXXr>_U?`|g1X|dU
W!pKmN(vgtJP@1?TVRIL!wHyFm@-w3V

diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
index 8012b5eb3155377dc7995b73059ecb267d19232c..db420593a3c51eced25cd57420353fbb9ccdf63c 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPmVc7`lmCBY0RcMb2I4q_AVv_xnHyb0GiNu@S;rZ514UQWMHI~C
zqbR&P)3x7)ctp|u|MlaToi3-h{f#k=pMSF3#6EspFURZX{Qh$P_+|R=etmg;GruS2
z@7a$sPjlzY`T6N&!gT}Jccv`-=UIYqjG>8eZ_0jJIM*<~bE%VWVQ>(>lO9Gxv?lXa
z+(4>{R54s7UyZYgkt#-|is+kIj?6Zt8JEyBz8OcGp@~sxBKoG>#bUjwRO1p-sm9qf
zRO9jywX`M8xP+E8<7g{1<LVJLv|T}MSbbZnakkA;L@n)*v_sMkOA%`+pk0D?ebf2}
zC{Lx!QbaB7k+etB9!n9mG^?Zmnh`WJmi9DbX-?9dq&Z6wwX`5<A<YOaG}JnWtfhUD
z_DR}jDWaARNID?tAT;9}iRhbmrrQ4@NrxmIvJ_EEM<gAQbfl%uA!_K@H)a3j0F6mH
zW+|eUmLx4nTCx-|NW=b52s$xVpVJ9T5w&zm(kV%&EJf7PnKa`uooT3bGnOK1>71l<
zlFnI*sHF>%E~FW^e^EoNoIPYMU6OQ3(j`j~wRA<&m6o~{LlM!m^-u4bq-&C{S&FEo
z8<K8Fx~ZiCMbyx(vDM#;yn<VjZdr<`r8|=DNV;PwqHo3@_`QaHb9<8RS&FEo2a+C0
PdSEGHkpBIb{91ehwR6mC

delta 204
zcmX}lu?m7v7{&49)x|FYjUZ@l4T9VwbtsIGbl0o*0WLv9iR37))*2SQK=gcJwm6<2
ze>ivhYmpncVLk?w#ha$=yt1Oejtq}{XFVIb6#2Ula=?mMf<JBj#;K4eP7I06_B;Wp
zNNb}?+ep`d&DL`v>PeL<wOMh}Iu0Nn{cbJW$gEOgo!Ebwx1@IDK*;=<kbz#)pcH`2
Uczak11yYnT$AQ1%&qcqEezU1GV*mgE

diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpbrroot
index 4fa0c6fe720f7859f0541b82f828c0329a3c0548..31b6adb4eb941e5bf0c02ec8c3819c9213adf022 100644
GIT binary patch
delta 1913
zcmY+_yKdVs7zJS3mT#1NlkfL2YhEFVI|Ma~pw4dO0Wvjf!LA*<7o9p~?F;oyn8Tl<
z@Sjb`{twJg6y=|r_Zxe<oSxsO#x%bFvj5%VpX=rRIzGQWJv`pdKD}L^zCN43)AKj`
zqs+71dvpHs`DEgC1J`$^EW+ouiEy7n3*o_(gRJnrVM6Cpr_jRSFn%XJjK=7U4ORSr
zRGU)8aFs$e%{GlxF)CHW(8O|Nwk6H9gq8`-G}?+yj7k$RH04(u)|*K+Eg_R?n$2Q0
zEgw-!+tN%+XiGDVwqrA`9#KO(71YJmcchwTJ1j-i(k@B6B<->kv6cebBWN!)UATdA
zS9&Z()Y3jl`y}nN6j4iUC5=!^P-`6Rsby(S(ww9@OA)oSAZa1Z1T8ewd5^561CkC%
zI$$ZHmJUfeB<V0V(-Vmpns=t!{}D+?BptC7QA@`p9g}pdrQRcI=p-~{|K$KpNIGFD
zqL!8<ElFCk6fsKU{^Pv^cRHq1<McV5vJ_EEXC$4GbjDIdEuBj<9n-mnIzMMAqLwa5
zx*+L-rHER(B<WI`Y5SKo)XCXH*3uP8S0r7r6j4jpBwcH%Uo#XDO;^8qHzeJVbi-0a
zE!~oIOVVvE6)2*H?u@JcUgQznk#xsWL@nKubWhSfOA$jez2FZT`r;2HJ+Kr}OOGTy
QlJv+@#3=puyYZTT0De=<OaK4?

delta 203
zcmZ3b-YLc966_Mf$;-gNs5g=8LA{4be6UlzfHzlwv!{WG3s-zVPzXbT5K}`!0Yl;<
zC(fyfTnz<PiCjz!Nd?tKiAfAx%nZp31STf~6>+jKF!=a+yD+3IP??;}xIl1nA{Pr>
zIG7=2AupWg2vj6EIhl(IF5(0dF$M}T!-bp~QVMD-leh#Jxc~oW=tyB;D5y>ZTG)}o
V$WV~dk&wtxnz$rkvn@w1HvlZSGeiIY

diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
index 0a891baf458abee4a772ffba7a31914ec22418ec..c2a0330d97d495298889b9e28bde2f90235cea88 100644
GIT binary patch
delta 1914
zcmY+_Np9OP7zJQjmM0A!<atI9P@tP0AhELuViZB0z0or?d-fLDb=3<LJxdSK3v|mo
z{uG7(?ey&bLHtC~{{Q*yl%22Vm$whbwEq6iJ|_0@=k0ob8(&_ZPmiBw53jf9uP^4;
z^zuFXQRQjwoVk2?I-79a!u6f03jcYQAl%2$MmU+OObh2)#&@nw@+}Mw!*|ldXo%Ki
zzKR=2HIXWY>*T9(HZfAgs8kVs6U&j=wlw1s+Qv8IXgf49DosS+l)G50H<fB!LMqib
zn}%v!KBAU(q#2jck!Bq2gl1elqK0;Bs12*{N;S@QS&FEoJ(BiF+G8nVBL%ci(7tb4
z{{ZEw^jV6ir2~=<NIGCCqLya0G(a<gX2#N<W-QG~nv*nVDWaAZBrT*Fp@oK8=a99u
zBxy;~lBI}RIwa|kq{GmRZzQ5`-kEy;M<gAQbi`6bEgh3|OwzHII)|vC6W^5mmjg5*
z>4c?-T3V5`B5B1^#2^j(KPBkYSba{XEJf7P8A)d(ov{>AOXt#z$8@ft*3DUpsHF>%
zE=amyDWaAxNxGC~-2P<)wQ}~5wRA<&6-ietMby$YN!MEH)(k~N(>6c78<K8Fx?w4z
zmTpP9CF!=23KUU8cgEI#FY*fRNV;PwqL%JSx+m$LrHH;6f8Y-q`pq3kdSEG{mL5rZ
QB<Yc*h(Y@2UsA5#0rkwxng9R*

delta 204
zcmbR4{LPfhCD<k8n-l{BWBW!fU8Z^ullWk#cmZ#&0B27F5f`rbfS?eD0wJb`gaU@d
zMNXVk6S*1+suH=F7?KLAixQI<xR@D|7YIyF1}frYVPNp_^LAlKS)ejGnQ?*O<U}qO
zxNtB-%0gZ^&k?9daB?yi6I{dzBw`E{VulMjGo%#MRwi)?FmV6>&(M*=z)(<~2(+*x
Wg^{5kr6VDcp)_$x!saecUI_p?z%-Ho

diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
index 9b442a64cf711b33d80691fe84f1d3a6256f943b..c15a9fae947bb3929a30c60b7c0f2092705868f8 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPmVc7`ljZ+!)>(n>ph)5jf;dG`XKr*2&756{N8LctRdo>sbNMI=
z@6L4XcOf28wEus-y=14$>FxH(nAY>3>~mtDZr98Gb#i`xeR%p(J-%OGzrUH^v-8jF
zSDB}|bLRZ*`DDU%3)gq1Ed1wLf^Z*08{xr}!?bX&Wqjw-B;Uf|D10Y9jD~1U=Bv1Y
zR1>LUxK6$rXA>h;j7k;JH?bU<ZA&vQp>2FKj<!P+qtZn5O}UH3dQ+*!C8Sb~vuUWt
z<s)ioN1Aa79cjkVPH4u}BWh^3hT5?Du2kb}m!*hW+9PR?q&=1*Hc~+Q1nv8#^$$><
zN}r{OS~?)<fTRPKB5G+?O9M0`Xl5+!X~xo=q&Z1*mLh6tLDE8+5n5=dbq-leha?@6
zbjVUfEgg|`MAA`c#y1ktH}6cn|6`JlNjhdJqLxlbIw9#qOPxd1(5Y|A{>uTHl61;a
zL@g~zT9UM6DPoX@{htwZW~@G^GnOK1X+_eCq!mjMwRA4ccueOSYTcZrh+4WJ>4KyS
zmLh8DlB7#%#_eA=P%CE-SxZ+WU6FLfQba9XlXR`6Zp~0cG;Q<KyCLa@q#KqZYU!4w
zTas=YsX!4mbZ2b+_ad+0j-)%5B5LWLq<fO?S&HbJ@dy5(p+DS#qz9HFYUz=rN0J^{
MiWsDS|0UJ_15D1$N&o-=

delta 204
zcmX}lzY2m-9L4eDpT%DU8m`gO8U(dR>QGoA>8@Ar16+cJlE_h7FRfwG3q;Q+W{czb
z@P+f()(i4NFRDj?Qh#WoURU!tbYjz|z+F#mkK$k-K@8L)5nwOJxHBrmnURWA<Oi05
zG-Q=2vo<nxV6*c*@M<hGrLrU=z2gx4+3(h}jVzgw+KKa*SxZ_+F1WayQZmtN8k8Im
VIcpC~u0ZfIVK}mP^1T`M@CUYNH9`OY

diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
index 1754c6878839fc657230e1e714cd7c5142e0a77e..dd29f5cb620e5164601e303e37524530ddb12684 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPmVc7`lmGt!85igvK*mnoK~N(I;>?Y%p_#KQDLUu|imo8b=_=UE
zM^Siprfa_o@ra`R>+a*2oi3-hj~inew|}xviGBKcy*yk;=l7S#r_a+b@7I^tH}iXP
z{+|6P^E7wPoS(m*Ot@~~`e@3+f1V`>4>2?m9!=R#3+EcfcP@4EEesCAchbXXh}LAj
ziW^8Zkt&9(<g0NuF;c~-R1tj>%aPfpG~*JQ#y8_=Gc++OO+??6yI8C@m1<l<D%Cif
zhH6|sqL#L#8JEzKW*lvWW?Vg@hPErH4XbZUHO{tKim0U>l6FYiVJTuQ1++`hu5ViZ
z0OhH4S&FEoJ(BiF+G8oAmS&YSKr@17#?qc<EX_%plQd^3qLvmUEu<Ntg@#(^khQc=
z(mqN1EJf7P0Z9iW9fW3lBN2V`XsZ1ml5|MYAxjapbVSk-Nk>}h9HNGfeN*;d4$zpS
zW0oRnX-U$Oq$NucgEZ{_grE~+^*Noe6j4j3B%P9U%2Grvok=qu)0u`^H)AQHmd;5!
zC+VD}h+4WJ=|Y-u`xiCT%GpEK(j`fkBwex;QA<}OU1_OXF%%I^TmST~NxCNKnx%+Z
zx*_R?q?=kQP(%&g8e9Fn$Sb%d>6WF4TDl|Yj-)%5BKl_hf!}NBH@7G0o~4LddLZe6
Pqz9HF2I=2_$^GI#o+Hc)

delta 204
zcmX@;xWI(VCD<iIL5hKa@ybRnU8Z^ullWk#cmZ#&0B27F5f`rbfS?eD0wJb`gaU@d
zMNXVk6S*1+suH=F7?KLAixQI<xR@D|7YIyF1}frYVPNp_^LAlKS)ejGnQ?*O<U}qO
zxNtB-%0gZ^&k?9daB?yi6I{dzBw`E{VulMjGo%#MRwi)?FmV6>&(M*=z)(<~2(+*x
Wg^{5kr6VDcp)_$x!saecb8!HyWi$f-

diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
index 9fc731d3d2bcde5e2612a8ccd81e12098134afe9..8a6b56fe7da18bf42c339d13b863aabf81780527 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPl7Eu?lmCBo0R=kA0^&G>phgkY>DcHRnmN0Yj=F)O-9^V;L{`CG
zK8nJ-GhO>#h({FdKX?C5`T2T&`SQ+~R{AS{pV+4#x9jOPzPvs^JbjowzTTccznGuX
z%eVY{Rb+*8=JM&|*@WvBuJ27%`p@$O;S@uP@L;MzRyx-*zH@DoZ((p4zLOqCL$oIM
zRop<TiBvIMCtr=TiIFNsrHbgASdPr5(u_+;jc>-$G&C_PO+??6yI8C@lWJT-Ce=8b
zg=$<rqL#L$8JEzOW*lvYW?Vg@hIVSG4Xf`+HO_Weim0Vsl6FbjWhr7K1++)do^M+J
z0OhIlSc<5neUkP`+Gi=EmgcoIKy!lT#?qeVEG<Y{khEYaqL!8<Eu|TurG{GPkhOF`
z(g8^aEJf7PAxVcM9foFnBN2V`-qia)BI$^vBbFj+>6oNrl8&|1IYbSe_@?Z?9H0qF
zCoDzO(u$-NNh_8j25H#;DM6>k>T^0}DWaCnNIE0wjHQTLI+tcVrgIIoZq8CfEnSdw
zLDB_F5w&zl(xo)x_AeW#m9vMer7M!INV;MvqL!{ny4F&+W+)<>w)yGZkaR=R4NDQV
zbW74LNw<wupoki}Gq(PFkymg>(j7|?wRBI?JxTX0MfA=11AoxaukJw714|LL^hnYp
PNslZ=4AS3k$=~IF&pOOL

delta 204
zcmccWw8fOmCD<ioixdL`<JOH_x=i&RCh@^e@dDml0nVNVA}(C<0YM=Q1wu>>2?Y#^
zi<~&8CUP|tR3&mTF(egK7bPY!a4|C^FA$iV3{=F)!oc9;=k3CfvOr~WGUEcl$%$Mn
zaN%Hvl!d%-o+D6^;N)a3Cb)<bNW>T@#0(d5W=JWhtxVz)VBr4$pP?g#fuW!}5olpY
W3L`^7N=HH>LuulYgw0)?r^Nv%qBS-E

diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
index e654c83ebe40c413b204c711adcefe3f04655e8c..a16b0d9d4becec47fa3cf57ed0077ff6cff88908 100644
GIT binary patch
delta 1914
zcmY+_OK#gR6a`RPmVc7`lmGvWIxCPZByk2oj3S6Lce{pW&a5KCqJwUr=$bmnDwxYh
zQFwQzYrhNeh@$PDe}B)8=i|%OwK0wVf3vTNefV`b-(E(i*QdLO>*@XL<>~pw{F$77
zW^ZMl=FXYZx5uLi*9~0Xn6mJnX9>b>3{8YPQ})xsxrXtbbDew(gM;v$^e`HtHJPvC
z22xF=is35xYMf1sR52=5MBl`6WVR{IxP+$h%{bZ&O^iwt(KqET7VAx=8kdktHO{7?
z8kdi#r7da3CA6d&M_Zv8SC6Qn?Fwqc>f2I{vu&0lYH5e09g=ofidahl?Gm)>o7O)-
zc`99&B5G-mq&<@MSc<5nStSk7jG&pZw5J(MbCTvH%~^`5r3Fa~X+~(Fq1HKME$x%E
zPtrb15w&zc(g8^ap&8#uMBltI)&37jIwa|krHEQOBI$^vBQ13fQA5YRDf=%6XiU;E
zOA)oSBxy;~lBI}28uoue(2247oK9GZsHIbqPDwgtDWaCnq#2LtOhc`ku@q5D=Omqz
zbk0&lEnSdwA<ek`iyCU>>>+FElB7$LE?J7Gr7M!IwA8H_iioDIe|py>U6XXpQbaA?
zkaR=RO)V8DqK0mbt^Qu*72J|^%Th!w-H~)h(j7|?eKY>R?=|#?+mm$9Qba91kn}*(
O14|Ku^xsGF{^b*&XU!!5

delta 204
zcmX}lK?;IE7{&4D=*BMsjgAmOiy){Aq_ZfD5OuGkbATaeQ4+e8wo+{^x<GV5vyIF5
z;}5S%+JJb-qhbbVj}OgRv025T6I&kn?shTe6#GF0HDYC=AYP7n6I80RAcj=s2a$qw
zWQ|p4U1S=-Ztro(W>RNbW7mR=o<qpzuwUygvg?dkFV0_<9qB!}km_<u$-<y*QAt4M
UqC2dl1|_RR;3(e7_iEm!KQx0i9RL6T

diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
index afcdc0d0ba8e41bb70ac20a78dcc8562ca0cb74b..f561750cab8b061c123c041fe2209d74c7a740f1 100644
GIT binary patch
delta 3550
zcmeI#&2G~`6b0aM;{4gppPfH7X(Cv$XVoQXpc1JNqTNv`J3wLy`$0SaEcy!UV1xPy
zyaq1;FJR8x@uc@W0+M$*?VS34wLPQ!-T!`*?5=j#H;;{p_CJ&2G(G=%bGX_bUVnc6
z<?hkxS!ADnJiL5$ZN3$kACgab8mDDxE??|-#($3R`H9Ih_w%HIunnP!aBlK`oRwu{
zTnFo_<XTub@V}EDmWJq>`1`WfHl&Kh5*x-<!`g<CD%MIB(N)7`n$ip-G^H7qHhmLI
zrHSa8;VQ8-Wdw`qW2uI<v9E^l5w)~M(v~#C(w1+A=@GTGP0)4)wSK@hOA)oSL(&dO
zJ1j-i((b(!&@Mr{u4(UY6tb4~NZKQ5kEMuOnvgW9q#l|uG_fpANt%*0WhtVTW+cr>
zn)zn9Pl!jTyZ?QX_DR}jDWaARNID?tfTf7886MtY1-1UUACh#)Qba8sk#t1T5laz|
zQb5N99lNGIzNcfBB5G+)(ww9@OA)oSsH7fR5VSB>-th456)c^QbVAYzOA)nnO46w`
z!|k7Hs4YumEuE2cM$#Ee5w&zq(m6@zz8Rp1uDLa5{@=17>4KySmLiJu_E-19!X*3V
z35|KeV<PG?mo(;*#$584h<;3el@(37GSNf-M9Ut#;xQ5ZnBRLB@4}dC8gtEKBI+?W
zH0FlJ-0+x)e$3lH>-TiTz1`GDTz$kH_qh6qlii{|;$+9Fk2rZ6>LX5lHTWNnxY^ya
H2S4I}`F&X$

delta 354
zcmcbU_Q{*eCD<k8lPUuP<Nb|X!m`|c$}#c5PVv!AuF9J=WGxx%9XR6yf<hPygqRu<
z3K$X>`LRz;<Z39WO5|c<NGhl<N=#zlVrEEQATT)@sECt=fx*Ym+l3(oB)|w4a0Chn
zPEO`xf{QpoMVR3t&I~C9wUtR+0u0>$|1)%?FfbHUCkg@$??_=}C`jo@NMtBYT#_((
UnQAtQGiB5Uqcb<p(mTWg01Zc8kN^Mx

diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
index 64e81f571120e3eb2b8c6c9545293a78c75b7bbd..8d98dd8845a60a08df5aff27097646bea4913b75 100644
GIT binary patch
literal 14615
zcmeHOOKe-m6`jYAL_JaxCDE3Du?QzYKPeJQ&aW*RlzjYJqD+%=oPq{ONlq&}0rC*r
zK%BsUtN@AYRTI`hmrS4l-L<Q3YoMEU=Ur2D)kQbi7Dc>@dhXo0_6$h@HM|NS8z6b-
zojdoQ_sDmKbHrk+xHkV|rM!O>&IZ+1w(v$H$l{-;l%m)4oUX+#s`hrVQ0aKdNX%>B
zO6u2mC?qmJDi+RHyx(ngKkIg{ecbidL$&cm`tHVh_~GsDh9c1QjnMb$MS6Lz(<*e@
zJGJRXP|GDc)mkx?zwaj!oq%6O6P@$5qROm{ch0tg*qygjP`t3%Uyb*+X6F2KyZ+D9
z-z=Q?`DYid<?sFM@4vkBmLCIP3C{^UpAPAv`$5+~+3lx4?Opb6Qo262*q{5frw{X3
znvR5B8u>iMLp0Um?pvAVc&XT`PxfE#T~Xmo)KlI5u}`^y`>*`%->sM4uYWTCb^YjH
zg8FW^KYsVJAKC4O{;k_xr7&=!cf}tMXX6nysk%4|Z!5JPuJgh6&a1^{KG4i38>@|6
zkXuw>-)zk+_$NM|S1LuPoc{fBZ*T9<{8FWFsPszac{+J?;@aDdpta^D@1^`i`&OEQ
z0ORMgcqnGu+pW?WT&lmO{1~nk1wkQKI)ej+)q2xQ-sdz5g2L+gdbUw3zL9Nvg_U4g
zWu9#Wr8ANC(-iIPg<FIOZ+Mp#&C&iI4ezSVb9v;9LeX3yJ#-DWn<-2*^!Y4~J=O`u
zS)(HQ1meL{8@LQNdmE~^k;1vzQ#aSW^_%NAJb(Pr3GP4Zoc)0b!VSI*iAF6bt4ykc
zXD{5MD82K#N9Q*ke68P`jpkZocKPb|Y%-Qat(Dc~lH%7MUYFHuipKp2f{FxD1XVRV
z8AE@#jEpl8WdS(F$8;W`5>h7S*Vu^81lB~9DbR@0nSkm{gp`SHG&ZU;rGu!VOo2u@
z6HuLrkTRu8OlL|5F`X&U7-vfJ2yLEmhi6=83N+4{(mX<&=a|EDOlJyo%;kyD<~i>0
z9Cvt*yF3xvJQEJjgu^r8@<eF!oN#zfI6Nm@o(OH8zQfaZc=|3+gf`El!!zmdOu9S~
z+B{PZ&y>S6<?=*m^PF^ePC7g%U7iSSo>LCbDTn8j%M+o^bK2oK?eLs-c_OrVrX8MX
zhiBU5iO}Xb<M5nuc+R*y5!yUw9iFoe&smozLYwED!*kBzIp^|3X!FcCJTnf@jLQ?D
z&GV4M^N_>ykjoRH&GWFs^RUD7u*(yn%@Z=l_bh!^ns<24yF3xvJdZd$k2pM!xI7Ws
zJdf(kytxw|)tLozvpdR}!K08eiw1kl$voy{9&<Ah+L_0l%;QexaW@m8oq58^JmF-X
za5E9wnNK;HPdS-SxtR#<%#%7(?(rverrhICa;Dt45mKfo$%0dJ!Ku06)<noP6A;k6
zC7_j74W+f1dU%b(MnDmuEC*2pQWOHpIQ=H_6lF<&9*Q#bp@1S3Y7kJyihx>B5>SRd
z6i|fdMg)|xCZd{{RTPsl<&2SlB1A_T3jt-Ui3~@bNdn4H32mMbP@Yz2LO?Aj2`EBQ
zMG{bi!V?0@Se*$0wV))R4AnJBKoJU02q<H9CIr-il7KQ)XOe&-6rK=J#_CK6s0Aef
zWvI?10Yxa+69URuoe2T8pd_FS)tMxq2!$sEl(9M!0%}1?KpCntNk9<_PY5VubtVMV
zf|7tTRA-WaA{3qwP{!&^2&e@m0cEJpBmqSzJRzWr)tL}b3rYgYP@PEvicok$KpCqu
zA)pqN1eBpVlLQo@@PvReR%b#$Ehq^nLv<zzC_>>00cEVtgn(L55>STfOcGFp!V?0@
zSe*$0wV))R4Aq$=pa_L01eCEl69Q^MNkAE@Gf6-Z3Qq_qV|6A3)Pj<LGE`@hfFcy0
z5KzYIObDn2B>`oq&LjavC_EvcjMbSCPzy=|%21t20*X+0LO>a-Ga;ZBlmwKaI+Fwx
zq40!&GFE3oKrJW<C_{B72`ED02?1rS&V+zkP!dpv>P!+)gu)X7ipUaBM7Dq;v;`EQ
zC7@O&1k}nT0ktwoK&?y&sFeu;wK7RStxOV7D-!~0WkNu$OcGEllLXYtgn(L^5Kt?V
z1k}nT0ktwAporw^LO>DWis_R{0*VlqK|;!ua|;1QB<B_aib&2a2`EB2w<Mqlu?KRj
z0|{0AR8N0d-K8(2pO4W~J~LN4hwuOWi4XkkEw$@U?E1;fi?wq>a{{v4%*{;s$zPAD
z3B8qYL*1b<KaR&*_`#Mxt>_gdYUbKIE921lyzIoJrg{G*fzqv+!~Wc_r_@9g3Z-xl
zR=At08!9v1X|3heF165Tp37%uI>lN`-K5w4wjP<L4GlsBO&!m7TFsVsXUp_J<!Rhh
zFAP-o9;14}s$S653+T_TUdW8DUTE*si97GbU>C}8_al!{KCsFMx_mHDKG>&xV9FN<
z$otp<`@he9(JEim<%<L5i~E!>n)0Q=^0CJ#U$V-VbotUi`O-e+OQw8zuzdV6%9pM3
zWnI2JP`<oR`LZcr87x2c809Ng`HC)I87N=br+mefuMU<Ue~j`~t9(_LuMU*2?o+;s
z@-ey{4VF)HdAWIDX@HMAZ%(>nnKAv5#}j?7&2)nwV}Hh-4(o-X>3D49bVHxZS$8@t
zB8H~pv60gaea`0G>9DdGnvTatPB-+q$+**DxiK^ykByve=yPz$oepb|q3L*R<a9&t
z>%;DJSeOh=$73U>8+xD4yVGH{GBh2JxznZV3EuuMC8~|mn!Noy-12DCzr9^;tko4(
z-uJ&vDr{Y+DV}@1v|7wIn#E2w^RiZ+kVd*84XwZ5_0!#c>XTkq^}5)P-BtamPkQU>
zx9chOum8q(A&!tV+FqaWr#`}05Sm=!%NjP+Go4C<uj6DsXw-7K+{-F`_BC#?>R)^z
zD*Nq?W~n9J`nX4++sUADK3jd~TKM+$UuEBY^Xfa--`#xks%m>dV`bTVXeNEX;(e9+
zD&?hafE{k@*t7pC<)_-WzE443WrId()eCB?EiY)+U-z){o}-7dr=menFJgCpmXOh)
zRa(gcUd*p$v29&jttCQ5gZS{BzNn1>G{j9BHj6oGgKd>~W+qrG|02@&dt2(G08}q$
zs$;MX@)PZ+FTN17i4p<Y_a7Wav5=gQ-rxbE5c<>D?;kp{vb@{P)Z;|!@d|l^Q(=aY
z^JmJ3gI2Jb*oQ_USS?+cjqHVLGxRQfQJn2v@<Mef^tz#1|6(Qen_kzuyNRK0xH(u-
z6CNDIMd{Dq9UR4F+5ECU(OdWTQ0B{U)bai^LuZbzd$@U<dR$l6*U{DIuk>FUg6Ve#
zF5jjf4Tnw)4kGXRCfRPK82fHC;fC6zOAc<E?ZwgLhUP*)*EdF==K4f%wzZbp=QNLg
zw+zjXlNVkdac)9CGB`@mD}#eL%_F;OfA}iBr|HwJ$koC7I<ZUdZhQjj`L&s(pHSGi
zpyhC83dZ7ElE|p7%U3eT@!`R3pi{~%Df5Y^4-&nn(r33X^39+OzwI>aN__5pJQWJ7
z^fYW<KCx}N@Fccn>6-q+usgSM)wgUbd`sh9H(Kb+MjP2y_yS^f-DnwX_OaNul5Z;5
zbz`9ZQbW6L43*H{US!(}lj?7t5uGVtYK(1#R&=JZt)vRuR?-36RsuD)6`(rP*j7@7
zZ7ca6%C?n2jcp}gvy5#eRoJ$Y4%oI5sIjf2d1G5i6}GLU1GcRMYHTZM-q==Bg>5V8
zfNd**(yklMtu#-&ZhYqT*<{;FI$+yMpvJb6=8bJ7RoJ$Y4%oI5sIjf2d1G5i6}GK}
zC)-v6HMW&BZ)_{6!nT!kz_yh@jcp~(8{0~%ux%wBux%w!V_Qk{#<r3wY+FeOY+DJ`
z*jCcKv8|*E+g8#6+g1WKwv{w*Y%8h4wv}|iwv|AQZ6(bc+e)fnX^pEZ9k6XBP-9z3
z^TxK4Dr{Rx2W(pj)Yw+iys@pM3forF0ozsrHMW&BZ)_{6!nT!kz_yh@jcp~(8{0~%
zux%wBux%w!V_Qk{#<r3wY+FeOY+DJ`*jCcKv8|*E+g8#6+g1WKwv{w*Y%8h4wv}|i
zwv|AQZ6(bc+e)giZ6zJBZ6#1+TS@cAwvsAOYFkMMY+DIWV_Qk{#<mikY+FeOY+DJ`
z*jCcKv8|*E+g8GpZ7YEq+e&yE+e)fDscj`4ux%wgjcp~(8{0~FvTY?Dux%w!V_Qk{
z#<nV$mHQ!o_V%QT;C7^P_)kj*d|`0b150K-kmdCNo(|Rnj@@{$9@yJESP#&jI~}YC
z_Vy0e1N2TfSP$&&9jpiFo$#Gq4`3H=<a%JytOwG(9>CMVdf;F^fE57kpvZdlU_EfK
z9^j3vgZ03{dVt>v2kU|F^m-tzu$jmE1NB4f#OdFUXw&gb(*KieBq)XbLVzpYgVckR
zm%zA}!q&G^-(a8NLF!>ViJzM&^&kCXAbp(v`bK|?BCv`m=Vw9*{1WC5`hZfucaGe{
z?}xtSBlljr^BjI!WM<<razp56G}v2q{!t9Oawmwv7r~+i%NYGjr9A9Wwmxax@;qVc
zuI2qC+pOC2%#LNpJp5*<y>lkks5Y9TCc#M>;hzrAbuV=<<sHH9%MUK1eCu>)b}Z(h
zcf5YFGn<I{5g$7Zh+d*2#3cRGN0*_!^L+V2!1ns&xl;W+Y@#JX4|JT4r{m<(rfUn@
z^GW9y=qk2%lC4~>lj!7&O|bc4EB7h~xMH4y=igc^D*PG>FP7xRX?oG#nQkqbL|`L4
z@F+Q|2bLZoVm$B&5y!xpOso88WPv>7TJv1Q@A|295My)d)=yrDQmcfdqaOWb75)nB
zT!9_}dMG9o4D@p)dR?Z63O!U4?VT5w3q=s(m1-0|Je?O~m>=;ERlKh1D$lEUm((RZ
zpNi;r#xwP^=O1QG;}0pUtb`vwML$<-?<}n}))r;%7|uD|GyG|ng-!dD74N<1d(lMV
z)V7{^DL7kym=gzjbk2k5gQ!ZJO6#0wn`^<tZjz`&Zoi&7RH5<`r<6zSOt;E;bL}Du
Xr;-K=W*~}zbc%dH{J}yAzsUO^S0<~(

delta 518
zcmbPU^uv?OCD<k8hYAA&<CBeC!m`|6qA~HoPVv!Aj-rz_WS7)CaK;A&g)kHdF*PI<
zFeEPWW1pJH)lg8C$i>8vR8U=%n8d)v%#gf5U~)205hn`+gO8uL3quM>fDta>2ow;U
zoXo`p7jc4$FvCTh8Bz*rE0eec7`XrcXXr>_U?`|g6a*UHk;2GOkkXNm$WWTNBw@0k
cstk%NEmQ}iD;0H7UFo4a2wl0^(DWHI0MXZo^8f$<

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index b2c2c10cbc..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,2 +1 @@
 /* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT",
-- 
2.45.2.505.gda0bf45e8d-goog



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table
  2024-06-07  8:58 ` [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
@ 2024-06-07  9:30   ` Michael S. Tsirkin
  0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2024-06-07  9:30 UTC (permalink / raw)
  To: Ricardo Ribalda
  Cc: Igor Mammedov, Ani Sinha, Marcel Apfelbaum, Paolo Bonzini,
	Richard Henderson, Eduardo Habkost, qemu-devel, Andrea Righi

On Fri, Jun 07, 2024 at 08:58:57AM +0000, Ricardo Ribalda wrote:
> When qemu runs without kvm acceleration the ACPI executions take a great
> amount of time. If they take more than the default time (30sec), the
> ACPI calls fail and the system might not behave correctly.

Wow.

> Now the _PRT table is computed on the fly. We can drastically reduce the
> execution of the _PRT method if we return a pre-computed table.
> 
> Without this patch:
> [   51.343484] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
> [   51.527032] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
> [   51.530049] virtio-pci 0000:00:02.0: can't derive routing for PCI INT A
> [   51.530797] virtio-pci 0000:00:02.0: PCI INT A: no GSI
> [   81.922901] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
> [   82.103534] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
> [   82.106088] virtio-pci 0000:00:04.0: can't derive routing for PCI INT A
> [   82.106761] virtio-pci 0000:00:04.0: PCI INT A: no GSI
> [  112.192568] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
> [  112.486687] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
> [  112.489554] virtio-pci 0000:00:05.0: can't derive routing for PCI INT A
> [  112.490027] virtio-pci 0000:00:05.0: PCI INT A: no GSI
> [  142.559448] ACPI Error: Aborting method \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529)
> [  142.718596] ACPI Error: Method execution failed \_SB.PCI0._PRT due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/uteval-68)
> [  142.722889] virtio-pci 0000:00:06.0: can't derive routing for PCI INT A
> [  142.724578] virtio-pci 0000:00:06.0: PCI INT A: no GSI
> 
> With this patch:
> [   22.938076] ACPI: \_SB_.LNKB: Enabled at IRQ 10
> [   24.214002] ACPI: \_SB_.LNKD: Enabled at IRQ 11
> [   25.465170] ACPI: \_SB_.LNKA: Enabled at IRQ 10
> [   27.944920] ACPI: \_SB_.LNKC: Enabled at IRQ 11
> 
> ACPI disassembly:
>         Scope (PCI0)
>         {
>             Method (_PRT, 0, NotSerialized)  // _PRT: PCI Routing Table
>             {
>                 Return (Package (0x80)
>                 {
>                     Package (0x04)
>                     {
>                         0xFFFF,
>                         Zero,
>                         LNKD,
>                         Zero
>                     },
> 
>                     Package (0x04)
>                     {
>                         0xFFFF,
>                         One,
>                         LNKA,
>                         Zero
>                     },
> 
>                     Package (0x04)
>                     {
>                         0xFFFF,
>                         0x02,
>                         LNKB,
>                         Zero
>                     },
> 
>                     Package (0x04)
>                     {
>                         0xFFFF,
>                         0x03,
>                         LNKC,
>                         Zero
>                     },
> 
>                     Package (0x04)
>                     {
>                         0x0001FFFF,
>                         Zero,
>                         LNKS,
>                         Zero
>                     },
> Context: https://lore.kernel.org/virtualization/20240417145544.38d7b482@imammedo.users.ipa.redhat.com/T/#t
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  hw/i386/acpi-build.c | 118 ++++++++-----------------------------------
>  1 file changed, 21 insertions(+), 97 deletions(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 53f804ac16..4c14d39173 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -725,40 +725,7 @@ static Aml *aml_pci_pdsm(void)
>      return method;
>  }
>  
> -/**
> - * build_prt_entry:
> - * @link_name: link name for PCI route entry
> - *
> - * build AML package containing a PCI route entry for @link_name
> - */
> -static Aml *build_prt_entry(const char *link_name)
> -{
> -    Aml *a_zero = aml_int(0);
> -    Aml *pkg = aml_package(4);
> -    aml_append(pkg, a_zero);
> -    aml_append(pkg, a_zero);
> -    aml_append(pkg, aml_name("%s", link_name));
> -    aml_append(pkg, a_zero);
> -    return pkg;
> -}
> -
> -/*
> - * initialize_route - Initialize the interrupt routing rule
> - * through a specific LINK:
> - *  if (lnk_idx == idx)
> - *      route using link 'link_name'
> - */
> -static Aml *initialize_route(Aml *route, const char *link_name,
> -                             Aml *lnk_idx, int idx)
> -{
> -    Aml *if_ctx = aml_if(aml_equal(lnk_idx, aml_int(idx)));
> -    Aml *pkg = build_prt_entry(link_name);
> -
> -    aml_append(if_ctx, aml_store(pkg, route));
> -
> -    return if_ctx;
> -}
> -


Can't say I like defines like this. Explains almost nothing
and is far divorced from code.
Better to do it near the 1st use:

 int nroutes = 128 /* Explain why it's 128 here */;

 rt_pkg = aml_varpackage(nroutes);



>  /*
>   * build_prt - Define interrupt rounting rules
>   *
> @@ -771,74 +738,31 @@ static Aml *initialize_route(Aml *route, const char *link_name,
>   */
>  static Aml *build_prt(bool is_pci0_prt)
>  {
> -    Aml *method, *while_ctx, *pin, *res;
> +    Aml *rt_pkg, *method;
> +    const char link_name[][2] = {"D", "A", "B", "C"};

Wouldn't it be clearer if we just made it LNKA, LNKB etc?

> +    int i;
>  
>      method = aml_method("_PRT", 0, AML_NOTSERIALIZED);
> -    res = aml_local(0);
> -    pin = aml_local(1);
> -    aml_append(method, aml_store(aml_package(128), res));
> -    aml_append(method, aml_store(aml_int(0), pin));
> +    rt_pkg = aml_varpackage(N_ROUTES);


Again, initialize where defined.

>  
> -    /* while (pin < 128) */
> -    while_ctx = aml_while(aml_lless(pin, aml_int(128)));
> -    {
> -        Aml *slot = aml_local(2);
> -        Aml *lnk_idx = aml_local(3);
> -        Aml *route = aml_local(4);
> -
> -        /* slot = pin >> 2 */
> -        aml_append(while_ctx,
> -                   aml_store(aml_shiftright(pin, aml_int(2), NULL), slot));
> -        /* lnk_idx = (slot + pin) & 3 */
> -        aml_append(while_ctx,
> -            aml_store(aml_and(aml_add(pin, slot, NULL), aml_int(3), NULL),
> -                      lnk_idx));
> -
> -        /* route[2] = "LNK[D|A|B|C]", selection based on pin % 3  */
> -        aml_append(while_ctx, initialize_route(route, "LNKD", lnk_idx, 0));
> -        if (is_pci0_prt) {
> -            Aml *if_device_1, *if_pin_4, *else_pin_4;
> -
> -            /* device 1 is the power-management device, needs SCI */
> -            if_device_1 = aml_if(aml_equal(lnk_idx, aml_int(1)));
> -            {
> -                if_pin_4 = aml_if(aml_equal(pin, aml_int(4)));
> -                {
> -                    aml_append(if_pin_4,
> -                        aml_store(build_prt_entry("LNKS"), route));
> -                }
> -                aml_append(if_device_1, if_pin_4);
> -                else_pin_4 = aml_else();
> -                {
> -                    aml_append(else_pin_4,
> -                        aml_store(build_prt_entry("LNKA"), route));
> -                }
> -                aml_append(if_device_1, else_pin_4);
> -            }
> -            aml_append(while_ctx, if_device_1);
> -        } else {
> -            aml_append(while_ctx, initialize_route(route, "LNKA", lnk_idx, 1));
> +    for (i = 0; i < N_ROUTES; i++) {
> +        Aml *pkg = aml_package(4);
> +        const char *name;
> +
> +        name = link_name[((i >> 2) + i) & 3];

better to combine definition and initialization of name.

And can we get some explanation of what is going on here?


> +
> +        if (is_pci0_prt && i == 4) {
> +            name = "S";
>          }

So this discards the previous calculation.
if {} else {} would be better.


> -        aml_append(while_ctx, initialize_route(route, "LNKB", lnk_idx, 2));
> -        aml_append(while_ctx, initialize_route(route, "LNKC", lnk_idx, 3));
> -
> -        /* route[0] = 0x[slot]FFFF */
> -        aml_append(while_ctx,
> -            aml_store(aml_or(aml_shiftleft(slot, aml_int(16)), aml_int(0xFFFF),
> -                             NULL),
> -                      aml_index(route, aml_int(0))));
> -        /* route[1] = pin & 3 */
> -        aml_append(while_ctx,
> -            aml_store(aml_and(pin, aml_int(3), NULL),
> -                      aml_index(route, aml_int(1))));
> -        /* res[pin] = route */
> -        aml_append(while_ctx, aml_store(route, aml_index(res, pin)));
> -        /* pin++ */
> -        aml_append(while_ctx, aml_increment(pin));
> +
> +        aml_append(pkg, aml_int((i << 14) | 0xFFFF));
> +        aml_append(pkg, aml_int(i & 3));

document and explain above &/|/<< logic too, please.

> +        aml_append(pkg, aml_name("LNK%s", name));
> +        aml_append(pkg, aml_int(0));
> +        aml_append(rt_pkg, pkg);
>      }
> -    aml_append(method, while_ctx);
> -    /* return res*/
> -    aml_append(method, aml_return(res));
> +
> +    aml_append(method, aml_return(rt_pkg));
>  
>      return method;
>  }
> -- 
> 2.45.2.505.gda0bf45e8d-goog



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT
  2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
@ 2024-06-07  9:33   ` Michael S. Tsirkin
  0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2024-06-07  9:33 UTC (permalink / raw)
  To: Ricardo Ribalda
  Cc: Igor Mammedov, Ani Sinha, Marcel Apfelbaum, Paolo Bonzini,
	Richard Henderson, Eduardo Habkost, qemu-devel, Andrea Righi

On Fri, Jun 07, 2024 at 08:58:58AM +0000, Ricardo Ribalda wrote:
> --- /tmp/asl-87N0O2.dsl	2024-06-07 07:20:54.081576394 +0000
> +++ /tmp/asl-4Q0YO2.dsl	2024-06-07 07:20:54.077576397 +0000
> @@ -1,30 +1,30 @@
>  /*
>   * Intel ACPI Component Architecture
>   * AML/ASL+ Disassembler version 20230628 (64-bit version)
>   * Copyright (c) 2000 - 2023 Intel Corporation
>   *
>   * Disassembling to symbolic ASL+ operators
>   *
> - * Disassembly of tests/data/acpi/pc/DSDT, Fri Jun  7 07:20:54 2024
> + * Disassembly of /tmp/aml-NF1YO2, Fri Jun  7 07:20:54 2024
>   *
>   * Original Table Header:
>   *     Signature        "DSDT"
> - *     Length           0x00001AAE (6830)
> + *     Length           0x0000214F (8527)
>   *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
> - *     Checksum         0x0B
> + *     Checksum         0x59
>   *     OEM ID           "BOCHS "
>   *     OEM Table ID     "BXPC    "
>   *     OEM Revision     0x00000001 (1)
>   *     Compiler ID      "BXPC"
>   *     Compiler Version 0x00000001 (1)
>   */
>  DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    ", 0x00000001)
>  {
>      Scope (\)
>      {
>          OperationRegion (DBG, SystemIO, 0x0402, One)
>          Field (DBG, ByteAcc, NoLock, Preserve)
>          {
>              DBGB,   8
>          }
>

trim this part when you post in the future.

 
> @@ -168,102 +168,1058 @@
>                          ""
>                      }
>                  Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>                      ))
>                  Local0 [Zero] = Local2
>                  Return (Local0)
>              }
>          }
>      }
> 
>      Scope (_SB)
>      {
>          Scope (PCI0)
>          {
>              Method (_PRT, 0, NotSerialized)  // _PRT: PCI Routing Table
>              {
> -                Local0 = Package (0x80){}
> -                Local1 = Zero
> -                While ((Local1 < 0x80))
> +                Return (Package (0x80)
>                  {
> -                    Local2 = (Local1 >> 0x02)
> -                    Local3 = ((Local1 + Local2) & 0x03)
> -                    If ((Local3 == Zero))
> -                    {
> -                        Local4 = Package (0x04)
> -                            {
> -                                Zero,
> -                                Zero,
> -                                LNKD,
> -                                Zero
> -                            }
> -                    }
> +                    Package (0x04)
> +                    {
> +                        0xFFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> 
> -                    If ((Local3 == One))
> +                    Package (0x04)
>                      {
> -                        If ((Local1 == 0x04))
> -                        {
> -                            Local4 = Package (0x04)
> -                                {
> -                                    Zero,
> -                                    Zero,
> -                                    LNKS,
> -                                    Zero
> -                                }
> -                        }
> -                        Else
> -                        {
> -                            Local4 = Package (0x04)
> -                                {
> -                                    Zero,
> -                                    Zero,
> -                                    LNKA,
> -                                    Zero
> -                                }
> -                        }
> -                    }
> +                        0xFFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> 
> -                    If ((Local3 == 0x02))
> +                    Package (0x04)
>                      {
> -                        Local4 = Package (0x04)
> -                            {
> -                                Zero,
> -                                Zero,
> -                                LNKB,
> -                                Zero
> -                            }
> -                    }
> +                        0xFFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> 
> -                    If ((Local3 == 0x03))
> +                    Package (0x04)
>                      {
> -                        Local4 = Package (0x04)
> -                            {
> -                                Zero,
> -                                Zero,
> -                                LNKC,
> -                                Zero
> -                            }
> -                    }
> +                        0xFFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> 
> -                    Local4 [Zero] = ((Local2 << 0x10) | 0xFFFF)
> -                    Local4 [One] = (Local1 & 0x03)
> -                    Local0 [Local1] = Local4
> -                    Local1++
> -                }
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        Zero,
> +                        LNKS,
> +                        Zero
> +                    },
> 
> -                Return (Local0)
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    }


Too much detail, include two-three examples, and then
just put in ....



> +                })
>              }
>          }
> 
>          Method (IQST, 1, NotSerialized)
>          {
>              If ((0x80 & Arg0))
>              {
>                  Return (0x09)
>              }
> 
>              Return (0x0B)
>          }
> 
>          Method (IQCR, 1, Serialized)
>          {
>              Name (PRR0, ResourceTemplate ()
> **
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  tests/data/acpi/pc/DSDT                     | Bin 6830 -> 8527 bytes
>  tests/data/acpi/pc/DSDT.acpierst            | Bin 6741 -> 8438 bytes
>  tests/data/acpi/pc/DSDT.acpihmat            | Bin 8155 -> 9852 bytes
>  tests/data/acpi/pc/DSDT.bridge              | Bin 13701 -> 15398 bytes
>  tests/data/acpi/pc/DSDT.cphp                | Bin 7294 -> 8991 bytes
>  tests/data/acpi/pc/DSDT.dimmpxm             | Bin 8484 -> 10181 bytes
>  tests/data/acpi/pc/DSDT.hpbridge            | Bin 6781 -> 8478 bytes
>  tests/data/acpi/pc/DSDT.hpbrroot            | Bin 3337 -> 5034 bytes
>  tests/data/acpi/pc/DSDT.ipmikcs             | Bin 6902 -> 8599 bytes
>  tests/data/acpi/pc/DSDT.memhp               | Bin 8189 -> 9886 bytes
>  tests/data/acpi/pc/DSDT.nohpet              | Bin 6688 -> 8385 bytes
>  tests/data/acpi/pc/DSDT.numamem             | Bin 6836 -> 8533 bytes
>  tests/data/acpi/pc/DSDT.roothp              | Bin 10623 -> 12320 bytes
>  tests/data/acpi/q35/DSDT.cxl                | Bin 9714 -> 13148 bytes
>  tests/data/acpi/q35/DSDT.viot               | Bin 9464 -> 14615 bytes
>  tests/qtest/bios-tables-test-allowed-diff.h |   1 -
>  16 files changed, 1 deletion(-)
> 
> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
> index c93ad6b7f83a168a1833d7dba1112dd2ab8a431f..92225236e717b2e522a2ee00492fb0ded418dc7b 100644
> GIT binary patch
> delta 1914
> zcmY+_OK#gR6a`RPmVc7`lmCBo0R=kA0^&G>phg?inPg;S4auBYNk<(QD7uD@yN<4c
> zy?hjfcW1ixyAY2k+COjp9<$Ts^z`+EF^%V6*~i2_e7|0f*U|ay@$TW%^#1Mo`0dI3
> zn4Dj;_cBj&=gj%b=aUK74P4)vvhbg03BoakCc>R5`)T1^!}!jnPQHb~LHJI37!A>y
> z%vW&(sU}jzaFu*D&L&2x7?mobZ(=zz+mvQpLeuzW9BqasMx}}9n{pS6^`=sdOGu>}

...

-- 
MST



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes
  2024-06-07  8:58 [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
  2024-06-07  8:58 ` [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
  2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
@ 2024-06-07  9:33 ` Michael S. Tsirkin
  2 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2024-06-07  9:33 UTC (permalink / raw)
  To: Ricardo Ribalda
  Cc: Igor Mammedov, Ani Sinha, Marcel Apfelbaum, Paolo Bonzini,
	Richard Henderson, Eduardo Habkost, qemu-devel, Andrea Righi

On Fri, Jun 07, 2024 at 08:58:56AM +0000, Ricardo Ribalda wrote:
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>


Thanks for working on this.
Pls include a cover letter with a patchset in the future.
That should include a changelog, too.

> ---
>  tests/qtest/bios-tables-test-allowed-diff.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523c8b..b2c2c10cbc 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,2 @@
>  /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/pc/DSDT",
> -- 
> 2.45.2.505.gda0bf45e8d-goog



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-06-07  9:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-07  8:58 [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
2024-06-07  8:58 ` [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
2024-06-07  9:30   ` Michael S. Tsirkin
2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
2024-06-07  9:33   ` Michael S. Tsirkin
2024-06-07  9:33 ` [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Michael S. Tsirkin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.