From: Jakub Kicinski <kuba@kernel.org>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Cc: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>,
netdev@vger.kernel.org,
Pawel Chmielewski <pawel.chmielewski@intel.com>,
intel-wired-lan@lists.osuosl.org, Simon Horman <horms@kernel.org>,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v5] ice: Do not get coalesce settings while in reset
Date: Mon, 10 Jun 2024 19:47:56 -0700 [thread overview]
Message-ID: <20240610194756.5be5be90@kernel.org> (raw)
In-Reply-To: <20240607121552.15127-1-dawid.osuchowski@linux.intel.com>
On Fri, 7 Jun 2024 14:15:52 +0200 Dawid Osuchowski wrote:
> We cannot use ice_wait_for_reset() since both the ethtool handler and the
> adapter reset flow call rtnl_lock() during operation. If we wait for
> reset completion inside of an ethtool handling function such as
> ice_get_coalesce(), the wait will always timeout due to reset being
> blocked by rtnl_lock() inside of ice_queue_set_napi() (which is called
> during reset process), and in turn we will always return -EBUSY anyways,
> with the added hang time of the timeout value.
Why does the reset not call netif_device_detach()?
Then core will know not to call the driver.
> Fixes: 67fe64d78c43 ("ice: Implement getting and setting ethtool coalesce")
Isn't ice_queue_set_napi() much more recent than this commit?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Ngai-Mint Kwan <ngai-mint.kwan@intel.com>,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
Pawel Chmielewski <pawel.chmielewski@intel.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH iwl-net v5] ice: Do not get coalesce settings while in reset
Date: Mon, 10 Jun 2024 19:47:56 -0700 [thread overview]
Message-ID: <20240610194756.5be5be90@kernel.org> (raw)
In-Reply-To: <20240607121552.15127-1-dawid.osuchowski@linux.intel.com>
On Fri, 7 Jun 2024 14:15:52 +0200 Dawid Osuchowski wrote:
> We cannot use ice_wait_for_reset() since both the ethtool handler and the
> adapter reset flow call rtnl_lock() during operation. If we wait for
> reset completion inside of an ethtool handling function such as
> ice_get_coalesce(), the wait will always timeout due to reset being
> blocked by rtnl_lock() inside of ice_queue_set_napi() (which is called
> during reset process), and in turn we will always return -EBUSY anyways,
> with the added hang time of the timeout value.
Why does the reset not call netif_device_detach()?
Then core will know not to call the driver.
> Fixes: 67fe64d78c43 ("ice: Implement getting and setting ethtool coalesce")
Isn't ice_queue_set_napi() much more recent than this commit?
next prev parent reply other threads:[~2024-06-11 2:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 12:15 [Intel-wired-lan] [PATCH iwl-net v5] ice: Do not get coalesce settings while in reset Dawid Osuchowski
2024-06-07 12:15 ` Dawid Osuchowski
2024-06-10 9:53 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-06-10 9:53 ` Pucha, HimasekharX Reddy
2024-06-11 2:47 ` Jakub Kicinski [this message]
2024-06-11 2:47 ` Jakub Kicinski
2024-06-14 11:50 ` [Intel-wired-lan] " Dawid Osuchowski
2024-06-14 11:50 ` Dawid Osuchowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610194756.5be5be90@kernel.org \
--to=kuba@kernel.org \
--cc=dawid.osuchowski@linux.intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ngai-mint.kwan@intel.com \
--cc=pawel.chmielewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.