From: Segher Boessenkool <segher@kernel.crashing.org>
To: kvm-riscv@lists.infradead.org
Subject: [kvm-unit-tests PATCH] build: retain intermediate .aux.o targets
Date: Wed, 12 Jun 2024 03:28:47 -0500 [thread overview]
Message-ID: <20240612082847.GG19790@gate.crashing.org> (raw)
In-Reply-To: <20240612044234.212156-1-npiggin@gmail.com>
On Wed, Jun 12, 2024 at 02:42:32PM +1000, Nicholas Piggin wrote:
> arm, powerpc, riscv, build .aux.o targets with implicit pattern rules
> in dependency chains that cause them to be made as intermediate files,
> which get removed when make finishes. This results in unnecessary
> partial rebuilds. If make is run again, this time the .aux.o targets
> are not intermediate, possibly due to being made via different
> dependencies.
>
> Adding .aux.o files to .PRECIOUS prevents them being removed and solves
> the rebuild problem.
>
> s390x does not have the problem because .SECONDARY prevents dependancies
> from being built as intermediate. However the same change is made for
> s390x, for consistency.
This is exactly what .SECONDARY is for, as its documentation says,
even. Wouldn't it be better to just add a .SECONDARY to the other
targets as well?
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
Andrew Jones <andrew.jones@linux.dev>,
Marc Hartmayer <mhartmay@linux.ibm.com>,
kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [kvm-unit-tests PATCH] build: retain intermediate .aux.o targets
Date: Wed, 12 Jun 2024 03:28:47 -0500 [thread overview]
Message-ID: <20240612082847.GG19790@gate.crashing.org> (raw)
In-Reply-To: <20240612044234.212156-1-npiggin@gmail.com>
On Wed, Jun 12, 2024 at 02:42:32PM +1000, Nicholas Piggin wrote:
> arm, powerpc, riscv, build .aux.o targets with implicit pattern rules
> in dependency chains that cause them to be made as intermediate files,
> which get removed when make finishes. This results in unnecessary
> partial rebuilds. If make is run again, this time the .aux.o targets
> are not intermediate, possibly due to being made via different
> dependencies.
>
> Adding .aux.o files to .PRECIOUS prevents them being removed and solves
> the rebuild problem.
>
> s390x does not have the problem because .SECONDARY prevents dependancies
> from being built as intermediate. However the same change is made for
> s390x, for consistency.
This is exactly what .SECONDARY is for, as its documentation says,
even. Wouldn't it be better to just add a .SECONDARY to the other
targets as well?
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-s390@vger.kernel.org, Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, Andrew Jones <andrew.jones@linux.dev>,
Marc Hartmayer <mhartmay@linux.ibm.com>,
kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [kvm-unit-tests PATCH] build: retain intermediate .aux.o targets
Date: Wed, 12 Jun 2024 03:28:47 -0500 [thread overview]
Message-ID: <20240612082847.GG19790@gate.crashing.org> (raw)
In-Reply-To: <20240612044234.212156-1-npiggin@gmail.com>
On Wed, Jun 12, 2024 at 02:42:32PM +1000, Nicholas Piggin wrote:
> arm, powerpc, riscv, build .aux.o targets with implicit pattern rules
> in dependency chains that cause them to be made as intermediate files,
> which get removed when make finishes. This results in unnecessary
> partial rebuilds. If make is run again, this time the .aux.o targets
> are not intermediate, possibly due to being made via different
> dependencies.
>
> Adding .aux.o files to .PRECIOUS prevents them being removed and solves
> the rebuild problem.
>
> s390x does not have the problem because .SECONDARY prevents dependancies
> from being built as intermediate. However the same change is made for
> s390x, for consistency.
This is exactly what .SECONDARY is for, as its documentation says,
even. Wouldn't it be better to just add a .SECONDARY to the other
targets as well?
Segher
next prev parent reply other threads:[~2024-06-12 8:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 4:42 [kvm-unit-tests PATCH] build: retain intermediate .aux.o targets Nicholas Piggin
2024-06-12 4:42 ` Nicholas Piggin
2024-06-12 4:42 ` Nicholas Piggin
2024-06-12 6:48 ` Marc Hartmayer
2024-06-12 6:48 ` Marc Hartmayer
2024-06-12 6:48 ` Marc Hartmayer
2024-06-12 7:16 ` Andrew Jones
2024-06-12 7:16 ` Andrew Jones
2024-06-12 7:16 ` Andrew Jones
2024-06-12 8:28 ` Segher Boessenkool [this message]
2024-06-12 8:28 ` Segher Boessenkool
2024-06-12 8:28 ` Segher Boessenkool
2024-06-14 0:43 ` Nicholas Piggin
2024-06-14 0:43 ` Nicholas Piggin
2024-06-14 0:43 ` Nicholas Piggin
2024-06-14 1:08 ` Segher Boessenkool
2024-06-14 1:08 ` Segher Boessenkool
2024-06-14 1:08 ` Segher Boessenkool
2024-06-14 8:38 ` Nicholas Piggin
2024-06-14 8:38 ` Nicholas Piggin
2024-06-14 8:38 ` Nicholas Piggin
2024-07-26 4:15 ` Nicholas Piggin
2024-07-26 4:15 ` Nicholas Piggin
2024-07-26 4:15 ` Nicholas Piggin
2024-07-26 9:05 ` Thomas Huth
2024-07-26 9:05 ` Thomas Huth
2024-07-26 9:05 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612082847.GG19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.