[PATCH] nvmet-passthru: propagate status from id override functions

[PATCH] nvmet-passthru: propagate status from id override functions

[Daniel Wagner]

The id override functions return a status which is not propagated to the
caller.

Fixes: c1fef73f793b ("nvmet: add passthru code to process commands")
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
While reading up on something else, I discovered this part and it looked a bit
sus. Only compile tested.
---
 drivers/nvme/target/passthru.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/target/passthru.c b/drivers/nvme/target/passthru.c
index bb4a69d538fd..f003782d4ecf 100644
--- a/drivers/nvme/target/passthru.c
+++ b/drivers/nvme/target/passthru.c
@@ -226,13 +226,13 @@ static void nvmet_passthru_execute_cmd_work(struct work_struct *w)
 	    req->cmd->common.opcode == nvme_admin_identify) {
 		switch (req->cmd->identify.cns) {
 		case NVME_ID_CNS_CTRL:
-			nvmet_passthru_override_id_ctrl(req);
+			status = nvmet_passthru_override_id_ctrl(req);
 			break;
 		case NVME_ID_CNS_NS:
-			nvmet_passthru_override_id_ns(req);
+			status = nvmet_passthru_override_id_ns(req);
 			break;
 		case NVME_ID_CNS_NS_DESC_LIST:
-			nvmet_passthru_override_id_descs(req);
+			status = nvmet_passthru_override_id_descs(req);
 			break;
 		}
 	} else if (status < 0)

---
base-commit: 6bfd66808f973cf1bb234e54d0cd51a15bba2996
change-id: 20240612-nvmet-passthru-fix-5754c63f2938

Best regards,
-- 
Daniel Wagner <dwagner@suse.de>

Re: [PATCH] nvmet-passthru: propagate status from id override functions

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] nvmet-passthru: propagate status from id override functions

[Chaitanya Kulkarni]

On 6/12/24 07:02, Daniel Wagner wrote:
> The id override functions return a status which is not propagated to the
> caller.
>
> Fixes: c1fef73f793b ("nvmet: add passthru code to process commands")
> Signed-off-by: Daniel Wagner<dwagner@suse.de>

thanks for the fix, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH] nvmet-passthru: propagate status from id override functions

[Keith Busch]

On Wed, Jun 12, 2024 at 04:02:40PM +0200, Daniel Wagner wrote:
> The id override functions return a status which is not propagated to the
> caller.

Thanks, applied to nvme-6.10.