From: Lee Jones <lee@kernel.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Pavel Machek" <pavel@ucw.cz>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
"Dustin Howett" <dustin@howett.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
linux-leds@vger.kernel.org,
"Rajas Paranjpe" <paranjperajas@gmail.com>
Subject: Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device
Date: Thu, 13 Jun 2024 15:34:51 +0100 [thread overview]
Message-ID: <20240613143451.GF2561462@google.com> (raw)
In-Reply-To: <Zl0jIZbIKV6mG12I@google.com>
On Mon, 03 Jun 2024, Tzung-Bi Shih wrote:
> On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Weißschuh wrote:
> > The ChromeOS EC used in Framework laptops supports the standard CrOS EC
> > keyboard backlight protocol.
> > However the firmware on these laptops doesn't implement the ACPI ID
> > GOOG0002 that is recognized by cros_kbd_led_backlight and they also
> > don't use device tree.
> >
> > Prepare the existing cros_kbd_led_backlight driver to be probed through
> > the CrOS EC mfd device which works without ACPI or OF support.
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>
> The patch overall looks good to me but it depends on previous patch in the
> series (for LED_REJECT_NAME_CONFLICT). Let's wait for review.
I plan to take this via MFD.
Is someone going to Ack this patch?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-13 14:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 18:17 [PATCH v3 0/4] cros_kbd_led_backlight: allow binding through cros_ec mfd device Thomas Weißschuh
2024-05-26 18:17 ` [PATCH v3 1/4] leds: class: warn about name collisions earlier Thomas Weißschuh
2024-05-26 18:17 ` [PATCH v3 2/4] leds: add flag to avoid automatic renaming of led devices Thomas Weißschuh
2024-05-26 18:17 ` [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device Thomas Weißschuh
2024-05-28 5:37 ` Tzung-Bi Shih
2024-05-28 5:41 ` Thomas Weißschuh
2024-05-28 6:53 ` Tzung-Bi Shih
2024-06-03 1:57 ` Tzung-Bi Shih
2024-06-13 14:34 ` Lee Jones [this message]
2024-06-14 2:39 ` Tzung-Bi Shih
2024-05-26 18:17 ` [PATCH v3 4/4] mfd: cros_ec: Register keyboard backlight subdevice Thomas Weißschuh
2024-05-31 15:35 ` [PATCH v3 0/4] cros_kbd_led_backlight: allow binding through cros_ec mfd device Lee Jones
2024-05-31 15:49 ` Thomas Weißschuh
2024-05-31 15:53 ` Lee Jones
2024-05-31 15:59 ` Thomas Weißschuh
2024-06-03 1:54 ` Tzung-Bi Shih
2024-07-09 9:25 ` [GIT PULL] Immutable branch between MFD, LEDs and Platform due for the v6.11 merge window[GIT PULL] Immutable branch between MFD, LEDs and Platform due for the v6.11 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613143451.GF2561462@google.com \
--to=lee@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
--cc=paranjperajas@gmail.com \
--cc=pavel@ucw.cz \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.