From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>, Pavel Machek <pavel@ucw.cz>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
Dustin Howett <dustin@howett.net>,
Mario Limonciello <mario.limonciello@amd.com>,
linux-leds@vger.kernel.org,
Rajas Paranjpe <paranjperajas@gmail.com>
Subject: Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device
Date: Tue, 28 May 2024 06:53:53 +0000 [thread overview]
Message-ID: <ZlV_gV5HOyz6VipT@google.com> (raw)
In-Reply-To: <4b5d7db0-4454-4c69-b2c4-9ad652eade76@t-8ch.de>
On Tue, May 28, 2024 at 07:41:09AM +0200, Thomas Weißschuh wrote:
> On 2024-05-28 05:37:32+0000, Tzung-Bi Shih wrote:
> > On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Weißschuh wrote:
> > > +#if IS_ENABLED(CONFIG_MFD_CROS_EC_DEV)
> > [...]
> > > +static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm_mfd = {
> > > + .init = keyboard_led_init_ec_pwm_mfd,
> > > + .brightness_set_blocking = keyboard_led_set_brightness_ec_pwm,
> > > + .brightness_get = keyboard_led_get_brightness_ec_pwm,
> >
> > They are only available if IS_ENABLED(CONFIG_CROS_EC).
>
> config MFD_CROS_EC_DEV
> depends on CROS_EC
>
> Do you prefer this to be spelled out explicitly somewhere?
I see. I missed the part. The dependency is not obvious from only reading
the C file though.
next prev parent reply other threads:[~2024-05-28 6:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 18:17 [PATCH v3 0/4] cros_kbd_led_backlight: allow binding through cros_ec mfd device Thomas Weißschuh
2024-05-26 18:17 ` [PATCH v3 1/4] leds: class: warn about name collisions earlier Thomas Weißschuh
2024-05-26 18:17 ` [PATCH v3 2/4] leds: add flag to avoid automatic renaming of led devices Thomas Weißschuh
2024-05-26 18:17 ` [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device Thomas Weißschuh
2024-05-28 5:37 ` Tzung-Bi Shih
2024-05-28 5:41 ` Thomas Weißschuh
2024-05-28 6:53 ` Tzung-Bi Shih [this message]
2024-06-03 1:57 ` Tzung-Bi Shih
2024-06-13 14:34 ` Lee Jones
2024-06-14 2:39 ` Tzung-Bi Shih
2024-05-26 18:17 ` [PATCH v3 4/4] mfd: cros_ec: Register keyboard backlight subdevice Thomas Weißschuh
2024-05-31 15:35 ` [PATCH v3 0/4] cros_kbd_led_backlight: allow binding through cros_ec mfd device Lee Jones
2024-05-31 15:49 ` Thomas Weißschuh
2024-05-31 15:53 ` Lee Jones
2024-05-31 15:59 ` Thomas Weißschuh
2024-06-03 1:54 ` Tzung-Bi Shih
2024-07-09 9:25 ` [GIT PULL] Immutable branch between MFD, LEDs and Platform due for the v6.11 merge window[GIT PULL] Immutable branch between MFD, LEDs and Platform due for the v6.11 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlV_gV5HOyz6VipT@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
--cc=paranjperajas@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.