From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: linux-doc@vger.kernel.org, netdev@vger.kernel.org,
corbet@lwn.net, Marcin Szycik <marcin.szycik@linux.intel.com>,
intel-wired-lan@lists.osuosl.org,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 2/5] ice: implement ethtool standard stats
Date: Fri, 14 Jun 2024 11:40:37 +0100 [thread overview]
Message-ID: <20240614104037.GE8447@kernel.org> (raw)
In-Reply-To: <20240606224701.359706-3-jesse.brandeburg@intel.com>
On Thu, Jun 06, 2024 at 03:46:56PM -0700, Jesse Brandeburg wrote:
> Add support for MAC/pause/RMON stats. This enables reporting hardware
> statistics in a common way via:
>
> ethtool -S eth0 --all-groups
> and
> ethtool --include-statistics --show-pause eth0
>
> While doing so, add support for one new stat, receive length error
> (RLEC), which is extremely unlikely to happen since most L2 frames have
> a type/length field specifying a "type", and raw ethernet frames aren't
> used much any longer.
>
> NOTE: I didn't implement Ctrl aka control frame stats because the
> hardware doesn't seem to implement support.
>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
corbet@lwn.net, linux-doc@vger.kernel.org,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH iwl-next v2 2/5] ice: implement ethtool standard stats
Date: Fri, 14 Jun 2024 11:40:37 +0100 [thread overview]
Message-ID: <20240614104037.GE8447@kernel.org> (raw)
In-Reply-To: <20240606224701.359706-3-jesse.brandeburg@intel.com>
On Thu, Jun 06, 2024 at 03:46:56PM -0700, Jesse Brandeburg wrote:
> Add support for MAC/pause/RMON stats. This enables reporting hardware
> statistics in a common way via:
>
> ethtool -S eth0 --all-groups
> and
> ethtool --include-statistics --show-pause eth0
>
> While doing so, add support for one new stat, receive length error
> (RLEC), which is extremely unlikely to happen since most L2 frames have
> a type/length field specifying a "type", and raw ethernet frames aren't
> used much any longer.
>
> NOTE: I didn't implement Ctrl aka control frame stats because the
> hardware doesn't seem to implement support.
>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-06-14 10:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 22:46 [Intel-wired-lan] [PATCH iwl-next v2 0/5] ice: add standard stats Jesse Brandeburg
2024-06-06 22:46 ` Jesse Brandeburg
2024-06-06 22:46 ` [Intel-wired-lan] [PATCH iwl-next v2 1/5] net: docs: add missing features that can have stats Jesse Brandeburg
2024-06-06 22:46 ` Jesse Brandeburg
2024-06-14 10:40 ` [Intel-wired-lan] " Simon Horman
2024-06-14 10:40 ` Simon Horman
2024-06-06 22:46 ` [Intel-wired-lan] [PATCH iwl-next v2 2/5] ice: implement ethtool standard stats Jesse Brandeburg
2024-06-06 22:46 ` Jesse Brandeburg
2024-06-14 10:40 ` Simon Horman [this message]
2024-06-14 10:40 ` Simon Horman
2024-06-06 22:46 ` [Intel-wired-lan] [PATCH iwl-next v2 3/5] ice: add tracking of good transmit timestamps Jesse Brandeburg
2024-06-06 22:46 ` Jesse Brandeburg
2024-06-14 10:35 ` [Intel-wired-lan] " Simon Horman
2024-06-14 10:35 ` Simon Horman
2024-06-06 22:46 ` [Intel-wired-lan] [PATCH iwl-next v2 4/5] ice: implement transmit hardware timestamp statistics Jesse Brandeburg
2024-06-06 22:46 ` Jesse Brandeburg
2024-06-14 10:40 ` [Intel-wired-lan] " Simon Horman
2024-06-14 10:40 ` Simon Horman
2024-06-06 22:46 ` [Intel-wired-lan] [PATCH iwl-next v2 5/5] ice: refactor to use helpers Jesse Brandeburg
2024-06-06 22:46 ` Jesse Brandeburg
2024-06-14 10:37 ` [Intel-wired-lan] " Simon Horman
2024-06-14 10:37 ` Simon Horman
2024-07-23 3:03 ` [Intel-wired-lan] [PATCH iwl-next v2 0/5] ice: add standard stats Pucha, HimasekharX Reddy
2024-07-23 3:03 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614104037.GE8447@kernel.org \
--to=horms@kernel.org \
--cc=corbet@lwn.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.