Re: [OE-core] [PATCH] classes/kernel: No symlink in postinst without KERNEL_IMAGETYPE_SYMLINK

Re: [OE-core] [PATCH] classes/kernel: No symlink in postinst without KERNEL_IMAGETYPE_SYMLINK

[Jörg Sommer]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Jörg Sommer via lists.openembedded.org schrieb am So 09. Jun, 16:59 (GMT):
> diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass
> index d6eedf942c..89badd90f1 100644
> --- a/meta/classes-recipe/kernel.bbclass
> +++ b/meta/classes-recipe/kernel.bbclass
> @@ -115,7 +115,9 @@ python __anonymous () {
>  
>          d.setVar('PKG:%s-image-%s' % (kname,typelower), '%s-image-%s-${KERNEL_VERSION_PKG_NAME}' % (kname, typelower))
>          d.setVar('ALLOW_EMPTY:%s-image-%s' % (kname, typelower), '1')
> -        d.prependVar('pkg_postinst:%s-image-%s' % (kname,typelower), """set +e
> +
> +        if d.getVar('KERNEL_IMAGETYPE_SYMLINK') == '1':
> +            d.prependVar('pkg_postinst:%s-image-%s' % (kname,typelower), """set +e
>  if [ -n "$D" ]; then
>      ln -sf %s-${KERNEL_VERSION} $D/${KERNEL_IMAGEDEST}/%s > /dev/null 2>&1
>  else
> @@ -127,7 +129,7 @@ else
>  fi
>  set -e
>  """ % (type, type, type, type, type, type, type))
> -        d.setVar('pkg_postrm:%s-image-%s' % (kname,typelower), """set +e
> +            d.setVar('pkg_postrm:%s-image-%s' % (kname,typelower), """set +e

While backporting this patch to kirkstone I realised this uses `setVar`
instead of `prependVar` (as above). Is this right?


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5068 bytes --]

Re: [OE-core] [PATCH] classes/kernel: No symlink in postinst without KERNEL_IMAGETYPE_SYMLINK

[Jörg Sommer]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Jörg Sommer via lists.openembedded.org schrieb am So 09. Jun, 16:59 (GMT):
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> 
> The commit “Use a copy of image for kernel*.rpm if fs doesn't support
> symlinks” [1] added postinst and postrm scripts to the kernel package which
> create a symlink after package installation. This should not happen if
> `KERNEL_IMAGETYPE_SYMLINK` is not `1`.
> 
> Background: The u-boot implementation of jffs2 does not support symlinks.
> Using a hardlink or removing `${KERNEL_VERSION}` from the file name fails,
> because the current postinst script replaces the file with the symlink.

Gently ping.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5068 bytes --]

Re: [OE-core] [PATCH] classes/kernel: No symlink in postinst without KERNEL_IMAGETYPE_SYMLINK

[Alexandre Belloni]

On 17/06/2024 08:48:16+0200, Jörg Sommer via lists.openembedded.org wrote:
> Jörg Sommer via lists.openembedded.org schrieb am So 09. Jun, 16:59 (GMT):
> > From: Jörg Sommer <joerg.sommer@navimatix.de>
> > 
> > The commit “Use a copy of image for kernel*.rpm if fs doesn't support
> > symlinks” [1] added postinst and postrm scripts to the kernel package which
> > create a symlink after package installation. This should not happen if
> > `KERNEL_IMAGETYPE_SYMLINK` is not `1`.
> > 
> > Background: The u-boot implementation of jffs2 does not support symlinks.
> > Using a hardlink or removing `${KERNEL_VERSION}` from the file name fails,
> > because the current postinst script replaces the file with the symlink.
> 
> Gently ping.

Testing is ongoing

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#200795): https://lists.openembedded.org/g/openembedded-core/message/200795
> Mute This Topic: https://lists.openembedded.org/mt/106576203/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com