From: Jakub Kicinski <kuba@kernel.org>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib
Date: Tue, 18 Jun 2024 08:21:11 -0700 [thread overview]
Message-ID: <20240618082111.27d386b6@kernel.org> (raw)
In-Reply-To: <20240613104023.13044-3-SkyLake.Huang@mediatek.com>
On Thu, 13 Jun 2024 18:40:20 +0800 Sky Huang wrote:
> This patch moves mtk-ge-soc.c's LED code into mtk phy lib. We
> can use those helper functions in mtk-ge.c as well. That is to
> say, we have almost the same HW LED controller design in
> mt7530/mt7531/mt7981/mt7988's Giga ethernet phy.
>
> Also integrate read/write pages into one helper function. They
> are basically the same.
Could you please split this into multiple patches? maybe:
- change the line wrapping
- integrate read/write pages into one helper
- create mtk-phy-lib.c and mtk.h (pure code move)
- add support for LEDs to the other SoC
next prev parent reply other threads:[~2024-06-18 15:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 10:40 [PATCH net-next v7 0/5] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support Sky Huang
2024-06-13 10:40 ` [PATCH net-next v7 1/5] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-06-19 8:31 ` Russell King (Oracle)
2024-06-19 9:14 ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib Sky Huang
2024-06-17 11:51 ` Simon Horman
2024-06-19 8:13 ` SkyLake Huang (黃啟澤)
2024-06-18 15:21 ` Jakub Kicinski [this message]
2024-06-19 8:17 ` SkyLake Huang (黃啟澤)
2024-06-19 10:37 ` SkyLake Huang (黃啟澤)
2024-06-19 8:58 ` Russell King (Oracle)
2024-06-19 11:21 ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 3/5] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2024-06-19 9:01 ` Russell King (Oracle)
2024-06-19 11:33 ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 4/5] net: phy: mediatek: Extend 1G TX/RX link pulse time Sky Huang
2024-06-13 10:40 ` [PATCH net-next v7 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2024-06-19 9:09 ` Russell King (Oracle)
2024-06-19 11:44 ` SkyLake Huang (黃啟澤)
2024-06-19 20:09 ` Russell King (Oracle)
2024-06-20 4:32 ` SkyLake Huang (黃啟澤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618082111.27d386b6@kernel.org \
--to=kuba@kernel.org \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.