All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Daniel Golle <daniel@makrotopia.org>,
	Qingfang Deng <dqfext@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH net-next v7 1/5] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers
Date: Wed, 19 Jun 2024 09:31:47 +0100	[thread overview]
Message-ID: <ZnKXc/UglBxayJtv@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240613104023.13044-2-SkyLake.Huang@mediatek.com>

On Thu, Jun 13, 2024 at 06:40:19PM +0800, Sky Huang wrote:
> diff --git a/drivers/net/phy/mediatek-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c
> similarity index 99%
> rename from drivers/net/phy/mediatek-ge-soc.c
> rename to drivers/net/phy/mediatek/mtk-ge-soc.c
> index f4f9412..47af872 100644
> --- a/drivers/net/phy/mediatek-ge-soc.c
> +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
> @@ -1415,7 +1415,7 @@ static int mt7988_phy_probe_shared(struct phy_device *phydev)
>  	 * LED_C and LED_D respectively. At the same time those pins are used to
>  	 * bootstrap configuration of the reference clock source (LED_A),
>  	 * DRAM DDRx16b x2/x1 (LED_B) and boot device (LED_C, LED_D).
> -	 * In practise this is done using a LED and a resistor pulling the pin
> +	 * In practice this is done using a LED and a resistor pulling the pin

If you are moving files around, there should be no extraneous changes
in the commit that is doing the move. This is a spelling fix, and that
should be a separate patch (and probably should be done as the first
patch.)

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!


  reply	other threads:[~2024-06-19  8:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 10:40 [PATCH net-next v7 0/5] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support Sky Huang
2024-06-13 10:40 ` [PATCH net-next v7 1/5] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-06-19  8:31   ` Russell King (Oracle) [this message]
2024-06-19  9:14     ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib Sky Huang
2024-06-17 11:51   ` Simon Horman
2024-06-19  8:13     ` SkyLake Huang (黃啟澤)
2024-06-18 15:21   ` Jakub Kicinski
2024-06-19  8:17     ` SkyLake Huang (黃啟澤)
2024-06-19 10:37       ` SkyLake Huang (黃啟澤)
2024-06-19  8:58   ` Russell King (Oracle)
2024-06-19 11:21     ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 3/5] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2024-06-19  9:01   ` Russell King (Oracle)
2024-06-19 11:33     ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 4/5] net: phy: mediatek: Extend 1G TX/RX link pulse time Sky Huang
2024-06-13 10:40 ` [PATCH net-next v7 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2024-06-19  9:09   ` Russell King (Oracle)
2024-06-19 11:44     ` SkyLake Huang (黃啟澤)
2024-06-19 20:09       ` Russell King (Oracle)
2024-06-20  4:32         ` SkyLake Huang (黃啟澤)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnKXc/UglBxayJtv@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=SkyLake.Huang@mediatek.com \
    --cc=Steven.Liu@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.