From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-ide@vger.kernel.org
Subject: [PATCH 2/5] ata: libata-scsi: Remove superfluous assignment in ata_sas_port_alloc()
Date: Tue, 18 Jun 2024 17:35:40 +0200 [thread overview]
Message-ID: <20240618153537.2687621-9-cassel@kernel.org> (raw)
In-Reply-To: <20240618153537.2687621-7-cassel@kernel.org>
ata_sas_port_alloc() calls ata_port_alloc() which already assigns ap->lock
so there is no need to ata_sas_port_alloc() to assign it again.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/ata/libata-sata.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index 9e047bf912b1..c564eac9d430 100644
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -1228,7 +1228,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host,
return NULL;
ap->port_no = 0;
- ap->lock = &host->lock;
ap->pio_mask = port_info->pio_mask;
ap->mwdma_mask = port_info->mwdma_mask;
ap->udma_mask = port_info->udma_mask;
--
2.45.2
next prev parent reply other threads:[~2024-06-18 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 15:35 [PATCH 0/5] Assign the unique id used for printing earlier Niklas Cassel
2024-06-18 15:35 ` [PATCH 1/5] ata: libata-core: Remove support for decreasing the number of ports Niklas Cassel
2024-06-18 16:40 ` Niklas Cassel
2024-06-18 15:35 ` Niklas Cassel [this message]
2024-06-19 3:47 ` [PATCH 2/5] ata: libata-scsi: Remove superfluous assignment in ata_sas_port_alloc() Damien Le Moal
2024-06-18 15:35 ` [PATCH 3/5] ata: libata: Assign print_id at port allocation time Niklas Cassel
2024-06-19 3:51 ` Damien Le Moal
2024-06-19 4:56 ` Damien Le Moal
2024-06-18 15:35 ` [PATCH 4/5] ata: libata-scsi: Assign local_port_no at host " Niklas Cassel
2024-06-19 4:04 ` Damien Le Moal
2024-06-20 14:52 ` Niklas Cassel
2024-06-18 15:35 ` [PATCH 5/5] ata: ahci: Add debug print for external port Niklas Cassel
2024-06-19 3:48 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618153537.2687621-9-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.