From: Petr Vorel <pvorel@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Li Wang <liwang@redhat.com>, Zirong Lang <zlang@redhat.com>,
Boyang Xue <bxue@redhat.com>,
ltp@lists.linux.it, linux-xfs@vger.kernel.org
Subject: Re: [LTP] [PATCH] configure.ac: Add _GNU_SOURCE for struct fs_quota_statv check
Date: Wed, 19 Jun 2024 17:59:02 +0200 [thread overview]
Message-ID: <20240619155902.GA477172@pevik> (raw)
In-Reply-To: <7aeebecc-d5ef-4eea-a4e5-ddbfa411ee1e@redhat.com>
> On 6/19/24 7:08 AM, Li Wang wrote:
> > cc Eric Sandeen <sandeen@redhat.com <mailto:sandeen@redhat.com>> who is the author of:
> If adding _GNU_SOURCE to the LTP configure.ac fixes the problem,
> I have no concerns about that.
> However, I also sent a patch to fix xfsprogs - having this wrapper in the
> header is really unnecessary, and will likely cause problems for others
> as well, so I just proposed removing it.
Interesting. OK, let's merge workaround.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> https://lore.kernel.org/linux-xfs/be7f0845-5d5f-4af5-9ca9-3e4370b47d97@sandeen.net/
Thanks for info! Your patch IMHO makes sense.
Kind regards,
Petr
> (This problem only recently showed up due to other changes, see the explanation
> in the link above)
> Thanks,
> -Eric
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] configure.ac: Add _GNU_SOURCE for struct fs_quota_statv check
Date: Wed, 19 Jun 2024 17:59:02 +0200 [thread overview]
Message-ID: <20240619155902.GA477172@pevik> (raw)
In-Reply-To: <7aeebecc-d5ef-4eea-a4e5-ddbfa411ee1e@redhat.com>
> On 6/19/24 7:08 AM, Li Wang wrote:
> > cc Eric Sandeen <sandeen@redhat.com <mailto:sandeen@redhat.com>> who is the author of:
> If adding _GNU_SOURCE to the LTP configure.ac fixes the problem,
> I have no concerns about that.
> However, I also sent a patch to fix xfsprogs - having this wrapper in the
> header is really unnecessary, and will likely cause problems for others
> as well, so I just proposed removing it.
Interesting. OK, let's merge workaround.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> https://lore.kernel.org/linux-xfs/be7f0845-5d5f-4af5-9ca9-3e4370b47d97@sandeen.net/
Thanks for info! Your patch IMHO makes sense.
Kind regards,
Petr
> (This problem only recently showed up due to other changes, see the explanation
> in the link above)
> Thanks,
> -Eric
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-06-19 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 5:34 [LTP] [PATCH] configure.ac: Add _GNU_SOURCE for struct fs_quota_statv check Li Wang
2024-06-17 5:40 ` Li Wang
2024-06-19 9:27 ` Petr Vorel
2024-06-19 12:05 ` Li Wang
2024-06-19 12:08 ` Li Wang
2024-06-19 15:50 ` Eric Sandeen
2024-06-19 15:50 ` Eric Sandeen
2024-06-19 15:59 ` Petr Vorel [this message]
2024-06-19 15:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619155902.GA477172@pevik \
--to=pvorel@suse.cz \
--cc=bxue@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=sandeen@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.