From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<brett.creeley@amd.com>, <drivers@pensando.io>
Subject: Re: [PATCH net] ionic: use dev_consume_skb_any outside of napi
Date: Wed, 19 Jun 2024 16:44:34 -0700 [thread overview]
Message-ID: <20240619164434.46acb9fb@kernel.org> (raw)
In-Reply-To: <20240619212022.30700-1-shannon.nelson@amd.com>
On Wed, 19 Jun 2024 14:20:22 -0700 Shannon Nelson wrote:
> I found that ionic_tx_clean() calls napi_consume_skb() which calls
> napi_skb_cache_put(), but before that last call is the note
> /* Zero budget indicate non-NAPI context called us, like netpoll */
> and
> DEBUG_NET_WARN_ON_ONCE(!in_softirq());
>
> Those are pretty big hints that we're doing it wrong. So, let's pass a 0
> when we know we're not in a napi context.
Just pass the NAPI budget in, and if not in NAPI pass 0.
A bit more plumbing thru, but a lot less thinking required during
review..
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-19 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 21:20 [PATCH net] ionic: use dev_consume_skb_any outside of napi Shannon Nelson
2024-06-19 23:44 ` Jakub Kicinski [this message]
2024-06-20 0:11 ` Nelson, Shannon
2024-06-20 0:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619164434.46acb9fb@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.