From: Jakub Kicinski <kuba@kernel.org>
To: "Nelson, Shannon" <shannon.nelson@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, brett.creeley@amd.com, drivers@pensando.io
Subject: Re: [PATCH net] ionic: use dev_consume_skb_any outside of napi
Date: Wed, 19 Jun 2024 17:18:00 -0700 [thread overview]
Message-ID: <20240619171800.57a60bfc@kernel.org> (raw)
In-Reply-To: <6fb11f9c-1cd3-4a07-a687-96f0c5f146e5@amd.com>
On Wed, 19 Jun 2024 17:11:08 -0700 Nelson, Shannon wrote:
> > Just pass the NAPI budget in, and if not in NAPI pass 0.
> > A bit more plumbing thru, but a lot less thinking required during
> > review..
> > --
> > pw-bot: cr
>
> I had a plumb-it-through solution at one point, but this is so much
> cleaner with a simple one line fix, so much less to go wrong...
So much less to go wrong you say? I'm 75% sure the fix is buggy,
it won't work if hard irq comes during soft irq ;)
prev parent reply other threads:[~2024-06-20 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 21:20 [PATCH net] ionic: use dev_consume_skb_any outside of napi Shannon Nelson
2024-06-19 23:44 ` Jakub Kicinski
2024-06-20 0:11 ` Nelson, Shannon
2024-06-20 0:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619171800.57a60bfc@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.