* [PATCH v4 0/2] Support Starry er88577 MIPI-DSI panel
@ 2024-06-20 11:52 Zhaoxiong Lv
2024-06-20 11:52 ` [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings Zhaoxiong Lv
2024-06-20 11:52 ` [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver Zhaoxiong Lv
0 siblings, 2 replies; 8+ messages in thread
From: Zhaoxiong Lv @ 2024-06-20 11:52 UTC (permalink / raw)
To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos,
benjamin.tissoires, dianders, hsinyi
Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv
The Starry is a 10.1" WXGA TFT LCD panel with er88577 controller
Because Starry-er88577 and kingdisplay-kd101ne3 are not the same IC,
separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver.
Changes between V4 and V3:
- PATCH 1/2: Move positions to keep the list sorted.
- PATCH 2/2: Adjust the ".clock" assignment format.
- Link to v3: https://lore.kernel.org/all/20240614145609.25432-1-lvzhaoxiong@huaqin.corp-partner.google.com/
Changes between V3 and V2:
- PATCH 1/2: This add the bindings to panel-simple-dsi.
- PATCH 2/2: Add a separate driver for Starry-er88577, and Use the new mipi_dsi_dcs_write_seq_multi() function.
- Link to v2: https://lore.kernel.org/all/20240601084528.22502-1-lvzhaoxiong@huaqin.corp-partner.google.com/
Changes between V2 and V1:
- PATCH 1/4: Delete some unnecessary information.
- PATCH 2/4: Use the new mipi_dsi_dcs_write_seq_multi() function, deleted some unnecessary functions.
- PATCH 3/4: Add compatible for Starry-er88577.
- PATCH 4/4: Add starry panel configuration in panel-kingdisplay-kd101ne3 driver.
- Link to v1: https://lore.kernel.org/all/20240418081548.12160-1-lvzhaoxiong@huaqin.corp-partner.google.com/
Zhaoxiong Lv (2):
dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel
bindings
drm/panel: starry-er88577: add new panel driver
.../display/panel/panel-simple-dsi.yaml | 2 +
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-starry-er88577.c | 343 ++++++++++++++++++
4 files changed, 355 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings 2024-06-20 11:52 [PATCH v4 0/2] Support Starry er88577 MIPI-DSI panel Zhaoxiong Lv @ 2024-06-20 11:52 ` Zhaoxiong Lv 2024-06-20 16:04 ` Conor Dooley 2024-06-20 11:52 ` [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver Zhaoxiong Lv 1 sibling, 1 reply; 8+ messages in thread From: Zhaoxiong Lv @ 2024-06-20 11:52 UTC (permalink / raw) To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv This add the bindings for the 1280x800 TFT LCD Starry-er88577 DSI panel to panel-simple-dsi. Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> --- Changes between V4 and V3: - 1. Move positions to keep the list sorted. v3: https://lore.kernel.org/all/20240614145609.25432-2-lvzhaoxiong@huaqin.corp-partner.google.com/ Changes between V3 and V2: - 1. Separate the Starry bindings from kingdisplay, and add it to panel-simple-dsi.yaml v2: https://lore.kernel.org/all/20240601084528.22502-4-lvzhaoxiong@huaqin.corp-partner.google.com/ Changes between V2 and V1: - 1. Add compatible for Starry er88577 in Kingdisplay kd101ne3 dt-bindings. --- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml index db5acd2807ed..f67059d44bde 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml @@ -58,6 +58,8 @@ properties: - samsung,s6e3fc2x01 # Samsung sofef00 1080x2280 AMOLED panel - samsung,sofef00 + # The Starry-er88577 is a 10.1" WXGA TFT-LCD panel + - starry,er88577 # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel - tdo,tl070wsh30 -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings 2024-06-20 11:52 ` [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings Zhaoxiong Lv @ 2024-06-20 16:04 ` Conor Dooley 0 siblings, 0 replies; 8+ messages in thread From: Conor Dooley @ 2024-06-20 16:04 UTC (permalink / raw) To: Zhaoxiong Lv Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi, dri-devel, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 297 bytes --] On Thu, Jun 20, 2024 at 07:52:44PM +0800, Zhaoxiong Lv wrote: > This add the bindings for the 1280x800 TFT LCD Starry-er88577 DSI panel > to panel-simple-dsi. > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver 2024-06-20 11:52 [PATCH v4 0/2] Support Starry er88577 MIPI-DSI panel Zhaoxiong Lv 2024-06-20 11:52 ` [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings Zhaoxiong Lv @ 2024-06-20 11:52 ` Zhaoxiong Lv 2024-06-20 19:56 ` Dmitry Baryshkov 1 sibling, 1 reply; 8+ messages in thread From: Zhaoxiong Lv @ 2024-06-20 11:52 UTC (permalink / raw) To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv The bias IC of this starry-er88577 panel is placed on the panel side, so when the panel is powered on, there is no need to control AVDD and AVEE in the driver, only 3.3v and reset are needed. Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> --- Chage since V3: - 1. Adjust the ".clock" assignment format. v3: https://lore.kernel.org/all/20240614145609.25432-3-lvzhaoxiong@huaqin.corp-partner.google.com/ Chage since V3: - Separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver. - Use mipi_dsi_dcs_set_display_on_multi(). - Use mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep(). v2: https://lore.kernel.org/all/20240601084528.22502-5-lvzhaoxiong@huaqin.corp-partner.google.com/ Chage since V2: - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers. --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-starry-er88577.c | 343 +++++++++++++++++++ 3 files changed, 353 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index e54f6f5604ed..a52aa2552ab8 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -781,6 +781,15 @@ config DRM_PANEL_SITRONIX_ST7789V Say Y here if you want to enable support for the Sitronix ST7789V controller for 240x320 LCD panels +config DRM_PANEL_STARRY_ER88577 + tristate "Starry er88577 panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Starry er88577 controller. + config DRM_PANEL_SONY_ACX565AKM tristate "Sony ACX565AKM panel" depends on GPIOLIB && OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index f0203f6e02f4..ecd843a6dc6e 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -81,6 +81,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o +obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c new file mode 100644 index 000000000000..e6088262ee69 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-starry-er88577.c @@ -0,0 +1,343 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Panels based on the ER88577 display controller. + * Author: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> + */ + +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/regulator/consumer.h> + +#include <drm/drm_connector.h> +#include <drm/drm_crtc.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_panel.h> + +#include <video/mipi_display.h> +#include <drm/drm_probe_helper.h> + +struct starry_panel; + +struct panel_desc { + const struct drm_display_mode *modes; + unsigned int bpc; + unsigned long mode_flags; + enum mipi_dsi_pixel_format format; + const struct panel_init_cmd *init_cmds; + int (*init)(struct starry_panel *starry); + unsigned int lanes; + bool discharge_on_disable; + bool lp11_before_reset; + unsigned int power_off_delay_ms; +}; + +struct starry_panel { + struct drm_panel base; + struct mipi_dsi_device *dsi; + + const struct panel_desc *desc; + + enum drm_panel_orientation orientation; + struct regulator *vccio; + struct gpio_desc *reset; +}; + +static int starry_er88577_init(struct starry_panel *starry) +{ + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi }; + + /* T5:HWreset to init_code >= 120ms */ + mipi_dsi_msleep(dsi_ctx, 120); + + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a, + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e, + 0x06); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44, + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f, + 0x00, 0x54, 0x00); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, + 0x20, 0x44, 0xff, 0x18, 0x00); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d, + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d, + 0x13, 0x13, 0x11, 0x11, 0x24); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d, + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c, + 0x12, 0x12, 0x10, 0x10, 0x24); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06, + 0xb3); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08, + 0x10, 0x00, 0x00, 0x00); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff, + 0xff); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00); + + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + + mipi_dsi_msleep(dsi_ctx, 120); + + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); + mipi_dsi_msleep(dsi_ctx, 20); + + return dsi_ctx.accum_err; +}; + +static inline struct starry_panel *to_starry_panel(struct drm_panel *panel) +{ + return container_of(panel, struct starry_panel, base); +} + +static int starry_panel_disable(struct drm_panel *panel) +{ + struct starry_panel *starry = to_starry_panel(panel); + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi }; + + starry->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + mipi_dsi_msleep(dsi_ctx, 100); + + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + + mipi_dsi_msleep(dsi_ctx, 50); + + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); + + mipi_dsi_msleep(dsi_ctx, 120); + + return dsi_ctx.accum_err; +} + +static int starry_panel_unprepare(struct drm_panel *panel) +{ + struct starry_panel *starry = to_starry_panel(panel); + int err; + + gpiod_set_value_cansleep(starry->reset, 0); + + /* T15: 2ms */ + usleep_range(1000, 2000); + + err = regulator_disable(starry->vccio); + if (err < 0) + return err; + + if (starry->desc->power_off_delay_ms) + msleep(starry->desc->power_off_delay_ms); + + return 0; +} + +static int starry_panel_prepare(struct drm_panel *panel) +{ + struct starry_panel *starry = to_starry_panel(panel); + int err; + + gpiod_set_value(starry->reset, 0); + + err = regulator_enable(starry->vccio); + if (err < 0) + return err; + + /* T1:Vdd to mipi_lp >= 0ms */ + usleep_range(5000, 6000); + + if (starry->desc->lp11_before_reset) { + err = mipi_dsi_dcs_nop(starry->dsi); + if (err < 0) + goto poweroff; + + usleep_range(1000, 2000); + } + + /* T2: 10ms, T1 + T2 > 60ms */ + msleep(60); + + gpiod_set_value_cansleep(starry->reset, 1); + + err = starry->desc->init(starry); + if (err < 0) + goto poweroff; + + return 0; + +poweroff: + gpiod_set_value(starry->reset, 0); + /* T6: 2ms */ + usleep_range(1000, 2000); + regulator_disable(starry->vccio); + + return err; +} + +static int starry_panel_enable(struct drm_panel *panel) +{ + msleep(130); + return 0; +} + +static const struct drm_display_mode starry_er88577_default_mode = { + .clock = (800 + 25 + 25 + 25) * (1280 + 20 + 4 + 12) * 60 / 1000, + .hdisplay = 800, + .hsync_start = 800 + 25, + .hsync_end = 800 + 25 + 25, + .htotal = 800 + 25 + 25 + 25, + .vdisplay = 1280, + .vsync_start = 1280 + 20, + .vsync_end = 1280 + 20 + 4, + .vtotal = 1280 + 20 + 4 + 12, + .width_mm = 135, + .height_mm = 216, + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, +}; + +static const struct panel_desc starry_er88577_desc = { + .modes = &starry_er88577_default_mode, + .bpc = 8, + .lanes = 4, + .format = MIPI_DSI_FMT_RGB888, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_MODE_LPM, + .init = starry_er88577_init, + .lp11_before_reset = true, + .power_off_delay_ms = 1000, +}; + +static int starry_panel_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct starry_panel *starry = to_starry_panel(panel); + const struct drm_display_mode *mode = starry->desc->modes; + + return drm_connector_helper_get_modes_fixed(connector, mode); +} + +static enum drm_panel_orientation starry_panel_get_orientation(struct drm_panel *panel) +{ + struct starry_panel *starry = to_starry_panel(panel); + + return starry->orientation; +} + +static const struct drm_panel_funcs starry_panel_funcs = { + .disable = starry_panel_disable, + .unprepare = starry_panel_unprepare, + .prepare = starry_panel_prepare, + .enable = starry_panel_enable, + .get_modes = starry_panel_get_modes, + .get_orientation = starry_panel_get_orientation, +}; + +static int starry_panel_add(struct starry_panel *starry) +{ + struct device *dev = &starry->dsi->dev; + int err; + + starry->vccio = devm_regulator_get(dev, "vccio"); + if (IS_ERR(starry->vccio)) + return dev_err_probe(dev, PTR_ERR(starry->vccio), + "Cannot get vccio\n"); + + starry->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(starry->reset)) + return dev_err_probe(dev, PTR_ERR(starry->reset), + "Cannot get reset GPIO\n"); + + drm_panel_init(&starry->base, dev, &starry_panel_funcs, + DRM_MODE_CONNECTOR_DSI); + + err = of_drm_get_panel_orientation(dev->of_node, &starry->orientation); + if (err < 0) { + dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, err); + return err; + } + + err = drm_panel_of_backlight(&starry->base); + if (err) + return err; + + starry->base.funcs = &starry_panel_funcs; + starry->base.dev = &starry->dsi->dev; + + drm_panel_add(&starry->base); + + return 0; +} + +static int starry_panel_probe(struct mipi_dsi_device *dsi) +{ + struct starry_panel *starry; + int ret; + const struct panel_desc *desc; + + starry = devm_kzalloc(&dsi->dev, sizeof(*starry), GFP_KERNEL); + if (!starry) + return -ENOMEM; + + desc = of_device_get_match_data(&dsi->dev); + dsi->lanes = desc->lanes; + dsi->format = desc->format; + dsi->mode_flags = desc->mode_flags; + starry->desc = desc; + starry->dsi = dsi; + ret = starry_panel_add(starry); + if (ret < 0) + return ret; + + mipi_dsi_set_drvdata(dsi, starry); + + ret = mipi_dsi_attach(dsi); + if (ret) + drm_panel_remove(&starry->base); + + return ret; +} + +static void starry_panel_remove(struct mipi_dsi_device *dsi) +{ + struct starry_panel *starry = mipi_dsi_get_drvdata(dsi); + int ret; + + ret = mipi_dsi_detach(dsi); + if (ret < 0) + dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); + + if (starry->base.dev) + drm_panel_remove(&starry->base); +} + +static const struct of_device_id starry_of_match[] = { + { .compatible = "starry,er88577", + .data = &starry_er88577_desc + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, starry_of_match); + +static struct mipi_dsi_driver starry_panel_driver = { + .driver = { + .name = "panel-starry-er88577", + .of_match_table = starry_of_match, + }, + .probe = starry_panel_probe, + .remove = starry_panel_remove, +}; +module_mipi_dsi_driver(starry_panel_driver); + +MODULE_AUTHOR("Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>"); +MODULE_DESCRIPTION("starry er88577 800x1280 video mode panel driver"); +MODULE_LICENSE("GPL v2"); -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver 2024-06-20 11:52 ` [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver Zhaoxiong Lv @ 2024-06-20 19:56 ` Dmitry Baryshkov 2024-06-21 1:43 ` zhaoxiong lv 0 siblings, 1 reply; 8+ messages in thread From: Dmitry Baryshkov @ 2024-06-20 19:56 UTC (permalink / raw) To: Zhaoxiong Lv Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi, dri-devel, devicetree, linux-kernel On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote: > The bias IC of this starry-er88577 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver, > only 3.3v and reset are needed. > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > Chage since V3: > - 1. Adjust the ".clock" assignment format. > > v3: https://lore.kernel.org/all/20240614145609.25432-3-lvzhaoxiong@huaqin.corp-partner.google.com/ > > Chage since V3: > - Separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver. > - Use mipi_dsi_dcs_set_display_on_multi(). > - Use mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep(). > > v2: https://lore.kernel.org/all/20240601084528.22502-5-lvzhaoxiong@huaqin.corp-partner.google.com/ > > Chage since V2: > - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers. > > --- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-starry-er88577.c | 343 +++++++++++++++++++ > 3 files changed, 353 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index e54f6f5604ed..a52aa2552ab8 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -781,6 +781,15 @@ config DRM_PANEL_SITRONIX_ST7789V > Say Y here if you want to enable support for the Sitronix > ST7789V controller for 240x320 LCD panels > > +config DRM_PANEL_STARRY_ER88577 > + tristate "Starry er88577 panel" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y if you want to enable support for panels based on the > + Starry er88577 controller. > + > config DRM_PANEL_SONY_ACX565AKM > tristate "Sony ACX565AKM panel" > depends on GPIOLIB && OF && SPI > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index f0203f6e02f4..ecd843a6dc6e 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -81,6 +81,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o > +obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o > obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o > obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o > obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o > diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c > new file mode 100644 > index 000000000000..e6088262ee69 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-starry-er88577.c > @@ -0,0 +1,343 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Panels based on the ER88577 display controller. > + * Author: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > + */ > + > +#include <linux/delay.h> > +#include <linux/gpio/consumer.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/regulator/consumer.h> > + > +#include <drm/drm_connector.h> > +#include <drm/drm_crtc.h> > +#include <drm/drm_mipi_dsi.h> > +#include <drm/drm_panel.h> > + > +#include <video/mipi_display.h> > +#include <drm/drm_probe_helper.h> > + > +struct starry_panel; > + > +struct panel_desc { > + const struct drm_display_mode *modes; > + unsigned int bpc; > + unsigned long mode_flags; > + enum mipi_dsi_pixel_format format; > + const struct panel_init_cmd *init_cmds; > + int (*init)(struct starry_panel *starry); > + unsigned int lanes; > + bool discharge_on_disable; > + bool lp11_before_reset; > + unsigned int power_off_delay_ms; > +}; > + > +struct starry_panel { > + struct drm_panel base; > + struct mipi_dsi_device *dsi; > + > + const struct panel_desc *desc; > + > + enum drm_panel_orientation orientation; > + struct regulator *vccio; > + struct gpio_desc *reset; > +}; > + > +static int starry_er88577_init(struct starry_panel *starry) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi }; > + > + /* T5:HWreset to init_code >= 120ms */ > + mipi_dsi_msleep(dsi_ctx, 120); > + > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, > + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, > + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a, > + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e, > + 0x06); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44, > + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f, > + 0x00, 0x54, 0x00); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, > + 0x20, 0x44, 0xff, 0x18, 0x00); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d, > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d, > + 0x13, 0x13, 0x11, 0x11, 0x24); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d, > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c, > + 0x12, 0x12, 0x10, 0x10, 0x24); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06, > + 0xb3); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08, > + 0x10, 0x00, 0x00, 0x00); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff, > + 0xff); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00); NAK. This sequence looks _exactly_ like the sequence in panel-boe-th101mb31ig002-28a.c. > + > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > + > + mipi_dsi_msleep(dsi_ctx, 120); > + > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > + mipi_dsi_msleep(dsi_ctx, 20); > + > + return dsi_ctx.accum_err; -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver 2024-06-20 19:56 ` Dmitry Baryshkov @ 2024-06-21 1:43 ` zhaoxiong lv 2024-07-01 6:26 ` zhaoxiong lv 0 siblings, 1 reply; 8+ messages in thread From: zhaoxiong lv @ 2024-06-21 1:43 UTC (permalink / raw) To: Dmitry Baryshkov Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi, dri-devel, devicetree, linux-kernel On Fri, Jun 21, 2024 at 3:56 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote: > > The bias IC of this starry-er88577 panel is placed > > on the panel side, so when the panel is powered on, > > there is no need to control AVDD and AVEE in the driver, > > only 3.3v and reset are needed. > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > --- > > Chage since V3: > > - 1. Adjust the ".clock" assignment format. > > > > v3: https://lore.kernel.org/all/20240614145609.25432-3-lvzhaoxiong@huaqin.corp-partner.google.com/ > > > > Chage since V3: > > - Separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver. > > - Use mipi_dsi_dcs_set_display_on_multi(). > > - Use mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep(). > > > > v2: https://lore.kernel.org/all/20240601084528.22502-5-lvzhaoxiong@huaqin.corp-partner.google.com/ > > > > Chage since V2: > > - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers. > > > > --- > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > drivers/gpu/drm/panel/panel-starry-er88577.c | 343 +++++++++++++++++++ > > 3 files changed, 353 insertions(+) > > create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > index e54f6f5604ed..a52aa2552ab8 100644 > > --- a/drivers/gpu/drm/panel/Kconfig > > +++ b/drivers/gpu/drm/panel/Kconfig > > @@ -781,6 +781,15 @@ config DRM_PANEL_SITRONIX_ST7789V > > Say Y here if you want to enable support for the Sitronix > > ST7789V controller for 240x320 LCD panels > > > > +config DRM_PANEL_STARRY_ER88577 > > + tristate "Starry er88577 panel" > > + depends on OF > > + depends on DRM_MIPI_DSI > > + depends on BACKLIGHT_CLASS_DEVICE > > + help > > + Say Y if you want to enable support for panels based on the > > + Starry er88577 controller. > > + > > config DRM_PANEL_SONY_ACX565AKM > > tristate "Sony ACX565AKM panel" > > depends on GPIOLIB && OF && SPI > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > > index f0203f6e02f4..ecd843a6dc6e 100644 > > --- a/drivers/gpu/drm/panel/Makefile > > +++ b/drivers/gpu/drm/panel/Makefile > > @@ -81,6 +81,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o > > +obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o > > obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o > > obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o > > obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o > > diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c > > new file mode 100644 > > index 000000000000..e6088262ee69 > > --- /dev/null > > +++ b/drivers/gpu/drm/panel/panel-starry-er88577.c > > @@ -0,0 +1,343 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* Panels based on the ER88577 display controller. > > + * Author: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > + */ > > + > > +#include <linux/delay.h> > > +#include <linux/gpio/consumer.h> > > +#include <linux/module.h> > > +#include <linux/of.h> > > +#include <linux/regulator/consumer.h> > > + > > +#include <drm/drm_connector.h> > > +#include <drm/drm_crtc.h> > > +#include <drm/drm_mipi_dsi.h> > > +#include <drm/drm_panel.h> > > + > > +#include <video/mipi_display.h> > > +#include <drm/drm_probe_helper.h> > > + > > +struct starry_panel; > > + > > +struct panel_desc { > > + const struct drm_display_mode *modes; > > + unsigned int bpc; > > + unsigned long mode_flags; > > + enum mipi_dsi_pixel_format format; > > + const struct panel_init_cmd *init_cmds; > > + int (*init)(struct starry_panel *starry); > > + unsigned int lanes; > > + bool discharge_on_disable; > > + bool lp11_before_reset; > > + unsigned int power_off_delay_ms; > > +}; > > + > > +struct starry_panel { > > + struct drm_panel base; > > + struct mipi_dsi_device *dsi; > > + > > + const struct panel_desc *desc; > > + > > + enum drm_panel_orientation orientation; > > + struct regulator *vccio; > > + struct gpio_desc *reset; > > +}; > > + > > +static int starry_er88577_init(struct starry_panel *starry) > > +{ > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi }; > > + > > + /* T5:HWreset to init_code >= 120ms */ > > + mipi_dsi_msleep(dsi_ctx, 120); > > + > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, > > + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, > > + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a, > > + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e, > > + 0x06); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44, > > + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f, > > + 0x00, 0x54, 0x00); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, > > + 0x20, 0x44, 0xff, 0x18, 0x00); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d, > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d, > > + 0x13, 0x13, 0x11, 0x11, 0x24); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d, > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c, > > + 0x12, 0x12, 0x10, 0x10, 0x24); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06, > > + 0xb3); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08, > > + 0x10, 0x00, 0x00, 0x00); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff, > > + 0xff); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff); > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00); > > NAK. > > This sequence looks _exactly_ like the sequence in > panel-boe-th101mb31ig002-28a.c. > Hi Dmity We checked the panel-boe-th101mb31ig002-28a.c driver. The init_code is indeed very similar, but the ICs seem to be different from the names, and our panels and timings are also different. Do you want us to add compatibility with Starry in this driver panel-boe-th101mb31ig002-28a.c? thanks > > + > > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > > + > > + mipi_dsi_msleep(dsi_ctx, 120); > > + > > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > > + mipi_dsi_msleep(dsi_ctx, 20); > > + > > + return dsi_ctx.accum_err; > > -- > With best wishes > Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver 2024-06-21 1:43 ` zhaoxiong lv @ 2024-07-01 6:26 ` zhaoxiong lv 2024-07-01 9:11 ` Dmitry Baryshkov 0 siblings, 1 reply; 8+ messages in thread From: zhaoxiong lv @ 2024-07-01 6:26 UTC (permalink / raw) To: Dmitry Baryshkov Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi, dri-devel, devicetree, linux-kernel On Fri, Jun 21, 2024 at 9:43 AM zhaoxiong lv <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > On Fri, Jun 21, 2024 at 3:56 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote: > > > The bias IC of this starry-er88577 panel is placed > > > on the panel side, so when the panel is powered on, > > > there is no need to control AVDD and AVEE in the driver, > > > only 3.3v and reset are needed. > > > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > > --- > > > Chage since V3: > > > - 1. Adjust the ".clock" assignment format. > > > > > > v3: https://lore.kernel.org/all/20240614145609.25432-3-lvzhaoxiong@huaqin.corp-partner.google.com/ > > > > > > Chage since V3: > > > - Separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver. > > > - Use mipi_dsi_dcs_set_display_on_multi(). > > > - Use mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep(). > > > > > > v2: https://lore.kernel.org/all/20240601084528.22502-5-lvzhaoxiong@huaqin.corp-partner.google.com/ > > > > > > Chage since V2: > > > - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers. > > > > > > --- > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > drivers/gpu/drm/panel/Makefile | 1 + > > > drivers/gpu/drm/panel/panel-starry-er88577.c | 343 +++++++++++++++++++ > > > 3 files changed, 353 insertions(+) > > > create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c > > > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > > index e54f6f5604ed..a52aa2552ab8 100644 > > > --- a/drivers/gpu/drm/panel/Kconfig > > > +++ b/drivers/gpu/drm/panel/Kconfig > > > @@ -781,6 +781,15 @@ config DRM_PANEL_SITRONIX_ST7789V > > > Say Y here if you want to enable support for the Sitronix > > > ST7789V controller for 240x320 LCD panels > > > > > > +config DRM_PANEL_STARRY_ER88577 > > > + tristate "Starry er88577 panel" > > > + depends on OF > > > + depends on DRM_MIPI_DSI > > > + depends on BACKLIGHT_CLASS_DEVICE > > > + help > > > + Say Y if you want to enable support for panels based on the > > > + Starry er88577 controller. > > > + > > > config DRM_PANEL_SONY_ACX565AKM > > > tristate "Sony ACX565AKM panel" > > > depends on GPIOLIB && OF && SPI > > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > > > index f0203f6e02f4..ecd843a6dc6e 100644 > > > --- a/drivers/gpu/drm/panel/Makefile > > > +++ b/drivers/gpu/drm/panel/Makefile > > > @@ -81,6 +81,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o > > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o > > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o > > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o > > > +obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o > > > obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o > > > obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o > > > obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o > > > diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c > > > new file mode 100644 > > > index 000000000000..e6088262ee69 > > > --- /dev/null > > > +++ b/drivers/gpu/drm/panel/panel-starry-er88577.c > > > @@ -0,0 +1,343 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* Panels based on the ER88577 display controller. > > > + * Author: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > > + */ > > > + > > > +#include <linux/delay.h> > > > +#include <linux/gpio/consumer.h> > > > +#include <linux/module.h> > > > +#include <linux/of.h> > > > +#include <linux/regulator/consumer.h> > > > + > > > +#include <drm/drm_connector.h> > > > +#include <drm/drm_crtc.h> > > > +#include <drm/drm_mipi_dsi.h> > > > +#include <drm/drm_panel.h> > > > + > > > +#include <video/mipi_display.h> > > > +#include <drm/drm_probe_helper.h> > > > + > > > +struct starry_panel; > > > + > > > +struct panel_desc { > > > + const struct drm_display_mode *modes; > > > + unsigned int bpc; > > > + unsigned long mode_flags; > > > + enum mipi_dsi_pixel_format format; > > > + const struct panel_init_cmd *init_cmds; > > > + int (*init)(struct starry_panel *starry); > > > + unsigned int lanes; > > > + bool discharge_on_disable; > > > + bool lp11_before_reset; > > > + unsigned int power_off_delay_ms; > > > +}; > > > + > > > +struct starry_panel { > > > + struct drm_panel base; > > > + struct mipi_dsi_device *dsi; > > > + > > > + const struct panel_desc *desc; > > > + > > > + enum drm_panel_orientation orientation; > > > + struct regulator *vccio; > > > + struct gpio_desc *reset; > > > +}; > > > + > > > +static int starry_er88577_init(struct starry_panel *starry) > > > +{ > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi }; > > > + > > > + /* T5:HWreset to init_code >= 120ms */ > > > + mipi_dsi_msleep(dsi_ctx, 120); > > > + > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, > > > + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, > > > + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a, > > > + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e, > > > + 0x06); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44, > > > + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f, > > > + 0x00, 0x54, 0x00); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, > > > + 0x20, 0x44, 0xff, 0x18, 0x00); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d, > > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d, > > > + 0x13, 0x13, 0x11, 0x11, 0x24); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d, > > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c, > > > + 0x12, 0x12, 0x10, 0x10, 0x24); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06, > > > + 0xb3); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08, > > > + 0x10, 0x00, 0x00, 0x00); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff, > > > + 0xff); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff); > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00); > > > > NAK. > > > > This sequence looks _exactly_ like the sequence in > > panel-boe-th101mb31ig002-28a.c. > > > Hi Dmity > > We checked the panel-boe-th101mb31ig002-28a.c driver. The init_code is > indeed very similar, but the ICs seem to be different from the names, > and our panels and timings are also different. Do you want us to add > compatibility with Starry in this driver > panel-boe-th101mb31ig002-28a.c? > > thanks > hi dmitry.baryshkov We tried to make modifications based on the panel-boe-th101mb31ig002-28a.c driver, but we encountered some problems. For example, the panel-boe-th101mb31ig002-28a.c driver will get "enable/reset" gpio in the probe() function, but our hardware design only has "enable". This will cause an error to be returned in the devm_gpiod_get function when we use this driver and the probe() function will be interrupted. How should we modify this? Can we re-judge the return value of the devm_gpiod_get function? thanks > > > + > > > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > > > + > > > + mipi_dsi_msleep(dsi_ctx, 120); > > > + > > > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > > > + mipi_dsi_msleep(dsi_ctx, 20); > > > + > > > + return dsi_ctx.accum_err; > > > > -- > > With best wishes > > Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver 2024-07-01 6:26 ` zhaoxiong lv @ 2024-07-01 9:11 ` Dmitry Baryshkov 0 siblings, 0 replies; 8+ messages in thread From: Dmitry Baryshkov @ 2024-07-01 9:11 UTC (permalink / raw) To: zhaoxiong lv Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, dianders, hsinyi, dri-devel, devicetree, linux-kernel On Mon, 1 Jul 2024 at 09:26, zhaoxiong lv <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > On Fri, Jun 21, 2024 at 9:43 AM zhaoxiong lv > <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > > > On Fri, Jun 21, 2024 at 3:56 AM Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote: > > > > The bias IC of this starry-er88577 panel is placed > > > > on the panel side, so when the panel is powered on, > > > > there is no need to control AVDD and AVEE in the driver, > > > > only 3.3v and reset are needed. > > > > > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > > > --- > > > > Chage since V3: > > > > - 1. Adjust the ".clock" assignment format. > > > > > > > > v3: https://lore.kernel.org/all/20240614145609.25432-3-lvzhaoxiong@huaqin.corp-partner.google.com/ > > > > > > > > Chage since V3: > > > > - Separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver. > > > > - Use mipi_dsi_dcs_set_display_on_multi(). > > > > - Use mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep(). > > > > > > > > v2: https://lore.kernel.org/all/20240601084528.22502-5-lvzhaoxiong@huaqin.corp-partner.google.com/ > > > > > > > > Chage since V2: > > > > - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers. > > > > > > > > --- > > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > > drivers/gpu/drm/panel/Makefile | 1 + > > > > drivers/gpu/drm/panel/panel-starry-er88577.c | 343 +++++++++++++++++++ > > > > 3 files changed, 353 insertions(+) > > > > create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c > > > > > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > > > index e54f6f5604ed..a52aa2552ab8 100644 > > > > --- a/drivers/gpu/drm/panel/Kconfig > > > > +++ b/drivers/gpu/drm/panel/Kconfig > > > > @@ -781,6 +781,15 @@ config DRM_PANEL_SITRONIX_ST7789V > > > > Say Y here if you want to enable support for the Sitronix > > > > ST7789V controller for 240x320 LCD panels > > > > > > > > +config DRM_PANEL_STARRY_ER88577 > > > > + tristate "Starry er88577 panel" > > > > + depends on OF > > > > + depends on DRM_MIPI_DSI > > > > + depends on BACKLIGHT_CLASS_DEVICE > > > > + help > > > > + Say Y if you want to enable support for panels based on the > > > > + Starry er88577 controller. > > > > + > > > > config DRM_PANEL_SONY_ACX565AKM > > > > tristate "Sony ACX565AKM panel" > > > > depends on GPIOLIB && OF && SPI > > > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > > > > index f0203f6e02f4..ecd843a6dc6e 100644 > > > > --- a/drivers/gpu/drm/panel/Makefile > > > > +++ b/drivers/gpu/drm/panel/Makefile > > > > @@ -81,6 +81,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o > > > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o > > > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o > > > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o > > > > +obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o > > > > obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o > > > > obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o > > > > obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o > > > > diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c > > > > new file mode 100644 > > > > index 000000000000..e6088262ee69 > > > > --- /dev/null > > > > +++ b/drivers/gpu/drm/panel/panel-starry-er88577.c > > > > @@ -0,0 +1,343 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +/* Panels based on the ER88577 display controller. > > > > + * Author: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > > > + */ > > > > + > > > > +#include <linux/delay.h> > > > > +#include <linux/gpio/consumer.h> > > > > +#include <linux/module.h> > > > > +#include <linux/of.h> > > > > +#include <linux/regulator/consumer.h> > > > > + > > > > +#include <drm/drm_connector.h> > > > > +#include <drm/drm_crtc.h> > > > > +#include <drm/drm_mipi_dsi.h> > > > > +#include <drm/drm_panel.h> > > > > + > > > > +#include <video/mipi_display.h> > > > > +#include <drm/drm_probe_helper.h> > > > > + > > > > +struct starry_panel; > > > > + > > > > +struct panel_desc { > > > > + const struct drm_display_mode *modes; > > > > + unsigned int bpc; > > > > + unsigned long mode_flags; > > > > + enum mipi_dsi_pixel_format format; > > > > + const struct panel_init_cmd *init_cmds; > > > > + int (*init)(struct starry_panel *starry); > > > > + unsigned int lanes; > > > > + bool discharge_on_disable; > > > > + bool lp11_before_reset; > > > > + unsigned int power_off_delay_ms; > > > > +}; > > > > + > > > > +struct starry_panel { > > > > + struct drm_panel base; > > > > + struct mipi_dsi_device *dsi; > > > > + > > > > + const struct panel_desc *desc; > > > > + > > > > + enum drm_panel_orientation orientation; > > > > + struct regulator *vccio; > > > > + struct gpio_desc *reset; > > > > +}; > > > > + > > > > +static int starry_er88577_init(struct starry_panel *starry) > > > > +{ > > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi }; > > > > + > > > > + /* T5:HWreset to init_code >= 120ms */ > > > > + mipi_dsi_msleep(dsi_ctx, 120); > > > > + > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, > > > > + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, > > > > + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a, > > > > + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e, > > > > + 0x06); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44, > > > > + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f, > > > > + 0x00, 0x54, 0x00); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, > > > > + 0x20, 0x44, 0xff, 0x18, 0x00); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d, > > > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d, > > > > + 0x13, 0x13, 0x11, 0x11, 0x24); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d, > > > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c, > > > > + 0x12, 0x12, 0x10, 0x10, 0x24); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06, > > > > + 0xb3); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08, > > > > + 0x10, 0x00, 0x00, 0x00); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff, > > > > + 0xff); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff); > > > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00); > > > > > > NAK. > > > > > > This sequence looks _exactly_ like the sequence in > > > panel-boe-th101mb31ig002-28a.c. > > > > > Hi Dmity > > > > We checked the panel-boe-th101mb31ig002-28a.c driver. The init_code is > > indeed very similar, but the ICs seem to be different from the names, > > and our panels and timings are also different. Do you want us to add > > compatibility with Starry in this driver > > panel-boe-th101mb31ig002-28a.c? > > > > thanks > > > hi dmitry.baryshkov > > We tried to make modifications based on the > panel-boe-th101mb31ig002-28a.c driver, but we encountered some > problems. > For example, the panel-boe-th101mb31ig002-28a.c driver will get > "enable/reset" gpio in the probe() function, but our hardware design > only has "enable". This will cause an error to be returned in the > devm_gpiod_get function when we use this driver and the probe() > function will be interrupted. > How should we modify this? Can we re-judge the return value of the > devm_gpiod_get function? If it is optional, then it should be devm_gpiod_get_optional(). > > thanks > > > > > + > > > > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > > > > + > > > > + mipi_dsi_msleep(dsi_ctx, 120); > > > > + > > > > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > > > > + mipi_dsi_msleep(dsi_ctx, 20); > > > > + > > > > + return dsi_ctx.accum_err; > > > > > > -- > > > With best wishes > > > Dmitry -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-01 9:11 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-20 11:52 [PATCH v4 0/2] Support Starry er88577 MIPI-DSI panel Zhaoxiong Lv 2024-06-20 11:52 ` [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings Zhaoxiong Lv 2024-06-20 16:04 ` Conor Dooley 2024-06-20 11:52 ` [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver Zhaoxiong Lv 2024-06-20 19:56 ` Dmitry Baryshkov 2024-06-21 1:43 ` zhaoxiong lv 2024-07-01 6:26 ` zhaoxiong lv 2024-07-01 9:11 ` Dmitry Baryshkov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.