All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Helge Deller <deller@gmx.de>,
	linux-parisc@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>,
	sparclinux@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, Brian Cain <bcain@quicinc.com>,
	linux-hexagon@vger.kernel.org, Guo Ren <guoren@kernel.org>,
	linux-csky@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	linux-s390@vger.kernel.org, Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	linux-sh@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, libc-alpha@sourceware.org,
	musl@lists.openwall.com, ltp@lists.linux.it
Subject: [PATCH 03/15] mips: fix compat_sys_lseek syscall
Date: Thu, 20 Jun 2024 18:23:04 +0200	[thread overview]
Message-ID: <20240620162316.3674955-4-arnd@kernel.org> (raw)
In-Reply-To: <20240620162316.3674955-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

This is almost compatible, but passing a negative offset should result
in a EINVAL error, but on mips o32 compat mode would seek to a large
32-bit byte offset.

Use compat_sys_lseek() to correctly sign-extend the argument.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/syscalls/syscall_o32.tbl b/arch/mips/kernel/syscalls/syscall_o32.tbl
index 85751c9b9cdb..2439a2491cff 100644
--- a/arch/mips/kernel/syscalls/syscall_o32.tbl
+++ b/arch/mips/kernel/syscalls/syscall_o32.tbl
@@ -27,7 +27,7 @@
 17	o32	break				sys_ni_syscall
 # 18 was sys_stat
 18	o32	unused18			sys_ni_syscall
-19	o32	lseek				sys_lseek
+19	o32	lseek				sys_lseek			compat_sys_lseek
 20	o32	getpid				sys_getpid
 21	o32	mount				sys_mount
 22	o32	umount				sys_oldumount
-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rich Felker <dalias@libc.org>,
	Andreas Larsson <andreas@gaisler.com>,
	Guo Ren <guoren@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-s390@vger.kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-sh@vger.kernel.org, linux-csky@vger.kernel.org,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	musl@lists.openwall.com, Nicholas Piggin <npiggin@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	ltp@lists.linux.it, Brian Cain <bcain@quicinc.com>,
	Christian Brauner <brauner@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	libc-alpha@sourceware.org, linux-parisc@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-hexagon@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: [LTP] [PATCH 03/15] mips: fix compat_sys_lseek syscall
Date: Thu, 20 Jun 2024 18:23:04 +0200	[thread overview]
Message-ID: <20240620162316.3674955-4-arnd@kernel.org> (raw)
In-Reply-To: <20240620162316.3674955-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

This is almost compatible, but passing a negative offset should result
in a EINVAL error, but on mips o32 compat mode would seek to a large
32-bit byte offset.

Use compat_sys_lseek() to correctly sign-extend the argument.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/syscalls/syscall_o32.tbl b/arch/mips/kernel/syscalls/syscall_o32.tbl
index 85751c9b9cdb..2439a2491cff 100644
--- a/arch/mips/kernel/syscalls/syscall_o32.tbl
+++ b/arch/mips/kernel/syscalls/syscall_o32.tbl
@@ -27,7 +27,7 @@
 17	o32	break				sys_ni_syscall
 # 18 was sys_stat
 18	o32	unused18			sys_ni_syscall
-19	o32	lseek				sys_lseek
+19	o32	lseek				sys_lseek			compat_sys_lseek
 20	o32	getpid				sys_getpid
 21	o32	mount				sys_mount
 22	o32	umount				sys_oldumount
-- 
2.39.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rich Felker <dalias@libc.org>,
	Andreas Larsson <andreas@gaisler.com>,
	Guo Ren <guoren@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-s390@vger.kernel.org,
	Helge Deller <deller@gmx.de>,
	linux-sh@vger.kernel.org, linux-csky@vger.kernel.org,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>, Heiko Carstens <hca@linux.ibm.com>,
	musl@lists.openwall.com, Nicholas Piggin <npiggin@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	ltp@lists.linux.it, Brian Cain <bcain@quicinc.com>,
	Christian Brauner <brauner@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	libc-alpha@sourceware.org, linux-parisc@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-hexagon@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 03/15] mips: fix compat_sys_lseek syscall
Date: Thu, 20 Jun 2024 18:23:04 +0200	[thread overview]
Message-ID: <20240620162316.3674955-4-arnd@kernel.org> (raw)
In-Reply-To: <20240620162316.3674955-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

This is almost compatible, but passing a negative offset should result
in a EINVAL error, but on mips o32 compat mode would seek to a large
32-bit byte offset.

Use compat_sys_lseek() to correctly sign-extend the argument.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/syscalls/syscall_o32.tbl b/arch/mips/kernel/syscalls/syscall_o32.tbl
index 85751c9b9cdb..2439a2491cff 100644
--- a/arch/mips/kernel/syscalls/syscall_o32.tbl
+++ b/arch/mips/kernel/syscalls/syscall_o32.tbl
@@ -27,7 +27,7 @@
 17	o32	break				sys_ni_syscall
 # 18 was sys_stat
 18	o32	unused18			sys_ni_syscall
-19	o32	lseek				sys_lseek
+19	o32	lseek				sys_lseek			compat_sys_lseek
 20	o32	getpid				sys_getpid
 21	o32	mount				sys_mount
 22	o32	umount				sys_oldumount
-- 
2.39.2


  parent reply	other threads:[~2024-06-20 16:23 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 16:23 [PATCH 00/15] linux system call fixes Arnd Bergmann
2024-06-20 16:23 ` Arnd Bergmann
2024-06-20 16:23 ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` [PATCH 01/15] ftruncate: pass a signed offset Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-21  7:47   ` Christian Brauner
2024-06-21  7:47     ` Christian Brauner
2024-06-21  7:47     ` [LTP] " Christian Brauner
2024-06-20 16:23 ` [PATCH 02/15] syscalls: fix compat_sys_io_pgetevents_time64 usage Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-21 14:19   ` Heiko Carstens
2024-06-21 14:19     ` Heiko Carstens
2024-06-21 14:19     ` [LTP] " Heiko Carstens
2024-06-24 12:52   ` Arnd Bergmann
2024-06-24 12:52     ` Arnd Bergmann
2024-06-24 12:52     ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` Arnd Bergmann [this message]
2024-06-20 16:23   ` [PATCH 03/15] mips: fix compat_sys_lseek syscall Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-21  8:25   ` Thomas Bogendoerfer
2024-06-21  8:25     ` Thomas Bogendoerfer
2024-06-21  8:25     ` [LTP] " Thomas Bogendoerfer
2024-06-20 16:23 ` [PATCH 04/15] sparc: fix old compat_sys_select() Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` [PATCH 05/15] sparc: fix compat recv/recvfrom syscalls Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` [PATCH 06/15] parisc: use correct " Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-20 20:36   ` Helge Deller
2024-06-20 16:23 ` [PATCH 07/15] parisc: use generic sys_fanotify_mark implementation Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-20 21:21   ` Helge Deller
2024-06-20 21:21     ` Helge Deller
2024-06-20 21:21     ` [LTP] " Helge Deller via ltp
2024-06-21  5:26     ` LEROY Christophe
2024-06-21  5:26       ` LEROY Christophe
2024-06-21  5:26       ` [LTP] " LEROY Christophe via ltp
2024-06-21  6:28       ` Arnd Bergmann
2024-06-21  6:28         ` Arnd Bergmann
2024-06-21  6:28         ` [LTP] " Arnd Bergmann
2024-06-21  8:54         ` John Paul Adrian Glaubitz
2024-06-21  8:54           ` John Paul Adrian Glaubitz
2024-06-21  8:54           ` [LTP] " John Paul Adrian Glaubitz
2024-06-21 12:22           ` John David Anglin
2024-06-21 12:22             ` John David Anglin
2024-06-21 12:22             ` [LTP] " John David Anglin
2024-06-21  8:52     ` John Paul Adrian Glaubitz
2024-06-21  8:52       ` John Paul Adrian Glaubitz
2024-06-21  8:52       ` [LTP] " John Paul Adrian Glaubitz
2024-06-21  8:56       ` Arnd Bergmann
2024-06-21  8:56         ` Arnd Bergmann
2024-06-21  8:56         ` [LTP] " Arnd Bergmann
2024-06-21  9:03         ` John Paul Adrian Glaubitz
2024-06-21  9:03           ` John Paul Adrian Glaubitz
2024-06-21  9:52           ` Arnd Bergmann
2024-06-21  9:52             ` Arnd Bergmann
2024-06-21  9:52             ` [LTP] " Arnd Bergmann
2024-06-21 16:28             ` Helge Deller
2024-06-21 16:28               ` Helge Deller
2024-06-21 16:28               ` [LTP] " Helge Deller via ltp
2024-06-20 16:23 ` [PATCH 08/15] powerpc: restore some missing spu syscalls Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-24  2:23   ` Michael Ellerman
2024-06-24  2:23     ` Michael Ellerman
2024-06-24  2:23     ` [LTP] " Michael Ellerman
2024-06-20 16:23 ` [PATCH 09/15] sh: rework sync_file_range ABI Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-21  8:44   ` John Paul Adrian Glaubitz
2024-06-21  8:44     ` John Paul Adrian Glaubitz
2024-06-21  8:44     ` [LTP] " John Paul Adrian Glaubitz
2024-06-21  9:41     ` Arnd Bergmann
2024-06-21  9:41       ` Arnd Bergmann
2024-06-21  9:41       ` [LTP] " Arnd Bergmann
2024-06-24  6:14       ` John Paul Adrian Glaubitz
2024-06-24  6:14         ` John Paul Adrian Glaubitz
2024-06-24 12:49         ` Arnd Bergmann
2024-06-24 12:49           ` Arnd Bergmann
2024-06-24 12:49           ` [LTP] " Arnd Bergmann
2024-06-21 19:57     ` [musl] " Rich Felker
2024-06-21 19:57       ` Rich Felker
2024-06-21 19:57       ` [LTP] " Rich Felker
2024-06-20 16:23 ` [PATCH 10/15] csky, hexagon: fix broken sys_sync_file_range Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-23 17:10   ` Guo Ren
2024-06-23 17:10     ` Guo Ren
2024-06-23 17:10     ` [LTP] " Guo Ren
2024-06-20 16:23 ` [PATCH 11/15] hexagon: fix fadvise64_64 calling conventions Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` [PATCH 12/15] s390: remove native mmap2() syscall Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-21 14:17   ` Heiko Carstens
2024-06-21 14:17     ` Heiko Carstens
2024-06-21 14:17     ` [LTP] " Heiko Carstens
2024-06-20 16:23 ` [PATCH 13/15] syscalls: mmap(): use unsigned offset type consistently Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` [PATCH 14/15] asm-generic: unistd: fix time32 compat syscall handling Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann
2024-06-24 12:36   ` Arnd Bergmann
2024-06-24 12:36     ` Arnd Bergmann
2024-06-24 12:36     ` [LTP] " Arnd Bergmann
2024-06-20 16:23 ` [PATCH 15/15] linux/syscalls.h: add missing __user annotations Arnd Bergmann
2024-06-20 16:23   ` Arnd Bergmann
2024-06-20 16:23   ` [LTP] " Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620162316.3674955-4-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=bcain@quicinc.com \
    --cc=brauner@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dalias@libc.org \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=guoren@kernel.org \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ltp@lists.linux.it \
    --cc=mpe@ellerman.id.au \
    --cc=musl@lists.openwall.com \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.