Re: [PATCH 1/2] MAINTAINERS: drm : vc4: Add Raspberry Pi as maintainers

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]

On Thu, Jun 20, 2024 at 03:06:11PM GMT, Dave Stevenson wrote:
> On Thu, 20 Jun 2024 at 14:52, Maxime Ripard <mripard@kernel.org> wrote:
> >
> > On Thu, Jun 20, 2024 at 12:14:00PM GMT, Dave Stevenson wrote:
> > > Add myself and our kernel maintenance list as maintainers for
> > > VC4 alongside Maxime.
> > >
> > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> > > ---
> > >  MAINTAINERS | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index d1566c647a50..b6dd628d5bc6 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7520,6 +7520,8 @@ F:      include/uapi/drm/v3d_drm.h
> > >
> > >  DRM DRIVERS FOR VC4
> > >  M:   Maxime Ripard <mripard@kernel.org>
> > > +M:   Dave Stevenson <dave.stevenson@raspberrypi.com>
> > > +M:   Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
> >
> > I don't think we can put a list as maintainer, maintainers (and
> > reviewers) should be explicit. We can definitely put the list as Cc with
> > L: though :)
> 
> It's been accepted for Unicam
> https://github.com/torvalds/linux/blob/master/MAINTAINERS#L4178-L4183

I think it's somewhat different in the case of v4l2, you're the one
taking the patches and sending a PR iirc. In drm-misc, there's a
significant chance someone else will apply it.

> bcm-kernel-feedback-list@broadcom.com is listed as reviewer for a fair
> number of entries.

It's also a matter of signalling to the rest of the kernel community how
important a review is: if I get a review of someone on a patch that
isn't listed in MAINTAINERS, then it's valid but not enough for me to
merge it.

If it's from a reviewer, then it carries more weight, and if it's from a
maintainer, then it's pretty much the final word.

That only works if we explicitly put names in MAINTAINERS.

But I also don't care how many maintainers or reviewers you want to put
in MAINTAINERS, so it's not gatekeeping. It's mostly just around
documenting what the situation will be :)

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]