* [tip:irq/core 41/49] drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void'
@ 2024-06-24 19:20 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-06-24 19:20 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: llvm, oe-kbuild-all, linux-kernel, x86, Thomas Gleixner
Hi Jisheng,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head: f2605e1715dd28e8943b557453fed3a40421d3b5
commit: 7cc4f309c933ec5d64eea31066fe86bbf9e48819 [41/49] irqchip/dw-apb-ictl: Support building as module
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240625/202406250323.bMydP9v3-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240625/202406250323.bMydP9v3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406250323.bMydP9v3-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void'
33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
| ^
arch/x86/include/asm/irq.h:19:21: note: expanded from macro '__irq_entry'
19 | #define __irq_entry __invalid_section
| ^
>> drivers/irqchip/irq-dw-apb-ictl.c:33:24: error: expected ';' after top level declarator
33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
| ^
| ;
>> drivers/irqchip/irq-dw-apb-ictl.c:206:18: error: use of undeclared identifier 'dw_apb_ictl_handle_irq'
206 | set_handle_irq(dw_apb_ictl_handle_irq);
| ^
3 errors generated.
vim +/void +33 drivers/irqchip/irq-dw-apb-ictl.c
54a38440b84f893 Zhen Lei 2020-09-24 32
54a38440b84f893 Zhen Lei 2020-09-24 @33 static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
54a38440b84f893 Zhen Lei 2020-09-24 34 {
54a38440b84f893 Zhen Lei 2020-09-24 35 struct irq_domain *d = dw_apb_ictl_irq_domain;
54a38440b84f893 Zhen Lei 2020-09-24 36 int n;
54a38440b84f893 Zhen Lei 2020-09-24 37
54a38440b84f893 Zhen Lei 2020-09-24 38 for (n = 0; n < d->revmap_size; n += 32) {
54a38440b84f893 Zhen Lei 2020-09-24 39 struct irq_chip_generic *gc = irq_get_domain_generic_chip(d, n);
54a38440b84f893 Zhen Lei 2020-09-24 40 u32 stat = readl_relaxed(gc->reg_base + APB_INT_FINALSTATUS_L);
54a38440b84f893 Zhen Lei 2020-09-24 41
54a38440b84f893 Zhen Lei 2020-09-24 42 while (stat) {
54a38440b84f893 Zhen Lei 2020-09-24 43 u32 hwirq = ffs(stat) - 1;
54a38440b84f893 Zhen Lei 2020-09-24 44
0953fb263714e1c Mark Rutland 2021-10-20 45 generic_handle_domain_irq(d, hwirq);
54a38440b84f893 Zhen Lei 2020-09-24 46 stat &= ~BIT(hwirq);
54a38440b84f893 Zhen Lei 2020-09-24 47 }
54a38440b84f893 Zhen Lei 2020-09-24 48 }
54a38440b84f893 Zhen Lei 2020-09-24 49 }
54a38440b84f893 Zhen Lei 2020-09-24 50
d59f7d159891466 Zhen Lei 2020-09-24 51 static void dw_apb_ictl_handle_irq_cascaded(struct irq_desc *desc)
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 52 {
b66231183a8542d Thomas Gleixner 2015-07-06 53 struct irq_domain *d = irq_desc_get_handler_data(desc);
b66231183a8542d Thomas Gleixner 2015-07-06 54 struct irq_chip *chip = irq_desc_get_chip(desc);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 55 int n;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 56
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 57 chained_irq_enter(chip, desc);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 58
b66231183a8542d Thomas Gleixner 2015-07-06 59 for (n = 0; n < d->revmap_size; n += 32) {
b66231183a8542d Thomas Gleixner 2015-07-06 60 struct irq_chip_generic *gc = irq_get_domain_generic_chip(d, n);
b66231183a8542d Thomas Gleixner 2015-07-06 61 u32 stat = readl_relaxed(gc->reg_base + APB_INT_FINALSTATUS_L);
b66231183a8542d Thomas Gleixner 2015-07-06 62
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 63 while (stat) {
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 64 u32 hwirq = ffs(stat) - 1;
046a6ee2343bb26 Marc Zyngier 2021-05-04 65 generic_handle_domain_irq(d, gc->irq_base + hwirq);
b66231183a8542d Thomas Gleixner 2015-07-06 66
d59f7d159891466 Zhen Lei 2020-09-24 67 stat &= ~BIT(hwirq);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 68 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 69 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 70
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 71 chained_irq_exit(chip, desc);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 72 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 73
54a38440b84f893 Zhen Lei 2020-09-24 74 static int dw_apb_ictl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
54a38440b84f893 Zhen Lei 2020-09-24 75 unsigned int nr_irqs, void *arg)
54a38440b84f893 Zhen Lei 2020-09-24 76 {
54a38440b84f893 Zhen Lei 2020-09-24 77 int i, ret;
54a38440b84f893 Zhen Lei 2020-09-24 78 irq_hw_number_t hwirq;
54a38440b84f893 Zhen Lei 2020-09-24 79 unsigned int type = IRQ_TYPE_NONE;
54a38440b84f893 Zhen Lei 2020-09-24 80 struct irq_fwspec *fwspec = arg;
54a38440b84f893 Zhen Lei 2020-09-24 81
54a38440b84f893 Zhen Lei 2020-09-24 82 ret = irq_domain_translate_onecell(domain, fwspec, &hwirq, &type);
54a38440b84f893 Zhen Lei 2020-09-24 83 if (ret)
54a38440b84f893 Zhen Lei 2020-09-24 84 return ret;
54a38440b84f893 Zhen Lei 2020-09-24 85
54a38440b84f893 Zhen Lei 2020-09-24 86 for (i = 0; i < nr_irqs; i++)
54a38440b84f893 Zhen Lei 2020-09-24 87 irq_map_generic_chip(domain, virq + i, hwirq + i);
54a38440b84f893 Zhen Lei 2020-09-24 88
54a38440b84f893 Zhen Lei 2020-09-24 89 return 0;
54a38440b84f893 Zhen Lei 2020-09-24 90 }
54a38440b84f893 Zhen Lei 2020-09-24 91
54a38440b84f893 Zhen Lei 2020-09-24 92 static const struct irq_domain_ops dw_apb_ictl_irq_domain_ops = {
54a38440b84f893 Zhen Lei 2020-09-24 93 .translate = irq_domain_translate_onecell,
54a38440b84f893 Zhen Lei 2020-09-24 94 .alloc = dw_apb_ictl_irq_domain_alloc,
54a38440b84f893 Zhen Lei 2020-09-24 95 .free = irq_domain_free_irqs_top,
54a38440b84f893 Zhen Lei 2020-09-24 96 };
54a38440b84f893 Zhen Lei 2020-09-24 97
1655b0530d9502e Jisheng Zhang 2014-11-12 98 #ifdef CONFIG_PM
1655b0530d9502e Jisheng Zhang 2014-11-12 99 static void dw_apb_ictl_resume(struct irq_data *d)
1655b0530d9502e Jisheng Zhang 2014-11-12 100 {
1655b0530d9502e Jisheng Zhang 2014-11-12 101 struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
1655b0530d9502e Jisheng Zhang 2014-11-12 102 struct irq_chip_type *ct = irq_data_get_chip_type(d);
1655b0530d9502e Jisheng Zhang 2014-11-12 103
1655b0530d9502e Jisheng Zhang 2014-11-12 104 irq_gc_lock(gc);
1655b0530d9502e Jisheng Zhang 2014-11-12 105 writel_relaxed(~0, gc->reg_base + ct->regs.enable);
1655b0530d9502e Jisheng Zhang 2014-11-12 106 writel_relaxed(*ct->mask_cache, gc->reg_base + ct->regs.mask);
1655b0530d9502e Jisheng Zhang 2014-11-12 107 irq_gc_unlock(gc);
1655b0530d9502e Jisheng Zhang 2014-11-12 108 }
1655b0530d9502e Jisheng Zhang 2014-11-12 109 #else
1655b0530d9502e Jisheng Zhang 2014-11-12 110 #define dw_apb_ictl_resume NULL
1655b0530d9502e Jisheng Zhang 2014-11-12 111 #endif /* CONFIG_PM */
1655b0530d9502e Jisheng Zhang 2014-11-12 112
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 113 static int __init dw_apb_ictl_init(struct device_node *np,
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 114 struct device_node *parent)
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 115 {
d59f7d159891466 Zhen Lei 2020-09-24 116 const struct irq_domain_ops *domain_ops;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 117 unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 118 struct resource r;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 119 struct irq_domain *domain;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 120 struct irq_chip_generic *gc;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 121 void __iomem *iobase;
d59f7d159891466 Zhen Lei 2020-09-24 122 int ret, nrirqs, parent_irq, i;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 123 u32 reg;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 124
7cc4f309c933ec5 Jisheng Zhang 2024-06-14 125 if (!parent && IS_BUILTIN(CONFIG_DW_APB_ICTL)) {
54a38440b84f893 Zhen Lei 2020-09-24 126 /* Used as the primary interrupt controller */
54a38440b84f893 Zhen Lei 2020-09-24 127 parent_irq = 0;
54a38440b84f893 Zhen Lei 2020-09-24 128 domain_ops = &dw_apb_ictl_irq_domain_ops;
54a38440b84f893 Zhen Lei 2020-09-24 129 } else {
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 130 /* Map the parent interrupt for the chained handler */
d59f7d159891466 Zhen Lei 2020-09-24 131 parent_irq = irq_of_parse_and_map(np, 0);
d59f7d159891466 Zhen Lei 2020-09-24 132 if (parent_irq <= 0) {
e81f54c668d89e5 Rob Herring 2017-07-18 133 pr_err("%pOF: unable to parse irq\n", np);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 134 return -EINVAL;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 135 }
54a38440b84f893 Zhen Lei 2020-09-24 136 domain_ops = &irq_generic_chip_ops;
54a38440b84f893 Zhen Lei 2020-09-24 137 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 138
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 139 ret = of_address_to_resource(np, 0, &r);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 140 if (ret) {
e81f54c668d89e5 Rob Herring 2017-07-18 141 pr_err("%pOF: unable to get resource\n", np);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 142 return ret;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 143 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 144
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 145 if (!request_mem_region(r.start, resource_size(&r), np->full_name)) {
e81f54c668d89e5 Rob Herring 2017-07-18 146 pr_err("%pOF: unable to request mem region\n", np);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 147 return -ENOMEM;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 148 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 149
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 150 iobase = ioremap(r.start, resource_size(&r));
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 151 if (!iobase) {
e81f54c668d89e5 Rob Herring 2017-07-18 152 pr_err("%pOF: unable to map resource\n", np);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 153 ret = -ENOMEM;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 154 goto err_release;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 155 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 156
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 157 /*
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 158 * DW IP can be configured to allow 2-64 irqs. We can determine
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 159 * the number of irqs supported by writing into enable register
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 160 * and look for bits not set, as corresponding flip-flops will
c5f48c0a7aa1a8c Ingo Molnar 2018-12-03 161 * have been removed by synthesis tool.
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 162 */
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 163
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 164 /* mask and enable all interrupts */
8876ce7d1cbaca4 Jisheng Zhang 2014-11-12 165 writel_relaxed(~0, iobase + APB_INT_MASK_L);
8876ce7d1cbaca4 Jisheng Zhang 2014-11-12 166 writel_relaxed(~0, iobase + APB_INT_MASK_H);
8876ce7d1cbaca4 Jisheng Zhang 2014-11-12 167 writel_relaxed(~0, iobase + APB_INT_ENABLE_L);
8876ce7d1cbaca4 Jisheng Zhang 2014-11-12 168 writel_relaxed(~0, iobase + APB_INT_ENABLE_H);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 169
8876ce7d1cbaca4 Jisheng Zhang 2014-11-12 170 reg = readl_relaxed(iobase + APB_INT_ENABLE_H);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 171 if (reg)
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 172 nrirqs = 32 + fls(reg);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 173 else
8876ce7d1cbaca4 Jisheng Zhang 2014-11-12 174 nrirqs = fls(readl_relaxed(iobase + APB_INT_ENABLE_L));
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 175
d59f7d159891466 Zhen Lei 2020-09-24 176 domain = irq_domain_add_linear(np, nrirqs, domain_ops, NULL);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 177 if (!domain) {
e81f54c668d89e5 Rob Herring 2017-07-18 178 pr_err("%pOF: unable to add irq domain\n", np);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 179 ret = -ENOMEM;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 180 goto err_unmap;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 181 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 182
b66231183a8542d Thomas Gleixner 2015-07-06 183 ret = irq_alloc_domain_generic_chips(domain, 32, 1, np->name,
b66231183a8542d Thomas Gleixner 2015-07-06 184 handle_level_irq, clr, 0,
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 185 IRQ_GC_INIT_MASK_CACHE);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 186 if (ret) {
e81f54c668d89e5 Rob Herring 2017-07-18 187 pr_err("%pOF: unable to alloc irq domain gc\n", np);
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 188 goto err_unmap;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 189 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 190
b66231183a8542d Thomas Gleixner 2015-07-06 191 for (i = 0; i < DIV_ROUND_UP(nrirqs, 32); i++) {
b66231183a8542d Thomas Gleixner 2015-07-06 192 gc = irq_get_domain_generic_chip(domain, i * 32);
b66231183a8542d Thomas Gleixner 2015-07-06 193 gc->reg_base = iobase + i * APB_INT_BASE_OFFSET;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 194 gc->chip_types[0].regs.mask = APB_INT_MASK_L;
1655b0530d9502e Jisheng Zhang 2014-11-12 195 gc->chip_types[0].regs.enable = APB_INT_ENABLE_L;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 196 gc->chip_types[0].chip.irq_mask = irq_gc_mask_set_bit;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 197 gc->chip_types[0].chip.irq_unmask = irq_gc_mask_clr_bit;
1655b0530d9502e Jisheng Zhang 2014-11-12 198 gc->chip_types[0].chip.irq_resume = dw_apb_ictl_resume;
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 199 }
350d71b94fc9ed4 Sebastian Hesselbarth 2013-09-09 200
54a38440b84f893 Zhen Lei 2020-09-24 201 if (parent_irq) {
d59f7d159891466 Zhen Lei 2020-09-24 202 irq_set_chained_handler_and_data(parent_irq,
d59f7d159891466 Zhen Lei 2020-09-24 203 dw_apb_ictl_handle_irq_cascaded, domain);
54a38440b84f893 Zhen Lei 2020-09-24 204 } else {
54a38440b84f893 Zhen Lei 2020-09-24 205 dw_apb_ictl_irq_domain = domain;
54a38440b84f893 Zhen Lei 2020-09-24 @206 set_handle_irq(dw_apb_ictl_handle_irq);
:::::: The code at line 33 was first introduced by commit
:::::: 54a38440b84f8933b555c23273deca6a396f6708 irqchip/dw-apb-ictl: Add primary interrupt controller support
:::::: TO: Zhen Lei <thunder.leizhen@huawei.com>
:::::: CC: Marc Zyngier <maz@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-06-24 19:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 19:20 [tip:irq/core 41/49] drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.