From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Ma Ke <make24@iscas.ac.cn>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>, Lee Jones <lee@kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
Neal Liu <neal_liu@aspeedtech.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc
Date: Tue, 25 Jun 2024 16:30:24 +0200 [thread overview]
Message-ID: <2024062532-strep-president-44d7@gregkh> (raw)
In-Reply-To: <ff2aaf0d-5456-43d1-af52-78986b3401f9@web.de>
On Tue, Jun 25, 2024 at 02:50:25PM +0200, Markus Elfring wrote:
> >>> We should verify the bound of the array to assure that host
> >>> may not manipulate the index to point past endpoint array.
> >>
> >> Why did you not choose an imperative wording for your change description?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
> >
> > Markus, please stop reviewing USB patches. This is not helpful at all,
> > and causes new developers extra work for no reason at all.
>
> How does this feedback fit to the linked information source?
That is not what I wrote.
I wrote, "Please stop reviewing USB patches."
Please stop now.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc
Date: Tue, 25 Jun 2024 16:30:24 +0200 [thread overview]
Message-ID: <2024062532-strep-president-44d7@gregkh> (raw)
In-Reply-To: <ff2aaf0d-5456-43d1-af52-78986b3401f9@web.de>
On Tue, Jun 25, 2024 at 02:50:25PM +0200, Markus Elfring wrote:
> >>> We should verify the bound of the array to assure that host
> >>> may not manipulate the index to point past endpoint array.
> >>
> >> Why did you not choose an imperative wording for your change description?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
> >
> > Markus, please stop reviewing USB patches. This is not helpful at all,
> > and causes new developers extra work for no reason at all.
>
> How does this feedback fit to the linked information source?
That is not what I wrote.
I wrote, "Please stop reviewing USB patches."
Please stop now.
greg k-h
next prev parent reply other threads:[~2024-06-25 14:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 2:23 [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Ma Ke
2024-06-25 2:23 ` Ma Ke
2024-06-25 12:00 ` Markus Elfring
2024-06-25 12:00 ` Markus Elfring
2024-06-25 12:29 ` Greg Kroah-Hartman
2024-06-25 12:29 ` Greg Kroah-Hartman
2024-06-25 12:30 ` Greg Kroah-Hartman
2024-06-25 12:30 ` Greg Kroah-Hartman
2024-06-25 12:50 ` Markus Elfring
2024-06-25 12:50 ` Markus Elfring
2024-06-25 14:30 ` Greg Kroah-Hartman [this message]
2024-06-25 14:30 ` Greg Kroah-Hartman
2024-06-25 15:20 ` Markus Elfring
2024-06-25 15:20 ` Markus Elfring
2024-06-25 15:25 ` Greg Kroah-Hartman
2024-06-25 15:25 ` Greg Kroah-Hartman
2024-06-25 16:12 ` [v4] " Markus Elfring
2024-06-25 16:12 ` Markus Elfring
2024-06-26 8:55 ` [RFC] usb: Patch review processes? Markus Elfring
2024-06-26 8:55 ` Markus Elfring
2024-06-26 0:07 ` [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Andrew Jeffery
2024-06-26 0:07 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024062532-strep-president-44d7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=andrew@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=neal_liu@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.