From: Oleg Nesterov <oleg@redhat.com>
To: Dev Jain <dev.jain@arm.com>
Cc: shuah@kernel.org, mingo@kernel.org, tglx@linutronix.de,
mark.rutland@arm.com, ryan.roberts@arm.com, broonie@kernel.org,
suzuki.poulose@arm.com, Anshuman.Khandual@arm.com,
DeepakKumar.Mishra@arm.com, aneesh.kumar@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] selftests: Add a test mangling with uc_sigmask
Date: Wed, 26 Jun 2024 13:54:32 +0200 [thread overview]
Message-ID: <20240626115410.GA27271@redhat.com> (raw)
In-Reply-To: <20240626054847.1463889-3-dev.jain@arm.com>
On 06/26, Dev Jain wrote:
>
> +int main(int argc, char *argv[])
> +{
> + struct sigaction act, act2;
> + sigset_t *set, *oldset;
...
> + set = malloc(sizeof(sigset_t *));
> + if (!set)
> + ksft_exit_fail_perror("malloc");
> +
> + oldset = malloc(sizeof(sigset_t *));
Why malloc() ?
Can't you simply do
sigset_t set, oldset;
and then use sigemptyset(&set) / etc ?
Oleg.
next prev parent reply other threads:[~2024-06-26 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 5:48 [PATCH v3 0/2] Add test to distinguish between thread's signal mask and ucontext_t Dev Jain
2024-06-26 5:48 ` [PATCH v3 1/2] selftests: Rename sigaltstack to generic signal Dev Jain
2024-06-26 5:48 ` [PATCH v3 2/2] selftests: Add a test mangling with uc_sigmask Dev Jain
2024-06-26 11:54 ` Oleg Nesterov [this message]
2024-06-26 13:36 ` Dev Jain
2024-06-26 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626115410.GA27271@redhat.com \
--to=oleg@redhat.com \
--cc=Anshuman.Khandual@arm.com \
--cc=DeepakKumar.Mishra@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=broonie@kernel.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.