From: kernel test robot <lkp@intel.com>
To: Raphael Gallais-Pou <rgallaispou@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] thermal: sti: depend on THERMAL_OF subsystem
Date: Thu, 27 Jun 2024 05:58:25 +0800 [thread overview]
Message-ID: <202406270530.kN5wIswi-lkp@intel.com> (raw)
In-Reply-To: <20240625-thermal-v2-2-bf8354ed51ee@gmail.com>
Hi Raphael,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed]
url: https://github.com/intel-lab-lkp/linux/commits/Raphael-Gallais-Pou/thermal-st-switch-from-CONFIG_PM_SLEEP-guards-to-pm_sleep_ptr/20240626-090203
base: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
patch link: https://lore.kernel.org/r/20240625-thermal-v2-2-bf8354ed51ee%40gmail.com
patch subject: [PATCH v2 2/3] thermal: sti: depend on THERMAL_OF subsystem
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20240627/202406270530.kN5wIswi-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240627/202406270530.kN5wIswi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406270530.kN5wIswi-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/thermal/st/st_thermal.c: In function 'st_thermal_register':
>> drivers/thermal/st/st_thermal.c:147:13: warning: variable 'polling_delay' set but not used [-Wunused-but-set-variable]
147 | int polling_delay;
| ^~~~~~~~~~~~~
vim +/polling_delay +147 drivers/thermal/st/st_thermal.c
60aef7ce455653 Lee Jones 2014-06-05 138
60aef7ce455653 Lee Jones 2014-06-05 139 int st_thermal_register(struct platform_device *pdev,
60aef7ce455653 Lee Jones 2014-06-05 140 const struct of_device_id *st_thermal_of_match)
60aef7ce455653 Lee Jones 2014-06-05 141 {
60aef7ce455653 Lee Jones 2014-06-05 142 struct st_thermal_sensor *sensor;
60aef7ce455653 Lee Jones 2014-06-05 143 struct device *dev = &pdev->dev;
60aef7ce455653 Lee Jones 2014-06-05 144 struct device_node *np = dev->of_node;
60aef7ce455653 Lee Jones 2014-06-05 145 const struct of_device_id *match;
60aef7ce455653 Lee Jones 2014-06-05 146
60aef7ce455653 Lee Jones 2014-06-05 @147 int polling_delay;
60aef7ce455653 Lee Jones 2014-06-05 148 int ret;
60aef7ce455653 Lee Jones 2014-06-05 149
60aef7ce455653 Lee Jones 2014-06-05 150 if (!np) {
60aef7ce455653 Lee Jones 2014-06-05 151 dev_err(dev, "device tree node not found\n");
60aef7ce455653 Lee Jones 2014-06-05 152 return -EINVAL;
60aef7ce455653 Lee Jones 2014-06-05 153 }
60aef7ce455653 Lee Jones 2014-06-05 154
60aef7ce455653 Lee Jones 2014-06-05 155 sensor = devm_kzalloc(dev, sizeof(*sensor), GFP_KERNEL);
60aef7ce455653 Lee Jones 2014-06-05 156 if (!sensor)
60aef7ce455653 Lee Jones 2014-06-05 157 return -ENOMEM;
60aef7ce455653 Lee Jones 2014-06-05 158
60aef7ce455653 Lee Jones 2014-06-05 159 sensor->dev = dev;
60aef7ce455653 Lee Jones 2014-06-05 160
60aef7ce455653 Lee Jones 2014-06-05 161 match = of_match_device(st_thermal_of_match, dev);
60aef7ce455653 Lee Jones 2014-06-05 162 if (!(match && match->data))
60aef7ce455653 Lee Jones 2014-06-05 163 return -EINVAL;
60aef7ce455653 Lee Jones 2014-06-05 164
60aef7ce455653 Lee Jones 2014-06-05 165 sensor->cdata = match->data;
60aef7ce455653 Lee Jones 2014-06-05 166 if (!sensor->cdata->ops)
60aef7ce455653 Lee Jones 2014-06-05 167 return -EINVAL;
60aef7ce455653 Lee Jones 2014-06-05 168
60aef7ce455653 Lee Jones 2014-06-05 169 sensor->ops = sensor->cdata->ops;
60aef7ce455653 Lee Jones 2014-06-05 170
331a5fc9f2ed28 Nicolas Boichat 2015-07-08 171 ret = (sensor->ops->regmap_init)(sensor);
60aef7ce455653 Lee Jones 2014-06-05 172 if (ret)
60aef7ce455653 Lee Jones 2014-06-05 173 return ret;
60aef7ce455653 Lee Jones 2014-06-05 174
60aef7ce455653 Lee Jones 2014-06-05 175 ret = st_thermal_alloc_regfields(sensor);
60aef7ce455653 Lee Jones 2014-06-05 176 if (ret)
60aef7ce455653 Lee Jones 2014-06-05 177 return ret;
60aef7ce455653 Lee Jones 2014-06-05 178
60aef7ce455653 Lee Jones 2014-06-05 179 sensor->clk = devm_clk_get(dev, "thermal");
60aef7ce455653 Lee Jones 2014-06-05 180 if (IS_ERR(sensor->clk)) {
60aef7ce455653 Lee Jones 2014-06-05 181 dev_err(dev, "failed to fetch clock\n");
60aef7ce455653 Lee Jones 2014-06-05 182 return PTR_ERR(sensor->clk);
60aef7ce455653 Lee Jones 2014-06-05 183 }
60aef7ce455653 Lee Jones 2014-06-05 184
60aef7ce455653 Lee Jones 2014-06-05 185 if (sensor->ops->register_enable_irq) {
60aef7ce455653 Lee Jones 2014-06-05 186 ret = sensor->ops->register_enable_irq(sensor);
60aef7ce455653 Lee Jones 2014-06-05 187 if (ret)
60aef7ce455653 Lee Jones 2014-06-05 188 return ret;
60aef7ce455653 Lee Jones 2014-06-05 189 }
60aef7ce455653 Lee Jones 2014-06-05 190
60aef7ce455653 Lee Jones 2014-06-05 191 ret = st_thermal_sensor_on(sensor);
60aef7ce455653 Lee Jones 2014-06-05 192 if (ret)
60aef7ce455653 Lee Jones 2014-06-05 193 return ret;
60aef7ce455653 Lee Jones 2014-06-05 194
60aef7ce455653 Lee Jones 2014-06-05 195 ret = st_thermal_calibration(sensor);
60aef7ce455653 Lee Jones 2014-06-05 196 if (ret)
60aef7ce455653 Lee Jones 2014-06-05 197 goto sensor_off;
60aef7ce455653 Lee Jones 2014-06-05 198
60aef7ce455653 Lee Jones 2014-06-05 199 polling_delay = sensor->ops->register_enable_irq ? 0 : 1000;
60aef7ce455653 Lee Jones 2014-06-05 200
60aef7ce455653 Lee Jones 2014-06-05 201 sensor->thermal_dev =
9819ef601045bf Raphael Gallais-Pou 2024-06-25 202 devm_thermal_of_zone_register(dev, 0, sensor, &st_tz_ops);
60aef7ce455653 Lee Jones 2014-06-05 203 if (IS_ERR(sensor->thermal_dev)) {
9819ef601045bf Raphael Gallais-Pou 2024-06-25 204 dev_err(dev, "failed to register thermal of zone\n");
60aef7ce455653 Lee Jones 2014-06-05 205 ret = PTR_ERR(sensor->thermal_dev);
60aef7ce455653 Lee Jones 2014-06-05 206 goto sensor_off;
60aef7ce455653 Lee Jones 2014-06-05 207 }
60aef7ce455653 Lee Jones 2014-06-05 208
60aef7ce455653 Lee Jones 2014-06-05 209 platform_set_drvdata(pdev, sensor);
60aef7ce455653 Lee Jones 2014-06-05 210
9819ef601045bf Raphael Gallais-Pou 2024-06-25 211 /*
9819ef601045bf Raphael Gallais-Pou 2024-06-25 212 * devm_thermal_of_zone_register() doesn't enable hwmon by default
9819ef601045bf Raphael Gallais-Pou 2024-06-25 213 * Enable it here
9819ef601045bf Raphael Gallais-Pou 2024-06-25 214 */
9819ef601045bf Raphael Gallais-Pou 2024-06-25 215 return devm_thermal_add_hwmon_sysfs(dev, sensor->thermal_dev);
60aef7ce455653 Lee Jones 2014-06-05 216
60aef7ce455653 Lee Jones 2014-06-05 217 sensor_off:
60aef7ce455653 Lee Jones 2014-06-05 218 st_thermal_sensor_off(sensor);
60aef7ce455653 Lee Jones 2014-06-05 219
60aef7ce455653 Lee Jones 2014-06-05 220 return ret;
60aef7ce455653 Lee Jones 2014-06-05 221 }
60aef7ce455653 Lee Jones 2014-06-05 222 EXPORT_SYMBOL_GPL(st_thermal_register);
60aef7ce455653 Lee Jones 2014-06-05 223
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-26 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 21:32 [PATCH v2 0/3] Add thermal management support for STi platform Raphael Gallais-Pou
2024-06-25 21:32 ` [PATCH v2 1/3] thermal: st: switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Raphael Gallais-Pou
2024-06-25 21:32 ` [PATCH v2 2/3] thermal: sti: depend on THERMAL_OF subsystem Raphael Gallais-Pou
2024-06-26 21:58 ` kernel test robot [this message]
2024-06-26 23:06 ` kernel test robot
2024-06-25 21:32 ` [PATCH v2 3/3] ARM: dts: sti: add thermal-zones support on stih418 Raphael Gallais-Pou
2024-06-27 8:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406270530.kN5wIswi-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lukasz.luba@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=patrice.chotard@foss.st.com \
--cc=rafael@kernel.org \
--cc=rgallaispou@gmail.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.