From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, ankita@nvidia.com,
marcel.apfelbaum@gmail.com, philmd@linaro.org,
Richard Henderson <richard.henderson@linaro.org>,
linuxarm@huawei.com, Dave Jiang <dave.jiang@intel.com>,
Huang Ying <ying.huang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
eduardo@habkost.net, linux-cxl@vger.kernel.org,
Michael Roth <michael.roth@amd.com>,
Ani Sinha <anisinha@redhat.com>
Subject: Re: [PATCH v3 03/11] hw/acpi: Move AML building code for Generic Initiators to aml_build.c
Date: Thu, 27 Jun 2024 08:44:14 -0400 [thread overview]
Message-ID: <20240627084356-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240627144244.27473a32@imammedo.users.ipa.redhat.com>
On Thu, Jun 27, 2024 at 02:42:44PM +0200, Igor Mammedov wrote:
> On Thu, 20 Jun 2024 17:03:11 +0100
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
>
> > Rather than attempting to create a generic function with mess of the two
> > different device handle types, use a PCI handle specific variant. If the
> > ACPI handle form is needed then that can be introduced alongside this
> > with little duplicated code.
> >
> > Drop the PCIDeviceHandle in favor of just passing the bus, devfn
> > and segment directly. devfn kept as a single byte because ARI means
> > that in cases this is just an 8 bit function number.
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Link: https://lore.kernel.org/qemu-devel/20240618142333.102be976@imammedo.users.ipa.redhat.com/
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> with typo fixed
typo being "in cases"?
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
next prev parent reply other threads:[~2024-06-27 12:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 16:03 [PATCH v3 qemu 00/11] acpi: NUMA nodes for CXL HB as GP + complex NUMA test Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-20 16:03 ` [PATCH v3 01/11] hw/acpi: Fix ordering of BDF in Generic Initiator PCI Device Handle Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 12:44 ` Igor Mammedov
2024-06-20 16:03 ` [PATCH v3 02/11] hw/acpi/GI: Fix trivial parameter alignment issue Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 12:43 ` Igor Mammedov
2024-06-20 16:03 ` [PATCH v3 03/11] hw/acpi: Move AML building code for Generic Initiators to aml_build.c Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 12:42 ` Igor Mammedov
2024-06-27 12:44 ` Michael S. Tsirkin [this message]
2024-06-27 12:45 ` Igor Mammedov
2024-06-20 16:03 ` [PATCH v3 04/11] hw/acpi: Rename build_all_acpi_generic_initiators() to build_acpi_generic_initiator() Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 12:56 ` Igor Mammedov
2024-06-20 16:03 ` [PATCH v3 05/11] hw/pci: Add a bus property to pci_props and use for acpi/gi Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 13:09 ` Igor Mammedov
2024-06-28 11:58 ` Igor Mammedov
2024-07-01 15:59 ` Jonathan Cameron
2024-07-01 15:59 ` Jonathan Cameron via
2024-06-20 16:03 ` [PATCH v3 06/11] acpi/pci: Move Generic Initiator object handling into acpi/pci.* Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-20 16:03 ` [PATCH v3 07/11] hw/pci-bridge: Add acpi_uid property to CXL PXB Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 13:27 ` Igor Mammedov
2024-06-27 13:46 ` Jonathan Cameron
2024-06-27 13:46 ` Jonathan Cameron via
2024-06-28 11:55 ` Igor Mammedov
2024-07-01 17:52 ` Jonathan Cameron
2024-07-01 17:52 ` Jonathan Cameron via
2024-07-02 10:41 ` Jonathan Cameron
2024-07-02 10:41 ` Jonathan Cameron via
2024-06-20 16:03 ` [PATCH v3 08/11] hw/acpi: Generic Port Affinity Structure support Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-07-01 8:52 ` Igor Mammedov
2024-07-01 15:47 ` Jonathan Cameron
2024-07-01 15:47 ` Jonathan Cameron via
2024-06-20 16:03 ` [PATCH v3 09/11] bios-tables-test: Allow for new acpihmat-generic-x test data Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-27 12:51 ` Igor Mammedov
2024-06-27 13:50 ` Igor Mammedov
2024-06-20 16:03 ` [PATCH v3 10/11] bios-tables-test: Add complex SRAT / HMAT test for GI GP Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-20 16:03 ` [PATCH v3 11/11] bios-tables-test: Add data for complex numa test (GI, GP etc) Jonathan Cameron
2024-06-20 16:03 ` Jonathan Cameron via
2024-06-21 3:25 ` [PATCH v3 qemu 00/11] acpi: NUMA nodes for CXL HB as GP + complex NUMA test Huang, Ying
2024-06-21 16:20 ` Jonathan Cameron
2024-06-21 16:20 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627084356-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=ankita@nvidia.com \
--cc=armbru@redhat.com \
--cc=dave.jiang@intel.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.