[PATCH v3 0/2] Add documentation for PA_STATS and MAINTAINERS entry for ti,pruss.yaml

[PATCH v3 0/2] Add documentation for PA_STATS and MAINTAINERS entry for ti,pruss.yaml

[MD Danish Anwar]

Hi,

This series adds documentation for PA_STATS in dt-bindings file ti,pruss.yaml.
This bindings file doesn't have a MAINTAINERS entry. This series add the
MAINTAINERS entry for this file as well.

Changes since v2:
*) Added RB tag of Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to
   patch 2/2
*) Added patch 1/2 to the series as the binding file is orphan.

v2 https://lore.kernel.org/all/20240529115149.630273-1-danishanwar@ti.com/

MD Danish Anwar (2):
  MAINTAINERS: Add entry for ti,pruss.yaml to TI KEYSTONE MULTICORE
    NAVIGATOR DRIVERS
  dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 21 insertions(+)


base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371
-- 
2.34.1

[PATCH v3 1/2] MAINTAINERS: Add entry for ti,pruss.yaml to TI KEYSTONE MULTICORE NAVIGATOR DRIVERS

[MD Danish Anwar]

Currently there is no entry for
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml file. The driver
file corresponding to this binding file is drivers/soc/ti/pruss.c which
is maintained in TI KEYSTONE MULTICORE NAVIGATOR DRIVERS. Add the
binding file also to the same section so that this could be maintained.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 77008faf25ee..cc4731bbc655 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22759,6 +22759,7 @@ L:	linux-kernel@vger.kernel.org
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
+F:	Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
 F:	drivers/pmdomain/ti/omap_prm.c
 F:	drivers/soc/ti/*
 
-- 
2.34.1

[PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

Add documentation for pa-stats node which is syscon regmap for
PA_STATS registers. This will be used to dump statistics maintained by
ICSSG firmware.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index c402cb2928e8..3cb1471cc6b6 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -278,6 +278,26 @@ patternProperties:
 
     additionalProperties: false
 
+  ^pa-stats@[a-f0-9]+$:
+    description: |
+      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
+      registers where different statistics related to ICSSG, are dumped by
+      ICSSG firmware. This syscon sub-module will help the device to
+      access/read/write those statistics.
+
+    type: object
+
+    additionalProperties: false
+
+    properties:
+      compatible:
+        items:
+          - const: ti,pruss-pa-st
+          - const: syscon
+
+      reg:
+        maxItems: 1
+
   interrupt-controller@[a-f0-9]+$:
     description: |
       PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
-- 
2.34.1

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Nishanth Menon]

On 21:03-20240625, MD Danish Anwar wrote:
> Add documentation for pa-stats node which is syscon regmap for
> PA_STATS registers. This will be used to dump statistics maintained by
> ICSSG firmware.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index c402cb2928e8..3cb1471cc6b6 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -278,6 +278,26 @@ patternProperties:
>  
>      additionalProperties: false
>  
> +  ^pa-stats@[a-f0-9]+$:
> +    description: |
> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
> +      registers where different statistics related to ICSSG, are dumped by
> +      ICSSG firmware. This syscon sub-module will help the device to
> +      access/read/write those statistics.
> +
> +    type: object
> +
> +    additionalProperties: false
> +
> +    properties:
> +      compatible:
> +        items:
> +          - const: ti,pruss-pa-st
> +          - const: syscon
> +
> +      reg:
> +        maxItems: 1
> +

Is this a patch in a driver series? I do not see the driver part..
if this is a memory map, why doesn't bus model work?


>    interrupt-controller@[a-f0-9]+$:
>      description: |
>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Nishanth Menon]

On 21:03-20240625, MD Danish Anwar wrote:
> Add documentation for pa-stats node which is syscon regmap for
> PA_STATS registers. This will be used to dump statistics maintained by
> ICSSG firmware.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index c402cb2928e8..3cb1471cc6b6 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -278,6 +278,26 @@ patternProperties:
>  
>      additionalProperties: false
>  
> +  ^pa-stats@[a-f0-9]+$:
> +    description: |
> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
> +      registers where different statistics related to ICSSG, are dumped by
> +      ICSSG firmware. This syscon sub-module will help the device to
> +      access/read/write those statistics.
> +
> +    type: object
> +
> +    additionalProperties: false
> +
> +    properties:
> +      compatible:
> +        items:
> +          - const: ti,pruss-pa-st
> +          - const: syscon
> +
> +      reg:
> +        maxItems: 1
> +

Is this a patch in a driver series? I do not see the driver part..
if this is a memory map, why doesn't bus model work?


>    interrupt-controller@[a-f0-9]+$:
>      description: |
>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

On 27/06/24 8:15 pm, Nishanth Menon wrote:
> On 21:03-20240625, MD Danish Anwar wrote:
>> Add documentation for pa-stats node which is syscon regmap for
>> PA_STATS registers. This will be used to dump statistics maintained by
>> ICSSG firmware.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> index c402cb2928e8..3cb1471cc6b6 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> @@ -278,6 +278,26 @@ patternProperties:
>>  
>>      additionalProperties: false
>>  
>> +  ^pa-stats@[a-f0-9]+$:
>> +    description: |
>> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
>> +      registers where different statistics related to ICSSG, are dumped by
>> +      ICSSG firmware. This syscon sub-module will help the device to
>> +      access/read/write those statistics.
>> +
>> +    type: object
>> +
>> +    additionalProperties: false
>> +
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: ti,pruss-pa-st
>> +          - const: syscon
>> +
>> +      reg:
>> +        maxItems: 1
>> +
> 
> Is this a patch in a driver series? I do not see the driver part..

No Nishant, this is not a part of driver series. This binding patch is
related to [1] which is merged to net-next. The regmap will not be used
by drivers/soc/ti driver instead once both binding are in, the driver
changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
as there is no driver changes needed in drivers/soc/ti, I posted this
patch as stand alone. Considering this binding and [1] they both go to
different tree, I decided to get the bindings in first and in next
kernel cycle when they both are part of mainline linux, I can post the
driver changes.

> if this is a memory map, why doesn't bus model work?
> 

I am just trying to maintain consistency here. pa-stats sub-module is
similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
mii-g-rt and mii-rt.

All these three modules are eventually mapping a memory region so that
the icssg driver can use them and read / configure registers.

> 
>>    interrupt-controller@[a-f0-9]+$:
>>      description: |
>>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
>> -- 
>> 2.34.1
>>
> 

[1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/

-- 
Thanks and Regards,
Danish

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

On 27/06/24 8:15 pm, Nishanth Menon wrote:
> On 21:03-20240625, MD Danish Anwar wrote:
>> Add documentation for pa-stats node which is syscon regmap for
>> PA_STATS registers. This will be used to dump statistics maintained by
>> ICSSG firmware.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> index c402cb2928e8..3cb1471cc6b6 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> @@ -278,6 +278,26 @@ patternProperties:
>>  
>>      additionalProperties: false
>>  
>> +  ^pa-stats@[a-f0-9]+$:
>> +    description: |
>> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
>> +      registers where different statistics related to ICSSG, are dumped by
>> +      ICSSG firmware. This syscon sub-module will help the device to
>> +      access/read/write those statistics.
>> +
>> +    type: object
>> +
>> +    additionalProperties: false
>> +
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: ti,pruss-pa-st
>> +          - const: syscon
>> +
>> +      reg:
>> +        maxItems: 1
>> +
> 
> Is this a patch in a driver series? I do not see the driver part..

No Nishant, this is not a part of driver series. This binding patch is
related to [1] which is merged to net-next. The regmap will not be used
by drivers/soc/ti driver instead once both binding are in, the driver
changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
as there is no driver changes needed in drivers/soc/ti, I posted this
patch as stand alone. Considering this binding and [1] they both go to
different tree, I decided to get the bindings in first and in next
kernel cycle when they both are part of mainline linux, I can post the
driver changes.

> if this is a memory map, why doesn't bus model work?
> 

I am just trying to maintain consistency here. pa-stats sub-module is
similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
mii-g-rt and mii-rt.

All these three modules are eventually mapping a memory region so that
the icssg driver can use them and read / configure registers.

> 
>>    interrupt-controller@[a-f0-9]+$:
>>      description: |
>>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
>> -- 
>> 2.34.1
>>
> 

[1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/

-- 
Thanks and Regards,
Danish

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Nishanth Menon]

On 10:56-20240628, MD Danish Anwar wrote:
> 
> 
> On 27/06/24 8:15 pm, Nishanth Menon wrote:
> > On 21:03-20240625, MD Danish Anwar wrote:
> >> Add documentation for pa-stats node which is syscon regmap for
> >> PA_STATS registers. This will be used to dump statistics maintained by
> >> ICSSG firmware.
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> >> ---
> >>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> index c402cb2928e8..3cb1471cc6b6 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> @@ -278,6 +278,26 @@ patternProperties:
> >>  
> >>      additionalProperties: false
> >>  
> >> +  ^pa-stats@[a-f0-9]+$:
> >> +    description: |
> >> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
> >> +      registers where different statistics related to ICSSG, are dumped by
> >> +      ICSSG firmware. This syscon sub-module will help the device to
> >> +      access/read/write those statistics.
> >> +
> >> +    type: object
> >> +
> >> +    additionalProperties: false
> >> +
> >> +    properties:
> >> +      compatible:
> >> +        items:
> >> +          - const: ti,pruss-pa-st
> >> +          - const: syscon
> >> +
> >> +      reg:
> >> +        maxItems: 1
> >> +
> > 
> > Is this a patch in a driver series? I do not see the driver part..
> 
> No Nishant, this is not a part of driver series. This binding patch is
> related to [1] which is merged to net-next. The regmap will not be used
> by drivers/soc/ti driver instead once both binding are in, the driver
> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
> as there is no driver changes needed in drivers/soc/ti, I posted this
> patch as stand alone. Considering this binding and [1] they both go to
> different tree, I decided to get the bindings in first and in next
> kernel cycle when they both are part of mainline linux, I can post the
> driver changes.

This is indicating some strong coupling that is sounding a bit
suspicious. Please add in the full series so that folks can see the
inter dependencies.

> 
> > if this is a memory map, why doesn't bus model work?
> > 
> 
> I am just trying to maintain consistency here. pa-stats sub-module is
> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
> mii-g-rt and mii-rt.
> 
> All these three modules are eventually mapping a memory region so that
> the icssg driver can use them and read / configure registers.

Sounds like mapping a bus is more appropriate? I dont seem to see it
though.

> 
> > 
> >>    interrupt-controller@[a-f0-9]+$:
> >>      description: |
> >>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
> >> -- 
> >> 2.34.1
> >>
> > 
> 
> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
> 
> -- 
> Thanks and Regards,
> Danish

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[Nishanth Menon]

On 10:56-20240628, MD Danish Anwar wrote:
> 
> 
> On 27/06/24 8:15 pm, Nishanth Menon wrote:
> > On 21:03-20240625, MD Danish Anwar wrote:
> >> Add documentation for pa-stats node which is syscon regmap for
> >> PA_STATS registers. This will be used to dump statistics maintained by
> >> ICSSG firmware.
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> >> ---
> >>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> index c402cb2928e8..3cb1471cc6b6 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> @@ -278,6 +278,26 @@ patternProperties:
> >>  
> >>      additionalProperties: false
> >>  
> >> +  ^pa-stats@[a-f0-9]+$:
> >> +    description: |
> >> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
> >> +      registers where different statistics related to ICSSG, are dumped by
> >> +      ICSSG firmware. This syscon sub-module will help the device to
> >> +      access/read/write those statistics.
> >> +
> >> +    type: object
> >> +
> >> +    additionalProperties: false
> >> +
> >> +    properties:
> >> +      compatible:
> >> +        items:
> >> +          - const: ti,pruss-pa-st
> >> +          - const: syscon
> >> +
> >> +      reg:
> >> +        maxItems: 1
> >> +
> > 
> > Is this a patch in a driver series? I do not see the driver part..
> 
> No Nishant, this is not a part of driver series. This binding patch is
> related to [1] which is merged to net-next. The regmap will not be used
> by drivers/soc/ti driver instead once both binding are in, the driver
> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
> as there is no driver changes needed in drivers/soc/ti, I posted this
> patch as stand alone. Considering this binding and [1] they both go to
> different tree, I decided to get the bindings in first and in next
> kernel cycle when they both are part of mainline linux, I can post the
> driver changes.

This is indicating some strong coupling that is sounding a bit
suspicious. Please add in the full series so that folks can see the
inter dependencies.

> 
> > if this is a memory map, why doesn't bus model work?
> > 
> 
> I am just trying to maintain consistency here. pa-stats sub-module is
> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
> mii-g-rt and mii-rt.
> 
> All these three modules are eventually mapping a memory region so that
> the icssg driver can use them and read / configure registers.

Sounds like mapping a bus is more appropriate? I dont seem to see it
though.

> 
> > 
> >>    interrupt-controller@[a-f0-9]+$:
> >>      description: |
> >>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
> >> -- 
> >> 2.34.1
> >>
> > 
> 
> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
> 
> -- 
> Thanks and Regards,
> Danish

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

On 28/06/24 12:04 pm, Nishanth Menon wrote:
> On 10:56-20240628, MD Danish Anwar wrote:
>>
>>
>> On 27/06/24 8:15 pm, Nishanth Menon wrote:
>>> On 21:03-20240625, MD Danish Anwar wrote:
>>>> Add documentation for pa-stats node which is syscon regmap for
>>>> PA_STATS registers. This will be used to dump statistics maintained by
>>>> ICSSG firmware.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>>>>  1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> index c402cb2928e8..3cb1471cc6b6 100644
>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> @@ -278,6 +278,26 @@ patternProperties:
>>>>  
>>>>      additionalProperties: false
>>>>  
>>>> +  ^pa-stats@[a-f0-9]+$:
>>>> +    description: |
>>>> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
>>>> +      registers where different statistics related to ICSSG, are dumped by
>>>> +      ICSSG firmware. This syscon sub-module will help the device to
>>>> +      access/read/write those statistics.
>>>> +
>>>> +    type: object
>>>> +
>>>> +    additionalProperties: false
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        items:
>>>> +          - const: ti,pruss-pa-st
>>>> +          - const: syscon
>>>> +
>>>> +      reg:
>>>> +        maxItems: 1
>>>> +
>>>
>>> Is this a patch in a driver series? I do not see the driver part..
>>
>> No Nishant, this is not a part of driver series. This binding patch is
>> related to [1] which is merged to net-next. The regmap will not be used
>> by drivers/soc/ti driver instead once both binding are in, the driver
>> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> as there is no driver changes needed in drivers/soc/ti, I posted this
>> patch as stand alone. Considering this binding and [1] they both go to
>> different tree, I decided to get the bindings in first and in next
>> kernel cycle when they both are part of mainline linux, I can post the
>> driver changes.
> 
> This is indicating some strong coupling that is sounding a bit
> suspicious. Please add in the full series so that folks can see the
> inter dependencies.
> 

The driver changes will be needed at later point. The PA-STATS registers
dump stats related to TSN / Frame Preemption features for ICSSG drivers.
The TSN support itself is still in progress for ICSSG driver and as a
result I have not added the driver change that uses this register maps
to read / write statistics.

For your reference, I will try to explain the dependency.

The pruss node (named icssg1 in k3-am64-main.dtsi) will have below,

icssg1_pa_stats: pa-stats@2c000 {
	compatible = "ti,pruss-pa-st", "syscon";
	reg = <0x2c000 0x1000>;
};

The icssg1-eth node in k3-am642-evm will have,

icssg1_eth: icssg1-eth {

	...
	...

	ti,pa-stats = <&icssg1_pa_stats>;

	...
	...
}

Now the driver icssg_prueth.c will have the below code in it's probe,

prueth->pa_stats = syscon_regmap_lookup_by_phandle(np, "ti,pa-stats");
if (IS_ERR(prueth->pa_stats)) {
	dev_err(dev, "couldn't get ti,pa-stats syscon regmap\n");
	return -ENODEV;
}

The driver can then use regmap_read / write on prueth->pa_stats regmap
do access those registers.

This approach is similar to 'mii-rt' and 'mii-g-rt' reg maps. They have
been implemented and currently used by the icssg_prueth.c driver. You
can have a look on them for your reference.

>>
>>> if this is a memory map, why doesn't bus model work?
>>>
>>
>> I am just trying to maintain consistency here. pa-stats sub-module is
>> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
>> mii-g-rt and mii-rt.
>>
>> All these three modules are eventually mapping a memory region so that
>> the icssg driver can use them and read / configure registers.
> 
> Sounds like mapping a bus is more appropriate? I dont seem to see it
> though.
> 
>>
>>>
>>>>    interrupt-controller@[a-f0-9]+$:
>>>>      description: |
>>>>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>
>> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
>>
>> -- 
>> Thanks and Regards,
>> Danish
> 

-- 
Thanks and Regards,
Danish

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

On 28/06/24 12:04 pm, Nishanth Menon wrote:
> On 10:56-20240628, MD Danish Anwar wrote:
>>
>>
>> On 27/06/24 8:15 pm, Nishanth Menon wrote:
>>> On 21:03-20240625, MD Danish Anwar wrote:
>>>> Add documentation for pa-stats node which is syscon regmap for
>>>> PA_STATS registers. This will be used to dump statistics maintained by
>>>> ICSSG firmware.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>>>>  1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> index c402cb2928e8..3cb1471cc6b6 100644
>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> @@ -278,6 +278,26 @@ patternProperties:
>>>>  
>>>>      additionalProperties: false
>>>>  
>>>> +  ^pa-stats@[a-f0-9]+$:
>>>> +    description: |
>>>> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
>>>> +      registers where different statistics related to ICSSG, are dumped by
>>>> +      ICSSG firmware. This syscon sub-module will help the device to
>>>> +      access/read/write those statistics.
>>>> +
>>>> +    type: object
>>>> +
>>>> +    additionalProperties: false
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        items:
>>>> +          - const: ti,pruss-pa-st
>>>> +          - const: syscon
>>>> +
>>>> +      reg:
>>>> +        maxItems: 1
>>>> +
>>>
>>> Is this a patch in a driver series? I do not see the driver part..
>>
>> No Nishant, this is not a part of driver series. This binding patch is
>> related to [1] which is merged to net-next. The regmap will not be used
>> by drivers/soc/ti driver instead once both binding are in, the driver
>> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> as there is no driver changes needed in drivers/soc/ti, I posted this
>> patch as stand alone. Considering this binding and [1] they both go to
>> different tree, I decided to get the bindings in first and in next
>> kernel cycle when they both are part of mainline linux, I can post the
>> driver changes.
> 
> This is indicating some strong coupling that is sounding a bit
> suspicious. Please add in the full series so that folks can see the
> inter dependencies.
> 

The driver changes will be needed at later point. The PA-STATS registers
dump stats related to TSN / Frame Preemption features for ICSSG drivers.
The TSN support itself is still in progress for ICSSG driver and as a
result I have not added the driver change that uses this register maps
to read / write statistics.

For your reference, I will try to explain the dependency.

The pruss node (named icssg1 in k3-am64-main.dtsi) will have below,

icssg1_pa_stats: pa-stats@2c000 {
	compatible = "ti,pruss-pa-st", "syscon";
	reg = <0x2c000 0x1000>;
};

The icssg1-eth node in k3-am642-evm will have,

icssg1_eth: icssg1-eth {

	...
	...

	ti,pa-stats = <&icssg1_pa_stats>;

	...
	...
}

Now the driver icssg_prueth.c will have the below code in it's probe,

prueth->pa_stats = syscon_regmap_lookup_by_phandle(np, "ti,pa-stats");
if (IS_ERR(prueth->pa_stats)) {
	dev_err(dev, "couldn't get ti,pa-stats syscon regmap\n");
	return -ENODEV;
}

The driver can then use regmap_read / write on prueth->pa_stats regmap
do access those registers.

This approach is similar to 'mii-rt' and 'mii-g-rt' reg maps. They have
been implemented and currently used by the icssg_prueth.c driver. You
can have a look on them for your reference.

>>
>>> if this is a memory map, why doesn't bus model work?
>>>
>>
>> I am just trying to maintain consistency here. pa-stats sub-module is
>> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
>> mii-g-rt and mii-rt.
>>
>> All these three modules are eventually mapping a memory region so that
>> the icssg driver can use them and read / configure registers.
> 
> Sounds like mapping a bus is more appropriate? I dont seem to see it
> though.
> 
>>
>>>
>>>>    interrupt-controller@[a-f0-9]+$:
>>>>      description: |
>>>>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>
>> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
>>
>> -- 
>> Thanks and Regards,
>> Danish
> 

-- 
Thanks and Regards,
Danish

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

Hi Nishant,

On 28/06/24 12:04 pm, Nishanth Menon wrote:
> On 10:56-20240628, MD Danish Anwar wrote:
>>
>>
>> On 27/06/24 8:15 pm, Nishanth Menon wrote:
>>> On 21:03-20240625, MD Danish Anwar wrote:
>>>> Add documentation for pa-stats node which is syscon regmap for
>>>> PA_STATS registers. This will be used to dump statistics maintained by
>>>> ICSSG firmware.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>>>>  1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> index c402cb2928e8..3cb1471cc6b6 100644
>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> @@ -278,6 +278,26 @@ patternProperties:
>>>>  
>>>>      additionalProperties: false
>>>>  
>>>> +  ^pa-stats@[a-f0-9]+$:
>>>> +    description: |
>>>> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
>>>> +      registers where different statistics related to ICSSG, are dumped by
>>>> +      ICSSG firmware. This syscon sub-module will help the device to
>>>> +      access/read/write those statistics.
>>>> +
>>>> +    type: object
>>>> +
>>>> +    additionalProperties: false
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        items:
>>>> +          - const: ti,pruss-pa-st
>>>> +          - const: syscon
>>>> +
>>>> +      reg:
>>>> +        maxItems: 1
>>>> +
>>>
>>> Is this a patch in a driver series? I do not see the driver part..
>>
>> No Nishant, this is not a part of driver series. This binding patch is
>> related to [1] which is merged to net-next. The regmap will not be used
>> by drivers/soc/ti driver instead once both binding are in, the driver
>> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> as there is no driver changes needed in drivers/soc/ti, I posted this
>> patch as stand alone. Considering this binding and [1] they both go to
>> different tree, I decided to get the bindings in first and in next
>> kernel cycle when they both are part of mainline linux, I can post the
>> driver changes.
> 
> This is indicating some strong coupling that is sounding a bit
> suspicious. Please add in the full series so that folks can see the
> inter dependencies.
> 

I have posted v4
https://lore.kernel.org/all/20240729113226.2905928-1-danishanwar@ti.com/
as full series containing both driver and device tree changes.

I have explained the dependencies in cover letter. Please have a look.

>>
>>> if this is a memory map, why doesn't bus model work?
>>>
>>
>> I am just trying to maintain consistency here. pa-stats sub-module is
>> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
>> mii-g-rt and mii-rt.
>>
>> All these three modules are eventually mapping a memory region so that
>> the icssg driver can use them and read / configure registers.
> 
> Sounds like mapping a bus is more appropriate? I dont seem to see it
> though.
> 
>>
>>>
>>>>    interrupt-controller@[a-f0-9]+$:
>>>>      description: |
>>>>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>
>> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
>>
>> -- 
>> Thanks and Regards,
>> Danish
> 

-- 
Thanks and Regards,
Danish

Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

Hi Nishant,

On 28/06/24 12:04 pm, Nishanth Menon wrote:
> On 10:56-20240628, MD Danish Anwar wrote:
>>
>>
>> On 27/06/24 8:15 pm, Nishanth Menon wrote:
>>> On 21:03-20240625, MD Danish Anwar wrote:
>>>> Add documentation for pa-stats node which is syscon regmap for
>>>> PA_STATS registers. This will be used to dump statistics maintained by
>>>> ICSSG firmware.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
>>>>  1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> index c402cb2928e8..3cb1471cc6b6 100644
>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> @@ -278,6 +278,26 @@ patternProperties:
>>>>  
>>>>      additionalProperties: false
>>>>  
>>>> +  ^pa-stats@[a-f0-9]+$:
>>>> +    description: |
>>>> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
>>>> +      registers where different statistics related to ICSSG, are dumped by
>>>> +      ICSSG firmware. This syscon sub-module will help the device to
>>>> +      access/read/write those statistics.
>>>> +
>>>> +    type: object
>>>> +
>>>> +    additionalProperties: false
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        items:
>>>> +          - const: ti,pruss-pa-st
>>>> +          - const: syscon
>>>> +
>>>> +      reg:
>>>> +        maxItems: 1
>>>> +
>>>
>>> Is this a patch in a driver series? I do not see the driver part..
>>
>> No Nishant, this is not a part of driver series. This binding patch is
>> related to [1] which is merged to net-next. The regmap will not be used
>> by drivers/soc/ti driver instead once both binding are in, the driver
>> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> as there is no driver changes needed in drivers/soc/ti, I posted this
>> patch as stand alone. Considering this binding and [1] they both go to
>> different tree, I decided to get the bindings in first and in next
>> kernel cycle when they both are part of mainline linux, I can post the
>> driver changes.
> 
> This is indicating some strong coupling that is sounding a bit
> suspicious. Please add in the full series so that folks can see the
> inter dependencies.
> 

I have posted v4
https://lore.kernel.org/all/20240729113226.2905928-1-danishanwar@ti.com/
as full series containing both driver and device tree changes.

I have explained the dependencies in cover letter. Please have a look.

>>
>>> if this is a memory map, why doesn't bus model work?
>>>
>>
>> I am just trying to maintain consistency here. pa-stats sub-module is
>> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
>> mii-g-rt and mii-rt.
>>
>> All these three modules are eventually mapping a memory region so that
>> the icssg driver can use them and read / configure registers.
> 
> Sounds like mapping a bus is more appropriate? I dont seem to see it
> though.
> 
>>
>>>
>>>>    interrupt-controller@[a-f0-9]+$:
>>>>      description: |
>>>>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>
>> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
>>
>> -- 
>> Thanks and Regards,
>> Danish
> 

-- 
Thanks and Regards,
Danish

[PATCH v3 0/2] Add documentation for PA_STATS and MAINTAINERS entry for ti,pruss.yaml

[MD Danish Anwar]

Hi,

This series adds documentation for PA_STATS in dt-bindings file ti,pruss.yaml.
This bindings file doesn't have a MAINTAINERS entry. This series add the
MAINTAINERS entry for this file as well.

Changes since v2:
*) Added RB tag of Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to
   patch 2/2
*) Added patch 1/2 to the series as the binding file is orphan.

v2 https://lore.kernel.org/all/20240529115149.630273-1-danishanwar@ti.com/

MD Danish Anwar (2):
  MAINTAINERS: Add entry for ti,pruss.yaml to TI KEYSTONE MULTICORE
    NAVIGATOR DRIVERS
  dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 21 insertions(+)


base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371
-- 
2.34.1

Re: [PATCH v3 0/2] Add documentation for PA_STATS and MAINTAINERS entry for ti,pruss.yaml

[Krzysztof Kozlowski]

On 25/06/2024 17:33, MD Danish Anwar wrote:
> Hi,
> 
> This series adds documentation for PA_STATS in dt-bindings file ti,pruss.yaml.
> This bindings file doesn't have a MAINTAINERS entry. This series add the
> MAINTAINERS entry for this file as well.
> 
> Changes since v2:
> *) Added RB tag of Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to
>    patch 2/2
> *) Added patch 1/2 to the series as the binding file is orphan.
> 
> v2 https://lore.kernel.org/all/20240529115149.630273-1-danishanwar@ti.com/

That's some duplicated posting.

Why you just can't use b4?

Best regards,
Krzysztof

Re: [PATCH v3 0/2] Add documentation for PA_STATS and MAINTAINERS entry for ti,pruss.yaml

[MD Danish Anwar]

On 26/06/24 2:29 pm, Krzysztof Kozlowski wrote:
> On 25/06/2024 17:33, MD Danish Anwar wrote:
>> Hi,
>>
>> This series adds documentation for PA_STATS in dt-bindings file ti,pruss.yaml.
>> This bindings file doesn't have a MAINTAINERS entry. This series add the
>> MAINTAINERS entry for this file as well.
>>
>> Changes since v2:
>> *) Added RB tag of Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to
>>    patch 2/2
>> *) Added patch 1/2 to the series as the binding file is orphan.
>>
>> v2 https://lore.kernel.org/all/20240529115149.630273-1-danishanwar@ti.com/
> 
> That's some duplicated posting.
> 
> Why you just can't use b4?
> 

My bad. The email got sent twice. Will keep this in mind.

> Best regards,
> Krzysztof
> 

-- 
Thanks and Regards,
Danish

[PATCH v3 1/2] MAINTAINERS: Add entry for ti,pruss.yaml to TI KEYSTONE MULTICORE NAVIGATOR DRIVERS

[MD Danish Anwar]

Currently there is no entry for
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml file. The driver
file corresponding to this binding file is drivers/soc/ti/pruss.c which
is maintained in TI KEYSTONE MULTICORE NAVIGATOR DRIVERS. Add the
binding file also to the same section so that this could be maintained.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 77008faf25ee..cc4731bbc655 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22759,6 +22759,7 @@ L:	linux-kernel@vger.kernel.org
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
+F:	Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
 F:	drivers/pmdomain/ti/omap_prm.c
 F:	drivers/soc/ti/*
 
-- 
2.34.1

[PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

[MD Danish Anwar]

Add documentation for pa-stats node which is syscon regmap for
PA_STATS registers. This will be used to dump statistics maintained by
ICSSG firmware.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index c402cb2928e8..3cb1471cc6b6 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -278,6 +278,26 @@ patternProperties:
 
     additionalProperties: false
 
+  ^pa-stats@[a-f0-9]+$:
+    description: |
+      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
+      registers where different statistics related to ICSSG, are dumped by
+      ICSSG firmware. This syscon sub-module will help the device to
+      access/read/write those statistics.
+
+    type: object
+
+    additionalProperties: false
+
+    properties:
+      compatible:
+        items:
+          - const: ti,pruss-pa-st
+          - const: syscon
+
+      reg:
+        maxItems: 1
+
   interrupt-controller@[a-f0-9]+$:
     description: |
       PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
-- 
2.34.1

Re: (subset) [PATCH v3 0/2] Add documentation for PA_STATS and MAINTAINERS entry for ti,pruss.yaml

[Nishanth Menon]

Hi MD Danish Anwar,

On Tue, 25 Jun 2024 21:03:14 +0530, MD Danish Anwar wrote:
> This series adds documentation for PA_STATS in dt-bindings file ti,pruss.yaml.
> This bindings file doesn't have a MAINTAINERS entry. This series add the
> MAINTAINERS entry for this file as well.
> 
> Changes since v2:
> *) Added RB tag of Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to
>    patch 2/2
> *) Added patch 1/2 to the series as the binding file is orphan.
> 
> [...]

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[1/2] MAINTAINERS: Add entry for ti,pruss.yaml to TI KEYSTONE MULTICORE NAVIGATOR DRIVERS
      commit: 13020adf6be9603ba71a9e269f130046dcea8cc8

I have left patch #2 to come with relevant driver changes as appropriate
rather than have to deal with a refactor of the binding at a later date.

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D