From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 6/6] ice: Remove unused members from switch API
Date: Fri, 28 Jun 2024 13:44:25 +0100 [thread overview]
Message-ID: <20240628124425.GE783093@kernel.org> (raw)
In-Reply-To: <20240618141157.1881093-7-marcin.szycik@linux.intel.com>
On Tue, Jun 18, 2024 at 04:11:57PM +0200, Marcin Szycik wrote:
> Remove several members of struct ice_sw_recipe and struct
> ice_prot_lkup_ext. Remove struct ice_recp_grp_entry and struct
> ice_pref_recipe_group, since they are now unused as well.
>
> All of the deleted members were only written to and never read, so it's
> pointless to keep them.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
michal.swiatkowski@linux.intel.com, przemyslaw.kitszel@intel.com
Subject: Re: [PATCH iwl-next 6/6] ice: Remove unused members from switch API
Date: Fri, 28 Jun 2024 13:44:25 +0100 [thread overview]
Message-ID: <20240628124425.GE783093@kernel.org> (raw)
In-Reply-To: <20240618141157.1881093-7-marcin.szycik@linux.intel.com>
On Tue, Jun 18, 2024 at 04:11:57PM +0200, Marcin Szycik wrote:
> Remove several members of struct ice_sw_recipe and struct
> ice_prot_lkup_ext. Remove struct ice_recp_grp_entry and struct
> ice_pref_recipe_group, since they are now unused as well.
>
> All of the deleted members were only written to and never read, so it's
> pointless to keep them.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-06-28 12:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:11 [Intel-wired-lan] [PATCH iwl-next 0/6] Switch API optimizations Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-18 14:11 ` [Intel-wired-lan] [PATCH iwl-next 1/6] ice: Remove unused struct ice_prot_lkup_ext members Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-28 12:40 ` [Intel-wired-lan] " Simon Horman
2024-06-28 12:40 ` Simon Horman
2024-06-18 14:11 ` [Intel-wired-lan] [PATCH iwl-next 2/6] ice: Remove reading all recipes before adding a new one Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-28 12:41 ` [Intel-wired-lan] " Simon Horman
2024-06-28 12:41 ` Simon Horman
2024-06-18 14:11 ` [Intel-wired-lan] [PATCH iwl-next 3/6] ice: Simplify bitmap setting in adding recipe Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-19 14:34 ` [Intel-wired-lan] " Alexander Lobakin
2024-06-19 14:34 ` Alexander Lobakin
2024-06-18 14:11 ` [Intel-wired-lan] [PATCH iwl-next 4/6] ice: remove unused recipe bookkeeping data Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-28 12:41 ` [Intel-wired-lan] " Simon Horman
2024-06-28 12:41 ` Simon Horman
2024-06-18 14:11 ` [Intel-wired-lan] [PATCH iwl-next 5/6] ice: Optimize switch recipe creation Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-28 12:44 ` [Intel-wired-lan] " Simon Horman
2024-06-28 12:44 ` Simon Horman
2024-06-28 13:39 ` [Intel-wired-lan] " Marcin Szycik
2024-06-28 13:39 ` Marcin Szycik
2024-06-28 18:22 ` Simon Horman
2024-06-28 18:22 ` Simon Horman
2024-06-28 13:56 ` Przemek Kitszel
2024-06-28 13:56 ` Przemek Kitszel
2024-06-28 18:25 ` [Intel-wired-lan] " Simon Horman
2024-06-28 18:25 ` Simon Horman
2024-06-18 14:11 ` [Intel-wired-lan] [PATCH iwl-next 6/6] ice: Remove unused members from switch API Marcin Szycik
2024-06-18 14:11 ` Marcin Szycik
2024-06-28 12:44 ` Simon Horman [this message]
2024-06-28 12:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628124425.GE783093@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.