* [PATCH] perf report: Calling available function for stats printing
@ 2024-06-28 18:32 ` Abhishek Dubey
0 siblings, 0 replies; 6+ messages in thread
From: Abhishek Dubey @ 2024-06-28 18:32 UTC (permalink / raw)
To: linuxppc-dev
Cc: naveen.n.rao, mpe, npiggin, peterz, mingo, namhyung, mark.rutland,
alexander.shishkin, jolsa, irogers, adrian.hunter,
linux-perf-users, linux-kernel, Abhishek Dubey
For printing dump_trace, just use existing stats_print()
function.
Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
---
tools/perf/builtin-report.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 9718770facb5..6edc0d4ce6fb 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
perf_session__fprintf_dsos(session, stdout);
if (dump_trace) {
- perf_session__fprintf_nr_events(session, stdout);
- evlist__fprintf_nr_events(session->evlist, stdout);
+ stats_print(rep);
return 0;
}
}
--
2.44.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] perf report: Calling available function for stats printing
@ 2024-06-28 18:32 ` Abhishek Dubey
0 siblings, 0 replies; 6+ messages in thread
From: Abhishek Dubey @ 2024-06-28 18:32 UTC (permalink / raw)
To: linuxppc-dev
Cc: mark.rutland, irogers, peterz, adrian.hunter, npiggin,
linux-kernel, linux-perf-users, alexander.shishkin, mingo, jolsa,
namhyung, naveen.n.rao, Abhishek Dubey
For printing dump_trace, just use existing stats_print()
function.
Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
---
tools/perf/builtin-report.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 9718770facb5..6edc0d4ce6fb 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
perf_session__fprintf_dsos(session, stdout);
if (dump_trace) {
- perf_session__fprintf_nr_events(session, stdout);
- evlist__fprintf_nr_events(session->evlist, stdout);
+ stats_print(rep);
return 0;
}
}
--
2.44.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] perf report: Calling available function for stats printing
2024-06-28 18:32 ` Abhishek Dubey
@ 2024-06-28 18:35 ` Ian Rogers
-1 siblings, 0 replies; 6+ messages in thread
From: Ian Rogers @ 2024-06-28 18:35 UTC (permalink / raw)
To: Abhishek Dubey
Cc: linuxppc-dev, naveen.n.rao, mpe, npiggin, peterz, mingo, namhyung,
mark.rutland, alexander.shishkin, jolsa, adrian.hunter,
linux-perf-users, linux-kernel
On Fri, Jun 28, 2024 at 11:32 AM Abhishek Dubey <adubey@linux.ibm.com> wrote:
>
> For printing dump_trace, just use existing stats_print()
> function.
>
> Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/builtin-report.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 9718770facb5..6edc0d4ce6fb 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
> perf_session__fprintf_dsos(session, stdout);
>
> if (dump_trace) {
> - perf_session__fprintf_nr_events(session, stdout);
> - evlist__fprintf_nr_events(session->evlist, stdout);
> + stats_print(rep);
> return 0;
> }
> }
> --
> 2.44.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] perf report: Calling available function for stats printing
@ 2024-06-28 18:35 ` Ian Rogers
0 siblings, 0 replies; 6+ messages in thread
From: Ian Rogers @ 2024-06-28 18:35 UTC (permalink / raw)
To: Abhishek Dubey
Cc: mark.rutland, peterz, adrian.hunter, npiggin, linux-kernel,
linux-perf-users, alexander.shishkin, mingo, jolsa, namhyung,
naveen.n.rao, linuxppc-dev
On Fri, Jun 28, 2024 at 11:32 AM Abhishek Dubey <adubey@linux.ibm.com> wrote:
>
> For printing dump_trace, just use existing stats_print()
> function.
>
> Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/builtin-report.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 9718770facb5..6edc0d4ce6fb 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
> perf_session__fprintf_dsos(session, stdout);
>
> if (dump_trace) {
> - perf_session__fprintf_nr_events(session, stdout);
> - evlist__fprintf_nr_events(session->evlist, stdout);
> + stats_print(rep);
> return 0;
> }
> }
> --
> 2.44.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf report: Calling available function for stats printing
2024-06-28 18:32 ` Abhishek Dubey
@ 2024-07-03 21:53 ` Namhyung Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Namhyung Kim @ 2024-07-03 21:53 UTC (permalink / raw)
To: linuxppc-dev, Abhishek Dubey
Cc: naveen.n.rao, mpe, npiggin, peterz, mingo, mark.rutland,
alexander.shishkin, jolsa, irogers, adrian.hunter,
linux-perf-users, linux-kernel
On Fri, 28 Jun 2024 14:32:24 -0400, Abhishek Dubey wrote:
> For printing dump_trace, just use existing stats_print()
> function.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf report: Calling available function for stats printing
@ 2024-07-03 21:53 ` Namhyung Kim
0 siblings, 0 replies; 6+ messages in thread
From: Namhyung Kim @ 2024-07-03 21:53 UTC (permalink / raw)
To: linuxppc-dev, Abhishek Dubey
Cc: mark.rutland, irogers, peterz, adrian.hunter, npiggin,
linux-kernel, linux-perf-users, alexander.shishkin, mingo, jolsa,
naveen.n.rao
On Fri, 28 Jun 2024 14:32:24 -0400, Abhishek Dubey wrote:
> For printing dump_trace, just use existing stats_print()
> function.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-03 21:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-28 18:32 [PATCH] perf report: Calling available function for stats printing Abhishek Dubey
2024-06-28 18:32 ` Abhishek Dubey
2024-06-28 18:35 ` Ian Rogers
2024-06-28 18:35 ` Ian Rogers
2024-07-03 21:53 ` Namhyung Kim
2024-07-03 21:53 ` Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.