From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] mtd: nand: mxc_nand: always copy_spare() for page write
Date: Mon, 1 Jul 2024 11:53:45 +0200 [thread overview]
Message-ID: <20240701115345.3ca6fef7@xps-13> (raw)
In-Reply-To: <20240528203006.1479230-1-s.hauer@pengutronix.de>
Hi Sascha,
s.hauer@pengutronix.de wrote on Tue, 28 May 2024 22:30:06 +0200:
> When doing a page write we always have to copy the OOB data in place,
> as the controller will always write it. Not copying it means we write
> random data to the OOB area.
>
> Fixes: 3df54960b63cc ("mtd: nand: mxc_nand: implement exec_op")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Miquel, feel free to fixup the original patch with this.
Sorry for the delay, I'm now fixing up the original patch with this one.
Thanks for the follow-up.
BTW I've changed the titles to "mtd: rawnand: mxc:" to match the naming
changes since the introduction of spi-nand.
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] mtd: nand: mxc_nand: always copy_spare() for page write
Date: Mon, 1 Jul 2024 11:53:45 +0200 [thread overview]
Message-ID: <20240701115345.3ca6fef7@xps-13> (raw)
In-Reply-To: <20240528203006.1479230-1-s.hauer@pengutronix.de>
Hi Sascha,
s.hauer@pengutronix.de wrote on Tue, 28 May 2024 22:30:06 +0200:
> When doing a page write we always have to copy the OOB data in place,
> as the controller will always write it. Not copying it means we write
> random data to the OOB area.
>
> Fixes: 3df54960b63cc ("mtd: nand: mxc_nand: implement exec_op")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Miquel, feel free to fixup the original patch with this.
Sorry for the delay, I'm now fixing up the original patch with this one.
Thanks for the follow-up.
BTW I've changed the titles to "mtd: rawnand: mxc:" to match the naming
changes since the introduction of spi-nand.
Cheers,
Miquèl
next prev parent reply other threads:[~2024-07-01 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 20:30 [PATCH] mtd: nand: mxc_nand: always copy_spare() for page write Sascha Hauer
2024-05-28 20:30 ` Sascha Hauer
2024-07-01 9:53 ` Miquel Raynal [this message]
2024-07-01 9:53 ` Miquel Raynal
2024-07-01 12:00 ` Miquel Raynal
2024-07-01 12:00 ` Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2024-07-02 8:45 Sascha Hauer
2024-07-03 8:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701115345.3ca6fef7@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.