All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alistair Popple <apopple@nvidia.com>
Cc: David Hildenbrand <david@redhat.com>,
	dan.j.williams@intel.com, vishal.l.verma@intel.com,
	dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com,
	jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com,
	will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com,
	dave.hansen@linux.intel.com, ira.weiny@intel.com,
	willy@infradead.org, djwong@kernel.org, tytso@mit.edu,
	linmiaohe@huawei.com, peterx@redhat.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev,
	linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de,
	david@fromorbit.com
Subject: Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages
Date: Tue, 2 Jul 2024 13:51:51 +0200	[thread overview]
Message-ID: <20240702115151.GA16313@lst.de> (raw)
In-Reply-To: <874j98gjfg.fsf@nvdebian.thelocal>

On Tue, Jul 02, 2024 at 08:19:01PM +1000, Alistair Popple wrote:
> > (B) As long as we have subpage mapcounts, this prevents vmemmap
> >     optimizations [1]. Is that only used for device-dax for now and are
> >     there no plans to make use of that for fs-dax?
> 
> I don't have any plans to. This is purely focussed on refcounting pages
> "like normal" so we can get rid of all the DAX special casing.
> 
> > (C) We managed without so far :)
> 
> Indeed, although Christoph has asked repeatedly ([1], [2] and likely
> others) that this gets fixed and I finally got sick of it coming up
> everytime I need to touch something with ZONE_DEVICE pages :)
> 
> Also it removes the need for people to understand the special DAX page
> recounting scheme and ends up removing a bunch of cruft as a bonus:
> 
>  59 files changed, 485 insertions(+), 869 deletions(-)
> 
> And that's before I clean up all the pgmap reference handling. It also
> removes the pXX_trans_huge and pXX_leaf distinction. So we managed, but
> things could be better IMHO.

Yes.  I can't wait for this series making the finish line.  There might
be more chance for cleanups and optimizations around ZONE_DEVICE, but
this alone is a huge step forward.


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Alistair Popple <apopple@nvidia.com>
Cc: linmiaohe@huawei.com, nvdimm@lists.linux.dev, jack@suse.cz,
	David Hildenbrand <david@redhat.com>,
	djwong@kernel.org, dave.hansen@linux.intel.com,
	david@fromorbit.com, peterx@redhat.com, linux-mm@kvack.org,
	will@kernel.org, hch@lst.de, dave.jiang@intel.com,
	vishal.l.verma@intel.com, linux-doc@vger.kernel.org,
	willy@infradead.org, jgg@ziepe.ca, catalin.marinas@arm.com,
	linux-ext4@vger.kernel.org, ira.weiny@intel.com,
	jhubbard@nvidia.com, npiggin@gmail.com,
	linux-cxl@vger.kernel.org, bhelgaas@google.com,
	dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org,
	tytso@mit.edu, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, logang@deltatee.com
Subject: Re: [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages
Date: Tue, 2 Jul 2024 13:51:51 +0200	[thread overview]
Message-ID: <20240702115151.GA16313@lst.de> (raw)
In-Reply-To: <874j98gjfg.fsf@nvdebian.thelocal>

On Tue, Jul 02, 2024 at 08:19:01PM +1000, Alistair Popple wrote:
> > (B) As long as we have subpage mapcounts, this prevents vmemmap
> >     optimizations [1]. Is that only used for device-dax for now and are
> >     there no plans to make use of that for fs-dax?
> 
> I don't have any plans to. This is purely focussed on refcounting pages
> "like normal" so we can get rid of all the DAX special casing.
> 
> > (C) We managed without so far :)
> 
> Indeed, although Christoph has asked repeatedly ([1], [2] and likely
> others) that this gets fixed and I finally got sick of it coming up
> everytime I need to touch something with ZONE_DEVICE pages :)
> 
> Also it removes the need for people to understand the special DAX page
> recounting scheme and ends up removing a bunch of cruft as a bonus:
> 
>  59 files changed, 485 insertions(+), 869 deletions(-)
> 
> And that's before I clean up all the pgmap reference handling. It also
> removes the pXX_trans_huge and pXX_leaf distinction. So we managed, but
> things could be better IMHO.

Yes.  I can't wait for this series making the finish line.  There might
be more chance for cleanups and optimizations around ZONE_DEVICE, but
this alone is a huge step forward.


  parent reply	other threads:[~2024-07-02 11:51 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  0:54 [PATCH 00/13] fs/dax: Fix FS DAX page reference counts Alistair Popple
2024-06-27  0:54 ` Alistair Popple
2024-06-27  0:54 ` [PATCH 01/13] mm/gup.c: Remove redundant check for PCI P2PDMA page Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  6:36   ` Dan Williams
2024-06-27  6:36     ` Dan Williams
2024-06-27  0:54 ` [PATCH 02/13] pci/p2pdma: Don't initialise page refcount to one Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  5:30   ` Christoph Hellwig
2024-06-27  5:30     ` Christoph Hellwig
2024-06-29 21:28   ` Bjorn Helgaas
2024-06-29 21:28     ` Bjorn Helgaas
2024-06-27  0:54 ` [PATCH 03/13] fs/dax: Refactor wait for dax idle page Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  5:31   ` Christoph Hellwig
2024-06-27  5:31     ` Christoph Hellwig
2024-06-27  0:54 ` [PATCH 04/13] fs/dax: Add dax_page_free callback Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  5:33   ` Christoph Hellwig
2024-06-27  5:33     ` Christoph Hellwig
2024-06-27 23:48     ` Alistair Popple
2024-06-27 23:48       ` Alistair Popple
2024-06-27  0:54 ` [PATCH 05/13] mm: Allow compound zone device pages Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  5:35   ` Christoph Hellwig
2024-06-27  5:35     ` Christoph Hellwig
2024-06-27  0:54 ` [PATCH 06/13] mm/memory: Add dax_insert_pfn Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  5:22   ` Christoph Hellwig
2024-06-27  5:22     ` Christoph Hellwig
2024-06-27 11:33   ` Jan Kara
2024-06-27 11:33     ` Jan Kara
2024-09-06  6:21     ` Alistair Popple
2024-07-02  7:18   ` David Hildenbrand
2024-07-02  7:18     ` David Hildenbrand
2024-07-02 10:47     ` Alistair Popple
2024-07-02 10:47       ` Alistair Popple
2024-07-02 11:46     ` Christoph Hellwig
2024-07-02 11:46       ` Christoph Hellwig
2024-07-02 11:53       ` David Hildenbrand
2024-07-02 11:53         ` David Hildenbrand
2024-06-27  0:54 ` [PATCH 07/13] huge_memory: Allow mappings of PUD sized pages Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27 22:26   ` kernel test robot
2024-06-27 22:26     ` kernel test robot
2024-07-02  7:16   ` David Hildenbrand
2024-07-02  7:16     ` David Hildenbrand
2024-07-02 10:19     ` Alistair Popple
2024-07-02 10:19       ` Alistair Popple
2024-07-02 11:02       ` David Hildenbrand
2024-07-02 11:02         ` David Hildenbrand
2024-07-02 11:30         ` Alistair Popple
2024-07-02 11:30           ` Alistair Popple
2024-07-02 13:01           ` David Hildenbrand
2024-07-02 13:01             ` David Hildenbrand
2024-07-02 11:51       ` Christoph Hellwig [this message]
2024-07-02 11:51         ` Christoph Hellwig
2024-07-02 12:22       ` Eliot Moss
2024-06-27  0:54 ` [PATCH 08/13] huge_memory: Allow mappings of PMD " Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  0:54 ` [PATCH 09/13] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-07-01  8:59   ` David Hildenbrand
2024-07-01  8:59     ` David Hildenbrand
2024-07-01 23:47     ` Alistair Popple
2024-07-01 23:47       ` Alistair Popple
2024-07-02 10:48       ` David Hildenbrand
2024-07-02 10:48         ` David Hildenbrand
2024-06-27  0:54 ` [PATCH 10/13] fs/dax: Properly refcount fs dax pages Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  5:44   ` Christoph Hellwig
2024-06-27  5:44     ` Christoph Hellwig
2024-09-06  6:00     ` Alistair Popple
2024-06-27  0:54 ` [PATCH 11/13] huge_memory: Remove dead vmf_insert_pXd code Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-07-05 14:24   ` Peter Xu
2024-07-05 14:24     ` Peter Xu
2024-07-09  4:07     ` Alistair Popple
2024-07-09  4:07       ` Alistair Popple
2024-07-09 15:56       ` Peter Xu
2024-07-09 15:56         ` Peter Xu
2024-07-12  2:40         ` Alistair Popple
2024-07-12  2:40           ` Alistair Popple
2024-07-12 15:52           ` Peter Xu
2024-07-12 15:52             ` Peter Xu
2024-06-27  0:54 ` [PATCH 12/13] mm: Remove pXX_devmap callers Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27  0:54 ` [PATCH 13/13] mm: Remove devmap related functions and page table bits Alistair Popple
2024-06-27  0:54   ` Alistair Popple
2024-06-27 23:04   ` kernel test robot
2024-06-27 23:04     ` kernel test robot
2024-06-28  2:12   ` kernel test robot
2024-06-28  2:12     ` kernel test robot
2024-07-08 11:35   ` Will Deacon
2024-07-08 11:35     ` Will Deacon
2024-06-27  6:58 ` [PATCH 00/13] fs/dax: Fix FS DAX page reference counts Dan Williams
2024-06-27  6:58   ` Dan Williams
2024-06-27  7:15   ` Alistair Popple
2024-06-27  7:15     ` Alistair Popple
2024-06-27 20:24     ` Dan Williams
2024-06-27 20:24       ` Dan Williams
2024-06-28  0:06       ` Alistair Popple
2024-06-28  0:06         ` Alistair Popple
2024-07-01  4:24 ` Dave Chinner
2024-07-01  4:24   ` Dave Chinner
2024-07-01  8:33   ` Alistair Popple
2024-07-01  8:33     ` Alistair Popple

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702115151.GA16313@lst.de \
    --to=hch@lst.de \
    --cc=apopple@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=david@fromorbit.com \
    --cc=david@redhat.com \
    --cc=djwong@kernel.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=logang@deltatee.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=peterx@redhat.com \
    --cc=tytso@mit.edu \
    --cc=vishal.l.verma@intel.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.