From: Stephen Hemminger <stephen@networkplumber.org>
To: "Muggeridge, Matt" <matt.muggeridge2@hpe.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: "ip route show dev enp0s9" does not show all routes for enp0s9
Date: Tue, 2 Jul 2024 22:50:07 -0700 [thread overview]
Message-ID: <20240702225007.33b0fe3b@hermes.local> (raw)
In-Reply-To: <SJ0PR84MB2088D9C951AF8B39C631950DD8DD2@SJ0PR84MB2088.NAMPRD84.PROD.OUTLOOK.COM>
On Wed, 3 Jul 2024 04:00:44 +0000
"Muggeridge, Matt" <matt.muggeridge2@hpe.com> wrote:
> > On Sun, Jun 30, 2024 at 09:23:08AM -0700, Stephen Hemminger wrote:
> > > Good catch, original code did not handle multipath in filtering.
> > >
> > > Suggest moving the loop into helper function for clarity
> >
> > Thanks, looks good. Do you want to submit it?
> >
> > You can add:
> >
> > Reviewed-by: Ido Schimmel mailto:idosch@nvidia.com
>
> Just wondering which repo this will find its way into. I sleuthed
> your repos and the iproute2 repo but could not find it.
>
> Thanks,
> Matt.
>
>
It would go in iproute2 but was not an official patch since it was not
tested. Since you are doing multipath routing, could you please make sure
it works.
Suppose a test with dummy devices is possible, but somewhat artificial
next prev parent reply other threads:[~2024-07-03 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 4:00 "ip route show dev enp0s9" does not show all routes for enp0s9 Muggeridge, Matt
2024-07-03 5:50 ` Stephen Hemminger [this message]
2024-07-03 19:46 ` Muggeridge, Matt
-- strict thread matches above, loose matches on Subject: below --
2024-06-28 0:01 Muggeridge, Matt
2024-06-28 2:36 ` Stephen Hemminger
2024-06-28 2:54 ` Muggeridge, Matt
2024-06-30 10:39 ` Ido Schimmel
2024-06-30 16:23 ` Stephen Hemminger
2024-07-01 7:17 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702225007.33b0fe3b@hermes.local \
--to=stephen@networkplumber.org \
--cc=matt.muggeridge2@hpe.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.