All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Muggeridge, Matt" <matt.muggeridge2@hpe.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: "ip route show dev enp0s9" does not show all routes for enp0s9
Date: Mon, 1 Jul 2024 10:17:46 +0300	[thread overview]
Message-ID: <ZoJYGv7WXuBUeZM4@shredder.mtl.com> (raw)
In-Reply-To: <20240630092308.0288083a@hermes.local>

On Sun, Jun 30, 2024 at 09:23:08AM -0700, Stephen Hemminger wrote:
> Good catch, original code did not handle multipath in filtering.
> 
> Suggest moving the loop into helper function for clarity

Thanks, looks good. Do you want to submit it?

You can add:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

  reply	other threads:[~2024-07-01  7:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  0:01 "ip route show dev enp0s9" does not show all routes for enp0s9 Muggeridge, Matt
2024-06-28  2:36 ` Stephen Hemminger
2024-06-28  2:54   ` Muggeridge, Matt
2024-06-30 10:39     ` Ido Schimmel
2024-06-30 16:23       ` Stephen Hemminger
2024-07-01  7:17         ` Ido Schimmel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-07-03  4:00 Muggeridge, Matt
2024-07-03  5:50 ` Stephen Hemminger
2024-07-03 19:46   ` Muggeridge, Matt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoJYGv7WXuBUeZM4@shredder.mtl.com \
    --to=idosch@idosch.org \
    --cc=matt.muggeridge2@hpe.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.