From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [anna-maria-devel:timers/misc 5/8] kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538)
Date: Wed, 3 Jul 2024 11:37:05 +0800 [thread overview]
Message-ID: <202407031108.pd47N271-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Anna-Maria Behnsen" <anna-maria@linutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/anna-maria/linux-devel.git timers/misc
head: a75487ea30d064b9ff2bb081ff82696ae9e97014
commit: 7566dd71b07f51730aec154322a3426784a17478 [5/8] timers/migration: Read childmask and parent pointer in a single place
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-161-20240703 (https://download.01.org/0day-ci/archive/20240703/202407031108.pd47N271-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202407031108.pd47N271-lkp@intel.com/
smatch warnings:
kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538)
vim +/group +539 kernel/time/timer_migration.c
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 524
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 525 static void __walk_groups(up_f up, struct tmigr_walk *data,
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 526 struct tmigr_cpu *tmc)
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 527 {
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 528 struct tmigr_group *child = NULL, *group = tmc->tmgroup;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 529
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 530 do {
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 531 WARN_ON_ONCE(group->level >= tmigr_hierarchy_levels);
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 532
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 533 if (up(group, child, data))
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 534 break;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 535
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 536 child = group;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 537 group = group->parent;
7566dd71b07f517 Anna-Maria Behnsen 2024-06-25 @538 data->childmask = group->childmask;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 @539 } while (group);
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 540 }
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 541
:::::: The code at line 539 was first introduced by commit
:::::: 8d3c19ba160fa100a11985ef576b13c76376259d timers/migration: Use a single struct for hierarchy walk data
:::::: TO: Anna-Maria Behnsen <anna-maria@linutronix.de>
:::::: CC: Anna-Maria Behnsen <anna-maria@linutronix.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-07-03 3:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 3:37 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-03 13:20 [anna-maria-devel:timers/misc 5/8] kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538) Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407031108.pd47N271-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.