* [anna-maria-devel:timers/misc 5/8] kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538)
@ 2024-07-03 3:37 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-07-03 3:37 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Anna-Maria Behnsen" <anna-maria@linutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/anna-maria/linux-devel.git timers/misc
head: a75487ea30d064b9ff2bb081ff82696ae9e97014
commit: 7566dd71b07f51730aec154322a3426784a17478 [5/8] timers/migration: Read childmask and parent pointer in a single place
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-161-20240703 (https://download.01.org/0day-ci/archive/20240703/202407031108.pd47N271-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202407031108.pd47N271-lkp@intel.com/
smatch warnings:
kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538)
vim +/group +539 kernel/time/timer_migration.c
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 524
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 525 static void __walk_groups(up_f up, struct tmigr_walk *data,
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 526 struct tmigr_cpu *tmc)
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 527 {
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 528 struct tmigr_group *child = NULL, *group = tmc->tmgroup;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 529
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 530 do {
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 531 WARN_ON_ONCE(group->level >= tmigr_hierarchy_levels);
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 532
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 533 if (up(group, child, data))
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 534 break;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 535
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 536 child = group;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 537 group = group->parent;
7566dd71b07f517 Anna-Maria Behnsen 2024-06-25 @538 data->childmask = group->childmask;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 @539 } while (group);
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 540 }
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 541
:::::: The code at line 539 was first introduced by commit
:::::: 8d3c19ba160fa100a11985ef576b13c76376259d timers/migration: Use a single struct for hierarchy walk data
:::::: TO: Anna-Maria Behnsen <anna-maria@linutronix.de>
:::::: CC: Anna-Maria Behnsen <anna-maria@linutronix.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [anna-maria-devel:timers/misc 5/8] kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538)
@ 2024-07-03 13:20 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-07-03 13:20 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Anna-Maria Behnsen" <anna-maria@linutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/anna-maria/linux-devel.git timers/misc
head: a75487ea30d064b9ff2bb081ff82696ae9e97014
commit: 7566dd71b07f51730aec154322a3426784a17478 [5/8] timers/migration: Read childmask and parent pointer in a single place
config: x86_64-randconfig-161-20240703 (https://download.01.org/0day-ci/archive/20240703/202407031108.pd47N271-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202407031108.pd47N271-lkp@intel.com/
smatch warnings:
kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538)
vim +/group +539 kernel/time/timer_migration.c
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 525 static void __walk_groups(up_f up, struct tmigr_walk *data,
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 526 struct tmigr_cpu *tmc)
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 527 {
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 528 struct tmigr_group *child = NULL, *group = tmc->tmgroup;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 529
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 530 do {
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 531 WARN_ON_ONCE(group->level >= tmigr_hierarchy_levels);
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 532
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 533 if (up(group, child, data))
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 534 break;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 535
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 536 child = group;
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 537 group = group->parent;
7566dd71b07f517 Anna-Maria Behnsen 2024-06-25 @538 data->childmask = group->childmask;
^^^^^^^^^^^^^^^^^
Dereference
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 @539 } while (group);
^^^^^
Check for NULL after a dereference
8d3c19ba160fa10 Anna-Maria Behnsen 2024-06-25 540 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-03 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-03 3:37 [anna-maria-devel:timers/misc 5/8] kernel/time/timer_migration.c:539 __walk_groups() warn: variable dereferenced before check 'group' (see line 538) kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-07-03 13:20 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.