All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: "Adrián Larumbe" <adrian.larumbe@collabora.com>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Support fdinfo runtime and memory stats on Panthor
Date: Wed, 3 Jul 2024 17:45:58 +0200	[thread overview]
Message-ID: <20240703174558.36387dc8@collabora.com> (raw)
In-Reply-To: <157b20fa-078a-479c-bb40-017d16d55c21@arm.com>

On Wed, 3 Jul 2024 16:29:00 +0100
Steven Price <steven.price@arm.com> wrote:

> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index 79ffcbc41d78..42929e147107 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -2926,6 +2926,7 @@ queue_run_job(struct drm_sched_job *sched_job)
>                         pm_runtime_get(ptdev->base.dev);
>                         sched->pm.has_ref = true;
>                 }
> +               panthor_devfreq_record_busy(sched->ptdev);

Oops, we're definitely lacking a busy event if all groups were idle but
still assigned a FW slot. Mind sending this as separate fix?

>         }
>  
>         done_fence = dma_fence_get(job->done_fence);

  reply	other threads:[~2024-07-03 15:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  0:49 [PATCH v3 0/7] Support fdinfo runtime and memory stats on Panthor Adrián Larumbe
2024-06-06  0:49 ` [PATCH v3 1/7] drm/panthor: introduce job cycle and timestamp accounting Adrián Larumbe
2024-06-06  0:49 ` [PATCH v3 2/7] drm/panthor: add DRM fdinfo support Adrián Larumbe
2024-06-06  0:49 ` [PATCH v3 3/7] drm/panthor: enable fdinfo for memory stats Adrián Larumbe
2024-06-06  0:49 ` [PATCH v3 4/7] drm/panthor: add sysfs knob for enabling job profiling Adrián Larumbe
2024-06-06  0:49 ` [PATCH v3 5/7] drm/panthor: support job accounting Adrián Larumbe
2024-06-06  0:49 ` [PATCH v3 6/7] drm/drm_file: add display of driver's internal memory size Adrián Larumbe
2024-06-06  8:35   ` Tvrtko Ursulin
2024-06-24 17:47     ` Rob Clark
2024-06-06  0:49 ` [PATCH v3 7/7] drm/panthor: register size of internal objects through fdinfo Adrián Larumbe
2024-06-13 15:28 ` [PATCH v3 0/7] Support fdinfo runtime and memory stats on Panthor Steven Price
2024-06-24 11:23   ` Adrián Larumbe
2024-07-03 15:29     ` Steven Price
2024-07-03 15:45       ` Boris Brezillon [this message]
2024-07-15 20:43   ` Adrián Larumbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703174558.36387dc8@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=adrian.larumbe@collabora.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=steven.price@arm.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.