From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
intel-wired-lan@lists.osuosl.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Fix field vector array data type
Date: Thu, 4 Jul 2024 09:49:53 +0100 [thread overview]
Message-ID: <20240704084953.GX598357@kernel.org> (raw)
In-Reply-To: <20240703112502.28021-1-marcin.szycik@linux.intel.com>
On Wed, Jul 03, 2024 at 01:25:02PM +0200, Marcin Szycik wrote:
> Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8
> instead of u16. This array contents are used solely to be later passed
> to lkup_indx in struct ice_aqc_recipe_content, which is u8.
>
> Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> Targeting next, as the commit to be fixed is on dev-queue.
> Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
FWIIW, this LGTM.
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH iwl-next] ice: Fix field vector array data type
Date: Thu, 4 Jul 2024 09:49:53 +0100 [thread overview]
Message-ID: <20240704084953.GX598357@kernel.org> (raw)
In-Reply-To: <20240703112502.28021-1-marcin.szycik@linux.intel.com>
On Wed, Jul 03, 2024 at 01:25:02PM +0200, Marcin Szycik wrote:
> Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8
> instead of u16. This array contents are used solely to be later passed
> to lkup_indx in struct ice_aqc_recipe_content, which is u8.
>
> Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> Targeting next, as the commit to be fixed is on dev-queue.
> Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation")
FWIIW, this LGTM.
...
next prev parent reply other threads:[~2024-07-04 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 11:25 [Intel-wired-lan] [PATCH iwl-next] ice: Fix field vector array data type Marcin Szycik
2024-07-03 11:25 ` Marcin Szycik
2024-07-04 8:49 ` Simon Horman [this message]
2024-07-04 8:49 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704084953.GX598357@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.