From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: also check bio alignment for bio based drivers
Date: Fri, 5 Jul 2024 15:37:09 +0200 [thread overview]
Message-ID: <20240705133709.GB30748@lst.de> (raw)
In-Reply-To: <85d7971d-f682-4b9e-8c0a-0366075471de@oracle.com>
On Fri, Jul 05, 2024 at 02:25:59PM +0100, John Garry wrote:
> On 05/07/2024 13:56, Christoph Hellwig wrote:
>> Extend the checks added in 0676c434a99b ("block: check bio alignment
>> in blk_mq_submit_bio") for blk-mq drivers to bio based drivers as
>> all the same reasons apply for them as well.
>
> So do we now still need blkdev_dio_invalid() -> bdev_logical_block_size()
> pos checks for simple and async paths in fops?
>
> They are not doing harm and messy to remove, I suppose (if strictly not
> required).
Going all the way down into the block layer vs just doing the trivial
check ahead of time does not sound like a winning proposition..
next prev parent reply other threads:[~2024-07-05 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 12:56 extend the bio alignment check to bio based drivers Christoph Hellwig
2024-07-05 12:56 ` [PATCH 1/2] block: also check bio alignment for " Christoph Hellwig
2024-07-05 13:22 ` Ming Lei
2024-07-05 13:36 ` Christoph Hellwig
2024-07-09 13:50 ` Ming Lei
2024-07-10 5:53 ` Christoph Hellwig
2024-07-05 13:25 ` John Garry
2024-07-05 13:37 ` Christoph Hellwig [this message]
2024-07-05 12:56 ` [PATCH 2/2] brd: remove sector alignment checks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705133709.GB30748@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.