From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: also check bio alignment for bio based drivers
Date: Wed, 10 Jul 2024 07:53:44 +0200 [thread overview]
Message-ID: <20240710055344.GA25282@lst.de> (raw)
In-Reply-To: <Zo1AOKOK7dCpPll2@fedora>
On Tue, Jul 09, 2024 at 09:50:48PM +0800, Ming Lei wrote:
> > That doesn't mean we shouldn't look into actually holding q_usage_count
> > over the entire bio lifetime for bio based drivers, but that's a
> > separate project.
>
> What if logical block size is changed between bio submission and
> completion?
>
> For blk-mq device, we need to drain any IO when re-configuring device,
> however it can't be supported generically for bio based driver.
Many bio based drivers do the same, just reimplemented without
block helpers (e.g. md/dm).
But as I said the point is that I really want the sanity check to
always be there. I'd also like to eventually make freeze work for
bio based drivers, but that is a separate issue.
next prev parent reply other threads:[~2024-07-10 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 12:56 extend the bio alignment check to bio based drivers Christoph Hellwig
2024-07-05 12:56 ` [PATCH 1/2] block: also check bio alignment for " Christoph Hellwig
2024-07-05 13:22 ` Ming Lei
2024-07-05 13:36 ` Christoph Hellwig
2024-07-09 13:50 ` Ming Lei
2024-07-10 5:53 ` Christoph Hellwig [this message]
2024-07-05 13:25 ` John Garry
2024-07-05 13:37 ` Christoph Hellwig
2024-07-05 12:56 ` [PATCH 2/2] brd: remove sector alignment checks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710055344.GA25282@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.