Re: [PATCH 1/5] drm/i915/display: Add support for histogram

[kernel test robot <lkp@intel.com>]

Hi Arun,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip drm-xe/drm-xe-next linus/master v6.10-rc6 next-20240703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-i915-display-Add-support-for-histogram/20240705-233245
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240705095551.1244154-2-arun.r.murthy%40intel.com
patch subject: [PATCH 1/5] drm/i915/display: Add support for histogram
config: i386-randconfig-061-20240706 (https://download.01.org/0day-ci/archive/20240706/202407061424.nDa9VYJe-lkp@intel.com/config)
compiler: gcc-8 (Ubuntu 8.4.0-3ubuntu2) 8.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240706/202407061424.nDa9VYJe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407061424.nDa9VYJe-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/gpu/drm/i915/display/intel_histogram.o: in function `intel_histogram_enable':
>> drivers/gpu/drm/i915/display/intel_histogram.c:68:(.text+0x2b6): undefined reference to `__udivdi3'


vim +68 drivers/gpu/drm/i915/display/intel_histogram.c

    30	
    31	static int intel_histogram_enable(struct intel_crtc *intel_crtc)
    32	{
    33		struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
    34		struct intel_histogram *histogram = intel_crtc->histogram;
    35		int pipe = intel_crtc->pipe;
    36		u64 res;
    37		u32 gbandthreshold;
    38	
    39		if (!histogram->can_enable) {
    40			drm_err(&i915->drm,
    41				"Histogram not supported, compute config failed\n");
    42			return -EINVAL;
    43		}
    44	
    45		if (histogram->enable)
    46			return 0;
    47	
    48		/* Pipe Dithering should be enabled with GLOBAL_HIST */
    49		intel_histogram_enable_dithering(i915, pipe);
    50	
    51		/*
    52		 * enable DPST_CTL Histogram mode
    53		 * Clear DPST_CTL Bin Reg function select to TC
    54		 */
    55		intel_de_rmw(i915, DPST_CTL(pipe),
    56			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
    57			     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
    58			     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
    59			     DPST_CTL_HIST_MODE_HSV |
    60			     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
    61	
    62		/* Re-Visit: check if wait for one vblank is required */
    63		drm_crtc_wait_one_vblank(&intel_crtc->base);
    64	
    65		/* TODO: one time programming: Program GuardBand Threshold */
    66		res = (intel_crtc->config->hw.adjusted_mode.vtotal *
    67					intel_crtc->config->hw.adjusted_mode.htotal);
  > 68		gbandthreshold = (res *	HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
    69					HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
    70	
    71		/* Enable histogram interrupt mode */
    72		intel_de_rmw(i915, DPST_GUARD(pipe),
    73			     DPST_GUARD_THRESHOLD_GB_MASK |
    74			     DPST_GUARD_INTERRUPT_DELAY_MASK | DPST_GUARD_HIST_INT_EN,
    75			     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
    76			     DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DELAY) |
    77			     DPST_GUARD_HIST_INT_EN);
    78	
    79		/* Clear pending interrupts has to be done on separate write */
    80		intel_de_rmw(i915, DPST_GUARD(pipe),
    81			     DPST_GUARD_HIST_EVENT_STATUS, 1);
    82	
    83		histogram->enable = true;
    84	
    85		return 0;
    86	}
    87	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki