[PATCH 0/4] IMX8 series small clock update

[PATCH 0/4] IMX8 series small clock update

[Michael Trimarchi]

This series is cover other part of my internal review work, that
will allow us to support the video subsystem of imx8mn. During this work
I found some small issues that fix several small problems but it will
help as preparation for the video one

Michael Trimarchi (4):
  clk: imx: clk-imx8mn Fix nand and spi clock parent
  clk: imx8mn: Make parent names arrays const pointers
  clk: imx8mm: Make parent names arrays const pointers
  clk: imx8mp: Make parent names arrays const pointers

 drivers/clk/imx/clk-imx8mm.c | 157 ++++++++++++++---------
 drivers/clk/imx/clk-imx8mn.c | 151 +++++++++++++---------
 drivers/clk/imx/clk-imx8mp.c | 242 +++++++++++++++++------------------
 3 files changed, 303 insertions(+), 247 deletions(-)

-- 
2.43.0

[PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Michael Trimarchi]

The osc_24m is the clock-output-name and not the one that
is used as internal name reference from the strcmp. The clock
that use osc_24m, will not be able to reparent it as they should.
We need anyway register the osc_24m clock fixed factor in the clock
tree.

Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index ed9e16d7c1..bfd1677520 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
 					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
 
 #if CONFIG_IS_ENABLED(DM_SPI)
-static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
+static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
 					   "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
 					   "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
+static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
 					   "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
 					   "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
+static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
 					   "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
 					   "sys_pll2_250m", "audio_pll2_out", };
 #endif
@@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
 static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
 					   "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
 
-static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
+static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
 						"sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
 						"sys_pll2_250m", "video_pll_out", };
 
@@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
 
 static int imx8mn_clk_probe(struct udevice *dev)
 {
+	struct clk osc_24m_clk;
 	void __iomem *base;
+	int ret;
 
 	base = (void *)ANATOP_BASE_ADDR;
 
@@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
 	clk_dm(IMX8MN_SYS_PLL2_1000M,
 	       imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
 
+	ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
+	if (ret)
+		return ret;
+	clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
+
 	base = dev_read_addr_ptr(dev);
 	if (!base)
 		return -EINVAL;
-- 
2.43.0

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Fabio Estevam]

Hi Michael,

On Sun, Jul 7, 2024 at 5:20 AM Michael Trimarchi
<michael@amarulasolutions.com> wrote:

> -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",

The kernel uses osc_24m. Why does U-Boot need to be different?

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Michael Nazzareno Trimarchi]

Hi

On Wed, Jul 10, 2024 at 3:34 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Michael,
>
> On Sun, Jul 7, 2024 at 5:20 AM Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
>
> > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
>
> The kernel uses osc_24m. Why does U-Boot need to be different?

clk dump

It's how uboot is registering the clk in dts. My idea now was not to
change it to not impact other architectures.
I have a lot of changes but I don't want to address regression and fix
and test before send more patches

MIchael


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Fabio Estevam]

On Wed, Jul 10, 2024 at 10:39 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:

> clk dump
>
> It's how uboot is registering the clk in dts. My idea now was not to
> change it to not impact other architectures.
> I have a lot of changes but I don't want to address regression and fix
> and test before send more patches

Ok, I see that 'clock-osc-24m' is already used in U-Boot by the other
peripherals.

Your change looks correct.

Ideally, we should use 'osc_24m' in the future to align with the
kernel, but that's a different task.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Michael Nazzareno Trimarchi]

HI Fabio

On Wed, Jul 10, 2024 at 3:43 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Wed, Jul 10, 2024 at 10:39 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>
> > clk dump
> >
> > It's how uboot is registering the clk in dts. My idea now was not to
> > change it to not impact other architectures.
> > I have a lot of changes but I don't want to address regression and fix
> > and test before send more patches
>
> Ok, I see that 'clock-osc-24m' is already used in U-Boot by the other
> peripherals.
>
> Your change looks correct.
>
> Ideally, we should use 'osc_24m' in the future to align with the
> kernel, but that's a different task.

I will rephrase the commit message

Michael


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Fabio Estevam]

On Thu, Jul 11, 2024 at 2:56 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:

> I will rephrase the commit message

It looks good as is.

Applied all, thanks.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
<michael@amarulasolutions.com> wrote:
>
> The osc_24m is the clock-output-name and not the one that
> is used as internal name reference from the strcmp. The clock
> that use osc_24m, will not be able to reparent it as they should.
> We need anyway register the osc_24m clock fixed factor in the clock
> tree.
>
> Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index ed9e16d7c1..bfd1677520 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
>                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
>
>  #if CONFIG_IS_ENABLED(DM_SPI)
> -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
>                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
>                                            "sys_pll2_250m", "audio_pll2_out", };
>
> -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
>                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
>                                            "sys_pll2_250m", "audio_pll2_out", };
>
> -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
>                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
>                                            "sys_pll2_250m", "audio_pll2_out", };
>  #endif
> @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
>  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
>                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
>
> -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
>                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
>                                                 "sys_pll2_250m", "video_pll_out", };
>
> @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
>
>  static int imx8mn_clk_probe(struct udevice *dev)
>  {
> +       struct clk osc_24m_clk;
>         void __iomem *base;
> +       int ret;
>
>         base = (void *)ANATOP_BASE_ADDR;
>
> @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
>         clk_dm(IMX8MN_SYS_PLL2_1000M,
>                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
>

I know it's late, but I didn't get around to testing my Nano board for
a while.  Sorry for the delayed feedback...

> +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> +       if (ret)
> +               return ret;
> +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> +

These four lines appear to have introduced a regression on the
imx8mn-beacon board.  In the SPL phase, I get an error message
indicating it cannot find the i2c clk, then access to the PMIC fails.
If I remove these four lines, the error message disappears, and the
PMIC is happy again.

I have confirmed that CLK, and SPL_CLK are both defined.   I checked
the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
= "osc_24m"

I have also tried to mark the 24m clock as with bootph-pre-ram;:
&{/clock-osc-24m} {
  bootph-pre-ram;
};

Unfortunately, nothing is helping, and I am not sure what else to try.
clk_fixed_rate.o is built into my SPL, so I don't think it's a config
issue.  I need to the PMIC to increase the voltage since we run the
Nano in overdrive mode to run the LPDDR4 at the highest speed.

Might anyone have any suggestions?

adam

>         base = dev_read_addr_ptr(dev);
>         if (!base)
>                 return -EINVAL;
> --
> 2.43.0
>

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Michael Nazzareno Trimarchi]

Hi Adam

On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
>
> On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > The osc_24m is the clock-output-name and not the one that
> > is used as internal name reference from the strcmp. The clock
> > that use osc_24m, will not be able to reparent it as they should.
> > We need anyway register the osc_24m clock fixed factor in the clock
> > tree.
> >
> > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > Cc: Marek Vasut <marex@denx.de>
> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > ---
> >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > index ed9e16d7c1..bfd1677520 100644
> > --- a/drivers/clk/imx/clk-imx8mn.c
> > +++ b/drivers/clk/imx/clk-imx8mn.c
> > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> >
> >  #if CONFIG_IS_ENABLED(DM_SPI)
> > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> >                                            "sys_pll2_250m", "audio_pll2_out", };
> >
> > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> >                                            "sys_pll2_250m", "audio_pll2_out", };
> >
> > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> >                                            "sys_pll2_250m", "audio_pll2_out", };
> >  #endif
> > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> >
> > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> >                                                 "sys_pll2_250m", "video_pll_out", };
> >
> > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> >
> >  static int imx8mn_clk_probe(struct udevice *dev)
> >  {
> > +       struct clk osc_24m_clk;
> >         void __iomem *base;
> > +       int ret;
> >
> >         base = (void *)ANATOP_BASE_ADDR;
> >
> > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> >
>
> I know it's late, but I didn't get around to testing my Nano board for
> a while.  Sorry for the delayed feedback...
>
> > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > +       if (ret)
> > +               return ret;
> > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > +
>
> These four lines appear to have introduced a regression on the
> imx8mn-beacon board.  In the SPL phase, I get an error message
> indicating it cannot find the i2c clk, then access to the PMIC fails.
> If I remove these four lines, the error message disappears, and the
> PMIC is happy again.
>
> I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> = "osc_24m"
>
> I have also tried to mark the 24m clock as with bootph-pre-ram;:
> &{/clock-osc-24m} {
>   bootph-pre-ram;
> };
>
> Unfortunately, nothing is helping, and I am not sure what else to try.
> clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> issue.  I need to the PMIC to increase the voltage since we run the
> Nano in overdrive mode to run the LPDDR4 at the highest speed.
>
> Might anyone have any suggestions?
>

Not yet. I have a similar setup but I don't set pmic, so I think that
the symbol is not find
in SPL and it just fail clock registration. Is that possible?

If (ret)

put here a print

Michael
> adam
>
> >         base = dev_read_addr_ptr(dev);
> >         if (!base)
> >                 return -EINVAL;
> > --
> > 2.43.0
> >



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Adam
>
> On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > >
> > > The osc_24m is the clock-output-name and not the one that
> > > is used as internal name reference from the strcmp. The clock
> > > that use osc_24m, will not be able to reparent it as they should.
> > > We need anyway register the osc_24m clock fixed factor in the clock
> > > tree.
> > >
> > > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > > Cc: Marek Vasut <marex@denx.de>
> > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > ---
> > >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > > index ed9e16d7c1..bfd1677520 100644
> > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> > >
> > >  #if CONFIG_IS_ENABLED(DM_SPI)
> > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > >
> > > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > >
> > > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > >  #endif
> > > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> > >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> > >
> > > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> > >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> > >                                                 "sys_pll2_250m", "video_pll_out", };
> > >
> > > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> > >
> > >  static int imx8mn_clk_probe(struct udevice *dev)
> > >  {
> > > +       struct clk osc_24m_clk;
> > >         void __iomem *base;
> > > +       int ret;
> > >
> > >         base = (void *)ANATOP_BASE_ADDR;
> > >
> > > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> > >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> > >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> > >
> >
> > I know it's late, but I didn't get around to testing my Nano board for
> > a while.  Sorry for the delayed feedback...
> >
> > > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > +       if (ret)
> > > +               return ret;
> > > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > +
> >
> > These four lines appear to have introduced a regression on the
> > imx8mn-beacon board.  In the SPL phase, I get an error message
> > indicating it cannot find the i2c clk, then access to the PMIC fails.
> > If I remove these four lines, the error message disappears, and the
> > PMIC is happy again.
> >
> > I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> > the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> > = "osc_24m"
> >
> > I have also tried to mark the 24m clock as with bootph-pre-ram;:
> > &{/clock-osc-24m} {
> >   bootph-pre-ram;
> > };
> >
> > Unfortunately, nothing is helping, and I am not sure what else to try.
> > clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> > issue.  I need to the PMIC to increase the voltage since we run the
> > Nano in overdrive mode to run the LPDDR4 at the highest speed.
> >
> > Might anyone have any suggestions?
> >
>
> Not yet. I have a similar setup but I don't set pmic, so I think that
> the symbol is not find
> in SPL and it just fail clock registration. Is that possible?

It does appear that the clock registration failed.   Since the system
does an early return, the I2C clocks among others are also not
registered which appears to cause the failure.

I changed the registration around a little:

ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
if (!ret)
        clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));

This method won't return prematurely, so the I2C and other clocks can
be registered, and it appears to address the problem.
Another alternative might be to move this clock registration until
after all the rest of the clocks are done.

adam
>
> If (ret)
>
> put here a print
>
> Michael
> > adam
> >
> > >         base = dev_read_addr_ptr(dev);
> > >         if (!base)
> > >                 return -EINVAL;
> > > --
> > > 2.43.0
> > >
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Michael Nazzareno Trimarchi]

Hi Adam

On Mon, Nov 4, 2024 at 6:01 PM Adam Ford <aford173@gmail.com> wrote:
>
> On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi Adam
> >
> > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> > > <michael@amarulasolutions.com> wrote:
> > > >
> > > > The osc_24m is the clock-output-name and not the one that
> > > > is used as internal name reference from the strcmp. The clock
> > > > that use osc_24m, will not be able to reparent it as they should.
> > > > We need anyway register the osc_24m clock fixed factor in the clock
> > > > tree.
> > > >
> > > > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > > > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > > ---
> > > >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> > > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > > > index ed9e16d7c1..bfd1677520 100644
> > > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> > > >
> > > >  #if CONFIG_IS_ENABLED(DM_SPI)
> > > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > >
> > > > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > >
> > > > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > >  #endif
> > > > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> > > >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> > > >
> > > > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > > > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> > > >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> > > >                                                 "sys_pll2_250m", "video_pll_out", };
> > > >
> > > > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> > > >
> > > >  static int imx8mn_clk_probe(struct udevice *dev)
> > > >  {
> > > > +       struct clk osc_24m_clk;
> > > >         void __iomem *base;
> > > > +       int ret;
> > > >
> > > >         base = (void *)ANATOP_BASE_ADDR;
> > > >
> > > > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> > > >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> > > >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> > > >
> > >
> > > I know it's late, but I didn't get around to testing my Nano board for
> > > a while.  Sorry for the delayed feedback...
> > >
> > > > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > +       if (ret)
> > > > +               return ret;
> > > > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > > +
> > >
> > > These four lines appear to have introduced a regression on the
> > > imx8mn-beacon board.  In the SPL phase, I get an error message
> > > indicating it cannot find the i2c clk, then access to the PMIC fails.
> > > If I remove these four lines, the error message disappears, and the
> > > PMIC is happy again.
> > >
> > > I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> > > the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> > > = "osc_24m"
> > >
> > > I have also tried to mark the 24m clock as with bootph-pre-ram;:
> > > &{/clock-osc-24m} {
> > >   bootph-pre-ram;
> > > };
> > >
> > > Unfortunately, nothing is helping, and I am not sure what else to try.
> > > clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> > > issue.  I need to the PMIC to increase the voltage since we run the
> > > Nano in overdrive mode to run the LPDDR4 at the highest speed.
> > >
> > > Might anyone have any suggestions?
> > >
> >
> > Not yet. I have a similar setup but I don't set pmic, so I think that
> > the symbol is not find
> > in SPL and it just fail clock registration. Is that possible?
>
> It does appear that the clock registration failed.   Since the system
> does an early return, the I2C clocks among others are also not
> registered which appears to cause the failure.
>
> I changed the registration around a little:
>
> ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> if (!ret)
>         clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
>

Seems that is not in the image spl so it can not find it. Are you sure
that you can inside
the SPL

Michael

> This method won't return prematurely, so the I2C and other clocks can
> be registered, and it appears to address the problem.
> Another alternative might be to move this clock registration until
> after all the rest of the clocks are done.
>
> adam
> >
> > If (ret)
> >
> > put here a print
> >
> > Michael
> > > adam
> > >
> > > >         base = dev_read_addr_ptr(dev);
> > > >         if (!base)
> > > >                 return -EINVAL;
> > > > --
> > > > 2.43.0
> > > >
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael@amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info@amarulasolutions.com
> > www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Adam
>
> On Mon, Nov 4, 2024 at 6:01 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > >
> > > Hi Adam
> > >
> > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
> > > >
> > > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> > > > <michael@amarulasolutions.com> wrote:
> > > > >
> > > > > The osc_24m is the clock-output-name and not the one that
> > > > > is used as internal name reference from the strcmp. The clock
> > > > > that use osc_24m, will not be able to reparent it as they should.
> > > > > We need anyway register the osc_24m clock fixed factor in the clock
> > > > > tree.
> > > > >
> > > > > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > > > > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > > > > Cc: Marek Vasut <marex@denx.de>
> > > > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > > > ---
> > > > >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> > > > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > > > > index ed9e16d7c1..bfd1677520 100644
> > > > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > > > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> > > > >
> > > > >  #if CONFIG_IS_ENABLED(DM_SPI)
> > > > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > >
> > > > > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > >
> > > > > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > >  #endif
> > > > > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> > > > >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> > > > >
> > > > > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> > > > >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> > > > >                                                 "sys_pll2_250m", "video_pll_out", };
> > > > >
> > > > > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> > > > >
> > > > >  static int imx8mn_clk_probe(struct udevice *dev)
> > > > >  {
> > > > > +       struct clk osc_24m_clk;
> > > > >         void __iomem *base;
> > > > > +       int ret;
> > > > >
> > > > >         base = (void *)ANATOP_BASE_ADDR;
> > > > >
> > > > > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> > > > >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> > > > >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> > > > >
> > > >
> > > > I know it's late, but I didn't get around to testing my Nano board for
> > > > a while.  Sorry for the delayed feedback...
> > > >
> > > > > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > > +       if (ret)
> > > > > +               return ret;
> > > > > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > > > +
> > > >
> > > > These four lines appear to have introduced a regression on the
> > > > imx8mn-beacon board.  In the SPL phase, I get an error message
> > > > indicating it cannot find the i2c clk, then access to the PMIC fails.
> > > > If I remove these four lines, the error message disappears, and the
> > > > PMIC is happy again.
> > > >
> > > > I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> > > > the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> > > > = "osc_24m"
> > > >
> > > > I have also tried to mark the 24m clock as with bootph-pre-ram;:
> > > > &{/clock-osc-24m} {
> > > >   bootph-pre-ram;
> > > > };
> > > >
> > > > Unfortunately, nothing is helping, and I am not sure what else to try.
> > > > clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> > > > issue.  I need to the PMIC to increase the voltage since we run the
> > > > Nano in overdrive mode to run the LPDDR4 at the highest speed.
> > > >
> > > > Might anyone have any suggestions?
> > > >
> > >
> > > Not yet. I have a similar setup but I don't set pmic, so I think that
> > > the symbol is not find
> > > in SPL and it just fail clock registration. Is that possible?
> >
> > It does appear that the clock registration failed.   Since the system
> > does an early return, the I2C clocks among others are also not
> > registered which appears to cause the failure.
> >
> > I changed the registration around a little:
> >
> > ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > if (!ret)
> >         clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> >
>
> Seems that is not in the image spl so it can not find it. Are you sure
> that you can inside
> the SPL

I am not sure I understand what you are asking, but the clock node
appears in spl/u-boot-spl.dtb:

 clock-osc-24m {
                compatible = "fixed-clock";
                #clock-cells = <0x00>;
                clock-frequency = <0x16e3600>;
                clock-output-names = "osc_24m";
                phandle = <0x18>;
        };

Since the clock-output-names is "osc_24m" I wonder if clk_get_by_name
is the right function.  Looking at other uses of this function, it
looks like it's looking for a 'clock-names' parameter and not
clock-output-names.

adam
>
> Michael
>
> > This method won't return prematurely, so the I2C and other clocks can
> > be registered, and it appears to address the problem.
> > Another alternative might be to move this clock registration until
> > after all the rest of the clocks are done.
> >
> > adam
> > >
> > > If (ret)
> > >
> > > put here a print
> > >
> > > Michael
> > > > adam
> > > >
> > > > >         base = dev_read_addr_ptr(dev);
> > > > >         if (!base)
> > > > >                 return -EINVAL;
> > > > > --
> > > > > 2.43.0
> > > > >
> > >
> > >
> > >
> > > --
> > > Michael Nazzareno Trimarchi
> > > Co-Founder & Chief Executive Officer
> > > M. +39 347 913 2170
> > > michael@amarulasolutions.com
> > > __________________________________
> > >
> > > Amarula Solutions BV
> > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > T. +31 (0)85 111 9172
> > > info@amarulasolutions.com
> > > www.amarulasolutions.com
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Michael Nazzareno Trimarchi]

Hi

On Mon, Nov 4, 2024 at 6:17 PM Adam Ford <aford173@gmail.com> wrote:
>
> On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi Adam
> >
> > On Mon, Nov 4, 2024 at 6:01 PM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi
> > > <michael@amarulasolutions.com> wrote:
> > > >
> > > > Hi Adam
> > > >
> > > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
> > > > >
> > > > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> > > > > <michael@amarulasolutions.com> wrote:
> > > > > >
> > > > > > The osc_24m is the clock-output-name and not the one that
> > > > > > is used as internal name reference from the strcmp. The clock
> > > > > > that use osc_24m, will not be able to reparent it as they should.
> > > > > > We need anyway register the osc_24m clock fixed factor in the clock
> > > > > > tree.
> > > > > >
> > > > > > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > > > > > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > > > > > Cc: Marek Vasut <marex@denx.de>
> > > > > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > > > > ---
> > > > > >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> > > > > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > > > > > index ed9e16d7c1..bfd1677520 100644
> > > > > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > > > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > > > > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > > >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> > > > > >
> > > > > >  #if CONFIG_IS_ENABLED(DM_SPI)
> > > > > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > >
> > > > > > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > >
> > > > > > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > >  #endif
> > > > > > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > > >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> > > > > >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> > > > > >
> > > > > > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> > > > > >                                                 "sys_pll2_250m", "video_pll_out", };
> > > > > >
> > > > > > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> > > > > >
> > > > > >  static int imx8mn_clk_probe(struct udevice *dev)
> > > > > >  {
> > > > > > +       struct clk osc_24m_clk;
> > > > > >         void __iomem *base;
> > > > > > +       int ret;
> > > > > >
> > > > > >         base = (void *)ANATOP_BASE_ADDR;
> > > > > >
> > > > > > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> > > > > >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> > > > > >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> > > > > >
> > > > >
> > > > > I know it's late, but I didn't get around to testing my Nano board for
> > > > > a while.  Sorry for the delayed feedback...
> > > > >
> > > > > > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > > > +       if (ret)
> > > > > > +               return ret;
> > > > > > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > > > > +
> > > > >
> > > > > These four lines appear to have introduced a regression on the
> > > > > imx8mn-beacon board.  In the SPL phase, I get an error message
> > > > > indicating it cannot find the i2c clk, then access to the PMIC fails.
> > > > > If I remove these four lines, the error message disappears, and the
> > > > > PMIC is happy again.
> > > > >
> > > > > I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> > > > > the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> > > > > = "osc_24m"
> > > > >
> > > > > I have also tried to mark the 24m clock as with bootph-pre-ram;:
> > > > > &{/clock-osc-24m} {
> > > > >   bootph-pre-ram;
> > > > > };
> > > > >
> > > > > Unfortunately, nothing is helping, and I am not sure what else to try.
> > > > > clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> > > > > issue.  I need to the PMIC to increase the voltage since we run the
> > > > > Nano in overdrive mode to run the LPDDR4 at the highest speed.
> > > > >
> > > > > Might anyone have any suggestions?
> > > > >
> > > >
> > > > Not yet. I have a similar setup but I don't set pmic, so I think that
> > > > the symbol is not find
> > > > in SPL and it just fail clock registration. Is that possible?
> > >
> > > It does appear that the clock registration failed.   Since the system
> > > does an early return, the I2C clocks among others are also not
> > > registered which appears to cause the failure.
> > >
> > > I changed the registration around a little:
> > >
> > > ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > if (!ret)
> > >         clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > >
> >
> > Seems that is not in the image spl so it can not find it. Are you sure
> > that you can inside
> > the SPL
>
> I am not sure I understand what you are asking, but the clock node
> appears in spl/u-boot-spl.dtb:
>
>  clock-osc-24m {
>                 compatible = "fixed-clock";
>                 #clock-cells = <0x00>;
>                 clock-frequency = <0x16e3600>;
>                 clock-output-names = "osc_24m";
>                 phandle = <0x18>;
>         };
>
> Since the clock-output-names is "osc_24m" I wonder if clk_get_by_name
> is the right function.  Looking at other uses of this function, it
> looks like it's looking for a 'clock-names' parameter and not
> clock-output-names.

Yes, it's the right answer. That is strange because it works in uboot
image. Is the node the same in uboot-dtb?

Michael

>
> adam
> >
> > Michael
> >
> > > This method won't return prematurely, so the I2C and other clocks can
> > > be registered, and it appears to address the problem.
> > > Another alternative might be to move this clock registration until
> > > after all the rest of the clocks are done.
> > >
> > > adam
> > > >
> > > > If (ret)
> > > >
> > > > put here a print
> > > >
> > > > Michael
> > > > > adam
> > > > >
> > > > > >         base = dev_read_addr_ptr(dev);
> > > > > >         if (!base)
> > > > > >                 return -EINVAL;
> > > > > > --
> > > > > > 2.43.0
> > > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Michael Nazzareno Trimarchi
> > > > Co-Founder & Chief Executive Officer
> > > > M. +39 347 913 2170
> > > > michael@amarulasolutions.com
> > > > __________________________________
> > > >
> > > > Amarula Solutions BV
> > > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > > T. +31 (0)85 111 9172
> > > > info@amarulasolutions.com
> > > > www.amarulasolutions.com
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael@amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info@amarulasolutions.com
> > www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Mon, Nov 4, 2024 at 11:22 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi
>
> On Mon, Nov 4, 2024 at 6:17 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > >
> > > Hi Adam
> > >
> > > On Mon, Nov 4, 2024 at 6:01 PM Adam Ford <aford173@gmail.com> wrote:
> > > >
> > > > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi
> > > > <michael@amarulasolutions.com> wrote:
> > > > >
> > > > > Hi Adam
> > > > >
> > > > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
> > > > > >
> > > > > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> > > > > > <michael@amarulasolutions.com> wrote:
> > > > > > >
> > > > > > > The osc_24m is the clock-output-name and not the one that
> > > > > > > is used as internal name reference from the strcmp. The clock
> > > > > > > that use osc_24m, will not be able to reparent it as they should.
> > > > > > > We need anyway register the osc_24m clock fixed factor in the clock
> > > > > > > tree.
> > > > > > >
> > > > > > > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > > > > > > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > > > > > > Cc: Marek Vasut <marex@denx.de>
> > > > > > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > > > > > ---
> > > > > > >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> > > > > > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > > > > > > index ed9e16d7c1..bfd1677520 100644
> > > > > > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > > > > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > > > > > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > > > >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> > > > > > >
> > > > > > >  #if CONFIG_IS_ENABLED(DM_SPI)
> > > > > > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > > >
> > > > > > > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > > >
> > > > > > > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > > >  #endif
> > > > > > > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > > > >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> > > > > > >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> > > > > > >
> > > > > > > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > > > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > > >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> > > > > > >                                                 "sys_pll2_250m", "video_pll_out", };
> > > > > > >
> > > > > > > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> > > > > > >
> > > > > > >  static int imx8mn_clk_probe(struct udevice *dev)
> > > > > > >  {
> > > > > > > +       struct clk osc_24m_clk;
> > > > > > >         void __iomem *base;
> > > > > > > +       int ret;
> > > > > > >
> > > > > > >         base = (void *)ANATOP_BASE_ADDR;
> > > > > > >
> > > > > > > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> > > > > > >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> > > > > > >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> > > > > > >
> > > > > >
> > > > > > I know it's late, but I didn't get around to testing my Nano board for
> > > > > > a while.  Sorry for the delayed feedback...
> > > > > >
> > > > > > > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > > > > +       if (ret)
> > > > > > > +               return ret;
> > > > > > > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > > > > > +
> > > > > >
> > > > > > These four lines appear to have introduced a regression on the
> > > > > > imx8mn-beacon board.  In the SPL phase, I get an error message
> > > > > > indicating it cannot find the i2c clk, then access to the PMIC fails.
> > > > > > If I remove these four lines, the error message disappears, and the
> > > > > > PMIC is happy again.
> > > > > >
> > > > > > I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> > > > > > the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> > > > > > = "osc_24m"
> > > > > >
> > > > > > I have also tried to mark the 24m clock as with bootph-pre-ram;:
> > > > > > &{/clock-osc-24m} {
> > > > > >   bootph-pre-ram;
> > > > > > };
> > > > > >
> > > > > > Unfortunately, nothing is helping, and I am not sure what else to try.
> > > > > > clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> > > > > > issue.  I need to the PMIC to increase the voltage since we run the
> > > > > > Nano in overdrive mode to run the LPDDR4 at the highest speed.
> > > > > >
> > > > > > Might anyone have any suggestions?
> > > > > >
> > > > >
> > > > > Not yet. I have a similar setup but I don't set pmic, so I think that
> > > > > the symbol is not find
> > > > > in SPL and it just fail clock registration. Is that possible?
> > > >
> > > > It does appear that the clock registration failed.   Since the system
> > > > does an early return, the I2C clocks among others are also not
> > > > registered which appears to cause the failure.
> > > >
> > > > I changed the registration around a little:
> > > >
> > > > ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > if (!ret)
> > > >         clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > >
> > >
> > > Seems that is not in the image spl so it can not find it. Are you sure
> > > that you can inside
> > > the SPL
> >
> > I am not sure I understand what you are asking, but the clock node
> > appears in spl/u-boot-spl.dtb:
> >
> >  clock-osc-24m {
> >                 compatible = "fixed-clock";
> >                 #clock-cells = <0x00>;
> >                 clock-frequency = <0x16e3600>;
> >                 clock-output-names = "osc_24m";
> >                 phandle = <0x18>;
> >         };
> >
> > Since the clock-output-names is "osc_24m" I wonder if clk_get_by_name
> > is the right function.  Looking at other uses of this function, it
> > looks like it's looking for a 'clock-names' parameter and not
> > clock-output-names.
>
> Yes, it's the right answer. That is strange because it works in uboot
> image. Is the node the same in uboot-dtb?

The U-Boot phase device tree looks like this:

 clock-osc-24m {
                compatible = "fixed-clock";
                #clock-cells = <0x00>;
                clock-frequency = <0x16e3600>;
                clock-output-names = "osc_24m";
                bootph-pre-ram;
                bootph-all;
                phandle = <0x18>;
        };

>
> Michael
>
> >
> > adam
> > >
> > > Michael
> > >
> > > > This method won't return prematurely, so the I2C and other clocks can
> > > > be registered, and it appears to address the problem.
> > > > Another alternative might be to move this clock registration until
> > > > after all the rest of the clocks are done.
> > > >
> > > > adam
> > > > >
> > > > > If (ret)
> > > > >
> > > > > put here a print
> > > > >
> > > > > Michael
> > > > > > adam
> > > > > >
> > > > > > >         base = dev_read_addr_ptr(dev);
> > > > > > >         if (!base)
> > > > > > >                 return -EINVAL;
> > > > > > > --
> > > > > > > 2.43.0
> > > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Michael Nazzareno Trimarchi
> > > > > Co-Founder & Chief Executive Officer
> > > > > M. +39 347 913 2170
> > > > > michael@amarulasolutions.com
> > > > > __________________________________
> > > > >
> > > > > Amarula Solutions BV
> > > > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > > > T. +31 (0)85 111 9172
> > > > > info@amarulasolutions.com
> > > > > www.amarulasolutions.com
> > >
> > >
> > >
> > > --
> > > Michael Nazzareno Trimarchi
> > > Co-Founder & Chief Executive Officer
> > > M. +39 347 913 2170
> > > michael@amarulasolutions.com
> > > __________________________________
> > >
> > > Amarula Solutions BV
> > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > T. +31 (0)85 111 9172
> > > info@amarulasolutions.com
> > > www.amarulasolutions.com
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Mon, Nov 4, 2024 at 11:24 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Mon, Nov 4, 2024 at 11:22 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi
> >
> > On Mon, Nov 4, 2024 at 6:17 PM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > On Mon, Nov 4, 2024 at 11:04 AM Michael Nazzareno Trimarchi
> > > <michael@amarulasolutions.com> wrote:
> > > >
> > > > Hi Adam
> > > >
> > > > On Mon, Nov 4, 2024 at 6:01 PM Adam Ford <aford173@gmail.com> wrote:
> > > > >
> > > > > On Mon, Nov 4, 2024 at 10:29 AM Michael Nazzareno Trimarchi
> > > > > <michael@amarulasolutions.com> wrote:
> > > > > >
> > > > > > Hi Adam
> > > > > >
> > > > > > On Mon, Nov 4, 2024 at 5:11 PM Adam Ford <aford173@gmail.com> wrote:
> > > > > > >
> > > > > > > On Sun, Jul 7, 2024 at 3:45 AM Michael Trimarchi
> > > > > > > <michael@amarulasolutions.com> wrote:
> > > > > > > >
> > > > > > > > The osc_24m is the clock-output-name and not the one that
> > > > > > > > is used as internal name reference from the strcmp. The clock
> > > > > > > > that use osc_24m, will not be able to reparent it as they should.
> > > > > > > > We need anyway register the osc_24m clock fixed factor in the clock
> > > > > > > > tree.
> > > > > > > >
> > > > > > > > Fixes: 710c4ffb890 ("clk: imx: clk-imx8mn add gpmi nand clocks")
> > > > > > > > Fixes: 85b1c11989c ("clk: imx: Add ECSPI to iMX8MN")
> > > > > > > > Cc: Marek Vasut <marex@denx.de>
> > > > > > > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > > > > > > ---
> > > > > > > >  drivers/clk/imx/clk-imx8mn.c | 15 +++++++++++----
> > > > > > > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> > > > > > > > index ed9e16d7c1..bfd1677520 100644
> > > > > > > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > > > > > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > > > > > > @@ -57,15 +57,15 @@ static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > > > > >                                            "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
> > > > > > > >
> > > > > > > >  #if CONFIG_IS_ENABLED(DM_SPI)
> > > > > > > > -static const char *imx8mn_ecspi1_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > > +static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > > > >
> > > > > > > > -static const char *imx8mn_ecspi2_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > > +static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > > > >
> > > > > > > > -static const char *imx8mn_ecspi3_sels[] = {"osc_24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > > +static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
> > > > > > > >                                            "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
> > > > > > > >                                            "sys_pll2_250m", "audio_pll2_out", };
> > > > > > > >  #endif
> > > > > > > > @@ -105,7 +105,7 @@ static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sy
> > > > > > > >  static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
> > > > > > > >                                            "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
> > > > > > > >
> > > > > > > > -static const char * const imx8mn_nand_sels[] = {"osc_24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > > > > +static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
> > > > > > > >                                                 "sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
> > > > > > > >                                                 "sys_pll2_250m", "video_pll_out", };
> > > > > > > >
> > > > > > > > @@ -119,7 +119,9 @@ static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_10
> > > > > > > >
> > > > > > > >  static int imx8mn_clk_probe(struct udevice *dev)
> > > > > > > >  {
> > > > > > > > +       struct clk osc_24m_clk;
> > > > > > > >         void __iomem *base;
> > > > > > > > +       int ret;
> > > > > > > >
> > > > > > > >         base = (void *)ANATOP_BASE_ADDR;
> > > > > > > >
> > > > > > > > @@ -238,6 +240,11 @@ static int imx8mn_clk_probe(struct udevice *dev)
> > > > > > > >         clk_dm(IMX8MN_SYS_PLL2_1000M,
> > > > > > > >                imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));
> > > > > > > >
> > > > > > >
> > > > > > > I know it's late, but I didn't get around to testing my Nano board for
> > > > > > > a while.  Sorry for the delayed feedback...
> > > > > > >
> > > > > > > > +       ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > > > > > +       if (ret)
> > > > > > > > +               return ret;
> > > > > > > > +       clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > > > > > > +
> > > > > > >
> > > > > > > These four lines appear to have introduced a regression on the
> > > > > > > imx8mn-beacon board.  In the SPL phase, I get an error message
> > > > > > > indicating it cannot find the i2c clk, then access to the PMIC fails.
> > > > > > > If I remove these four lines, the error message disappears, and the
> > > > > > > PMIC is happy again.
> > > > > > >
> > > > > > > I have confirmed that CLK, and SPL_CLK are both defined.   I checked
> > > > > > > the u-boot-spl.dtb and it shows clock-osc-24m with clock-output-names
> > > > > > > = "osc_24m"
> > > > > > >
> > > > > > > I have also tried to mark the 24m clock as with bootph-pre-ram;:
> > > > > > > &{/clock-osc-24m} {
> > > > > > >   bootph-pre-ram;
> > > > > > > };
> > > > > > >
> > > > > > > Unfortunately, nothing is helping, and I am not sure what else to try.
> > > > > > > clk_fixed_rate.o is built into my SPL, so I don't think it's a config
> > > > > > > issue.  I need to the PMIC to increase the voltage since we run the
> > > > > > > Nano in overdrive mode to run the LPDDR4 at the highest speed.
> > > > > > >
> > > > > > > Might anyone have any suggestions?
> > > > > > >
> > > > > >
> > > > > > Not yet. I have a similar setup but I don't set pmic, so I think that
> > > > > > the symbol is not find
> > > > > > in SPL and it just fail clock registration. Is that possible?
> > > > >
> > > > > It does appear that the clock registration failed.   Since the system
> > > > > does an early return, the I2C clocks among others are also not
> > > > > registered which appears to cause the failure.
> > > > >
> > > > > I changed the registration around a little:
> > > > >
> > > > > ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
> > > > > if (!ret)
> > > > >         clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));
> > > > >
> > > >
> > > > Seems that is not in the image spl so it can not find it. Are you sure
> > > > that you can inside
> > > > the SPL
> > >
> > > I am not sure I understand what you are asking, but the clock node
> > > appears in spl/u-boot-spl.dtb:
> > >
> > >  clock-osc-24m {
> > >                 compatible = "fixed-clock";
> > >                 #clock-cells = <0x00>;
> > >                 clock-frequency = <0x16e3600>;
> > >                 clock-output-names = "osc_24m";
> > >                 phandle = <0x18>;
> > >         };
> > >
> > > Since the clock-output-names is "osc_24m" I wonder if clk_get_by_name
> > > is the right function.  Looking at other uses of this function, it
> > > looks like it's looking for a 'clock-names' parameter and not
> > > clock-output-names.
> >
> > Yes, it's the right answer. That is strange because it works in uboot
> > image. Is the node the same in uboot-dtb?
>
> The U-Boot phase device tree looks like this:
>
>  clock-osc-24m {
>                 compatible = "fixed-clock";
>                 #clock-cells = <0x00>;
>                 clock-frequency = <0x16e3600>;
>                 clock-output-names = "osc_24m";
>                 bootph-pre-ram;
>                 bootph-all;
>                 phandle = <0x18>;
>         };
>

I did some more investigating, and  with the device tree debugging
turned on, I get the following:

U-Boot SPL 2025.01-rc1-00172-g14c2ad85629c-dirty (Nov 09 2024 - 17:10:26 -0600)
clk_set_defaults(i2c1grp)
clk_set_default_parents: could not read assigned-clock-parents for 970690
clk_set_defaults(i2c@30a20000)
clk_set_default_parents: could not read assigned-clock-parents for 970f30
clk_set_defaults(clock-controller@30380000)
clk_set_default_parents: could not read assigned-clock-parents for 970ab8
clk_set_defaults(clock-osc-24m)
clk_set_default_parents: could not read assigned-clock-parents for 9700f8
clk_set_defaults(clock-osc-24m)
clk_set_default_parents: could not read assigned-clock-parents for 9700f8
clk_get_by_name_nodev(node=92a30c, name=osc_24m, clk=96fca8)
clk_get_by_index_tail: Node 'clock-controller@30380000', property
'clocks', failed to request CLK index 1: -22
clk_get_by_index_tail: uclass_get_device_by_of_offset failed: err=-22
Failed to get i2c clk
clk_set_defaults(wdoggrp)
clk_set_default_parents: could not read assigned-clock-parents for 970858
clk_set_defaults(watchdog@30280000)
clk_set_default_parents: could not read assigned-clock-parents for 970500
WDT:   Not starting watchdog@30280000
clk_set_defaults(clock-controller@30380000)
clk_set_default_parents: could not read assigned-clock-parents for 970ab8
clk_get_by_name_nodev(node=92a30c, name=osc_24m, clk=96fd38)
clk_get_by_index_tail: Node 'clock-controller@30380000', property
'clocks', failed to request CLK index 1: -22
Failed to find clock node. Check device tree
Trying to boot from BOOTROM
Boot Stage: Recovery boot

-------

If I modify the code so that it doesn't return early and just skips
the clock registration phase like:
ret = clk_get_by_name(dev, "osc_24m", &osc_24m_clk);
if (!ret)
  clk_dm(IMX8MN_CLK_24M, dev_get_clk_ptr(osc_24m_clk.dev));

------


The above work-around appears to work, and the i2c appears to enable
the clock-osc-24m clock.:

U-Boot SPL 2025.01-rc1-00172-g14c2ad85629c-dirty (Nov 09 2024 - 17:16:06 -0600)
clk_set_defaults(i2c1grp)
clk_set_default_parents: could not read assigned-clock-parents for 970690
clk_set_defaults(i2c@30a20000)
clk_set_default_parents: could not read assigned-clock-parents for 970f30
clk_set_defaults(clock-controller@30380000)
clk_set_default_parents: could not read assigned-clock-parents for 970ab8
clk_set_defaults(clock-osc-24m)
clk_set_default_parents: could not read assigned-clock-parents for 9700f8
clk_set_defaults(clock-osc-24m)
clk_set_default_parents: could not read assigned-clock-parents for 9700f8
clk_get_by_name_nodev(node=92a2fc, name=osc_24m, clk=96fca8)
clk_get_by_index_tail: Node 'clock-controller@30380000', property
'clocks', failed to request CLK index 1: -22
clk_set_defaults(clock-controller@30380000)
clk_set_default_parents: could not read assigned-clock-parents for 970ab8
clk_of_xlate_default(clk=9712a8)
clk_request(dev=970ab8, clk=9712a8)
clk_enable(clk=9712a8 name=clock-controller@30380000)
clk_enable(clk=975180 name=i2c1)
clk_enable(clk=970190 name=clock-osc-24m)

I am not sure what the difference is between osc_24m and clock-osc-24m.

clk_get_rate(clk=9712a8)
clk_get_rate(clk=976980)
clk_get_parent_rate(clk=976980)
clk_get_parent(clk=976980)
clk_get_rate(clk=975180)
clk_get_parent_rate(clk=975180)
clk_get_parent(clk=975180)
clk_get_rate(clk=970190)
clk_set_defaults(pmicirqgrp)
clk_set_default_parents: could not read assigned-clock-parents for 970728
clk_set_defaults(pmic@4b)
clk_set_default_parents: could not read assigned-clock-parents for 970ff8
clk_set_defaults(wdoggrp)
clk_set_default_parents: could not read assigned-clock-parents for 970858
clk_set_defaults(watchdog@30280000)
clk_set_default_parents: could not read assigned-clock-parents for 970500
WDT:   Not starting watchdog@30280000
Trying to boot from BOOTROM

I am not really sure why, and / I was hoping someone might have an
idea.  If not, I might send a patch for this because without it, the
imx8mn_beacon board doesn't run at the proper voltage for the LPDDR4
controller.


adam
> >
> > Michael
> >
> > >
> > > adam
> > > >
> > > > Michael
> > > >
> > > > > This method won't return prematurely, so the I2C and other clocks can
> > > > > be registered, and it appears to address the problem.
> > > > > Another alternative might be to move this clock registration until
> > > > > after all the rest of the clocks are done.
> > > > >
> > > > > adam
> > > > > >
> > > > > > If (ret)
> > > > > >
> > > > > > put here a print
> > > > > >
> > > > > > Michael
> > > > > > > adam
> > > > > > >
> > > > > > > >         base = dev_read_addr_ptr(dev);
> > > > > > > >         if (!base)
> > > > > > > >                 return -EINVAL;
> > > > > > > > --
> > > > > > > > 2.43.0
> > > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Michael Nazzareno Trimarchi
> > > > > > Co-Founder & Chief Executive Officer
> > > > > > M. +39 347 913 2170
> > > > > > michael@amarulasolutions.com
> > > > > > __________________________________
> > > > > >
> > > > > > Amarula Solutions BV
> > > > > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > > > > T. +31 (0)85 111 9172
> > > > > > info@amarulasolutions.com
> > > > > > www.amarulasolutions.com
> > > >
> > > >
> > > >
> > > > --
> > > > Michael Nazzareno Trimarchi
> > > > Co-Founder & Chief Executive Officer
> > > > M. +39 347 913 2170
> > > > michael@amarulasolutions.com
> > > > __________________________________
> > > >
> > > > Amarula Solutions BV
> > > > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > > > T. +31 (0)85 111 9172
> > > > info@amarulasolutions.com
> > > > www.amarulasolutions.com
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael@amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info@amarulasolutions.com
> > www.amarulasolutions.com

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Fabio Estevam]

Hi Adam,

On Sat, Nov 9, 2024 at 8:23 PM Adam Ford <aford173@gmail.com> wrote:

> I did some more investigating, and  with the device tree debugging
> turned on, I get the following:
...
> clk_set_defaults(clock-controller@30380000)
> clk_set_default_parents: could not read assigned-clock-parents for 970ab8
> clk_get_by_name_nodev(node=92a30c, name=osc_24m, clk=96fd38)
> clk_get_by_index_tail: Node 'clock-controller@30380000', property
> 'clocks', failed to request CLK index 1: -22
> Failed to find clock node. Check device tree
> Trying to boot from BOOTROM
> Boot Stage: Recovery boot

Could you please test Marek's patch?

https://patchwork.ozlabs.org/project/uboot/patch/20241122015858.557561-1-marex@denx.de/

I plan to apply it for 2025.01 to fix this regression.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Fri, Nov 22, 2024 at 6:38 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Adam,
>
> On Sat, Nov 9, 2024 at 8:23 PM Adam Ford <aford173@gmail.com> wrote:
>
> > I did some more investigating, and  with the device tree debugging
> > turned on, I get the following:
> ...
> > clk_set_defaults(clock-controller@30380000)
> > clk_set_default_parents: could not read assigned-clock-parents for 970ab8
> > clk_get_by_name_nodev(node=92a30c, name=osc_24m, clk=96fd38)
> > clk_get_by_index_tail: Node 'clock-controller@30380000', property
> > 'clocks', failed to request CLK index 1: -22
> > Failed to find clock node. Check device tree
> > Trying to boot from BOOTROM
> > Boot Stage: Recovery boot
>
> Could you please test Marek's patch?
>
> https://patchwork.ozlabs.org/project/uboot/patch/20241122015858.557561-1-marex@denx.de/

Sure.  Do you want me to test it against a specific branch or the
master mainline branch?

adam
>
> I plan to apply it for 2025.01 to fix this regression.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Fabio Estevam]

On Fri, Nov 22, 2024 at 10:11 AM Adam Ford <aford173@gmail.com> wrote:

> Sure.  Do you want me to test it against a specific branch or the
> master mainline branch?

Master branch, please.

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

[Adam Ford]

On Fri, Nov 22, 2024 at 7:17 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Fri, Nov 22, 2024 at 10:11 AM Adam Ford <aford173@gmail.com> wrote:
>
> > Sure.  Do you want me to test it against a specific branch or the
> > master mainline branch?
>
> Master branch, please.

I should  have a response for you by Monday.

adam

[PATCH 2/4] clk: imx8mn: Make parent names arrays const pointers

[Michael Trimarchi]

The arrays containing the mux selectors need to be of const pointer
to const char.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 drivers/clk/imx/clk-imx8mn.c | 142 ++++++++++++++++++++---------------
 1 file changed, 81 insertions(+), 61 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index bfd1677520..8911e342f1 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -16,106 +16,126 @@
 
 static u32 share_count_nand;
 
-static const char *pll_ref_sels[] = { "clock-osc-24m", "dummy", "dummy", "dummy", };
-static const char *dram_pll_bypass_sels[] = {"dram_pll", "dram_pll_ref_sel", };
-static const char *arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", };
-static const char *sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel", };
-static const char *sys_pll2_bypass_sels[] = {"sys_pll2", "sys_pll2_ref_sel", };
-static const char *sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
+static const char * const pll_ref_sels[] = { "clock-osc-24m", "dummy", "dummy", "dummy", };
+static const char * const dram_pll_bypass_sels[] = {"dram_pll", "dram_pll_ref_sel", };
+static const char * const arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", };
+static const char * const sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel", };
+static const char * const sys_pll2_bypass_sels[] = {"sys_pll2", "sys_pll2_ref_sel", };
+static const char * const sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
 
-static const char *imx8mn_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m", "sys_pll2_1000m",
-					"sys_pll1_800m", "sys_pll1_400m", "audio_pll1_out", "sys_pll3_out", };
+static const char * const imx8mn_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m",
+					       "sys_pll2_1000m", "sys_pll1_800m", "sys_pll1_400m",
+					       "audio_pll1_out", "sys_pll3_out", };
 
-static const char *imx8mn_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
-					"sys_pll2_125m", "sys_pll3_out", "audio_pll1_out", "video_pll_out", };
+static const char * const imx8mn_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m",
+					       "sys_pll1_400m", "sys_pll2_125m", "sys_pll3_out",
+					       "audio_pll1_out", "video_pll_out", };
 
-static const char *imx8mn_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_250m",
-					     "sys_pll2_200m", "audio_pll1_out", "video_pll_out", "sys_pll3_out", };
+static const char * const imx8mn_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
+						    "sys_pll2_250m", "sys_pll2_200m", "audio_pll1_out",
+						    "video_pll_out", "sys_pll3_out", };
 
 #ifndef CONFIG_SPL_BUILD
-static const char *imx8mn_enet_ref_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m", "sys_pll2_100m",
-					     "sys_pll1_160m", "audio_pll1_out", "video_pll_out", "clk_ext4", };
+static const char * const imx8mn_enet_ref_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m",
+						    "sys_pll2_100m", "sys_pll1_160m", "audio_pll1_out",
+						    "video_pll_out", "clk_ext4", };
 
-static const char *imx8mn_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out", "clk_ext1", "clk_ext2",
-					       "clk_ext3", "clk_ext4", "video_pll_out", };
+static const char * const imx8mn_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out",
+						      "clk_ext1", "clk_ext2", "clk_ext3",
+						      "clk_ext4", "video_pll_out", };
 
-static const char *imx8mn_enet_phy_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m", "sys_pll2_200m",
-					     "sys_pll2_500m", "audio_pll1_out", "video_pll_out", "audio_pll2_out", };
+static const char * const imx8mn_enet_phy_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m",
+						    "sys_pll2_200m", "sys_pll2_500m", "audio_pll1_out",
+						    "video_pll_out", "audio_pll2_out", };
 #endif
 
-static const char *imx8mn_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_200m",
-					       "sys_pll1_133m", "sys_pll3_out", "sys_pll2_250m", "audio_pll1_out", };
+static const char * const imx8mn_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
+						      "sys_pll2_200m", "sys_pll1_133m", "sys_pll3_out",
+						      "sys_pll2_250m", "audio_pll1_out", };
 
 static const char * const imx8mn_usb_bus_sels[] = {"clock-osc-24m", "sys_pll2_500m", "sys_pll1_800m",
-						"sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
-						"clk_ext4", "audio_pll2_out", };
+						   "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						   "clk_ext4", "audio_pll2_out", };
 
-static const char *imx8mn_usdhc1_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
-					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mn_usdhc1_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
-static const char *imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
-					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mn_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
 #if CONFIG_IS_ENABLED(DM_SPI)
-static const char *imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
-					   "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
-					   "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mn_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
-					   "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
-					   "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mn_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
-					   "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
-					   "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mn_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_250m", "audio_pll2_out", };
 #endif
 
-static const char *imx8mn_i2c1_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mn_i2c1_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mn_i2c2_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mn_i2c2_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mn_i2c3_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mn_i2c3_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mn_i2c4_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mn_i2c4_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
 #ifndef CONFIG_SPL_BUILD
-static const char *imx8mn_pwm1_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext1", "sys_pll1_80m", "video_pll_out", };
+static const char * const imx8mn_pwm1_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
+						"sys_pll1_80m", "video_pll_out", };
 
-static const char *imx8mn_pwm2_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext1", "sys_pll1_80m", "video_pll_out", };
+static const char * const imx8mn_pwm2_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
+						"sys_pll1_80m", "video_pll_out", };
 
-static const char *imx8mn_pwm3_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext2", "sys_pll1_80m", "video_pll_out", };
+static const char * const imx8mn_pwm3_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
+						"sys_pll1_80m", "video_pll_out", };
 
-static const char *imx8mn_pwm4_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext2", "sys_pll1_80m", "video_pll_out", };
+static const char * const imx8mn_pwm4_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
+						"sys_pll1_80m", "video_pll_out", };
 #endif
 
-static const char *imx8mn_wdog_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_160m", "m7_alt_pll",
-					 "sys_pll2_125m", "sys_pll3_out", "sys_pll1_80m", "sys_pll2_166m", };
+static const char * const imx8mn_wdog_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_160m",
+						"m7_alt_pll", "sys_pll2_125m", "sys_pll3_out",
+						"sys_pll1_80m", "sys_pll2_166m", };
 
-static const char *imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
-					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_clk", "sys_pll1_100m", };
+static const char * const imx8mn_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_clk", "sys_pll1_100m", };
 
-static const char *imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
-					   "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
+static const char * const imx8mn_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m",
+						"sys_pll2_500m", "audio_pll2_out", "sys_pll1_266m",
+						"sys_pll3_out", "sys_pll1_100m", };
 
 static const char * const imx8mn_nand_sels[] = {"clock-osc-24m", "sys_pll2_500m", "audio_pll1_out",
 						"sys_pll1_400m", "audio_pll2_out", "sys_pll3_out",
 						"sys_pll2_250m", "video_pll_out", };
 
 static const char * const imx8mn_usb_core_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
-						"sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
-						"clk_ext3", "audio_pll2_out", };
+						    "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						    "clk_ext3", "audio_pll2_out", };
 
 static const char * const imx8mn_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
-						"sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
-						"clk_ext3", "audio_pll2_out", };
+						   "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						   "clk_ext3", "audio_pll2_out", };
 
 static int imx8mn_clk_probe(struct udevice *dev)
 {
-- 
2.43.0

[PATCH 3/4] clk: imx8mm: Make parent names arrays const pointers

[Michael Trimarchi]

The arrays containing the mux selectors need to be of const pointer
to const char.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 drivers/clk/imx/clk-imx8mm.c | 157 +++++++++++++++++++++--------------
 1 file changed, 93 insertions(+), 64 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 70e2e53bde..e538f047b3 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -14,108 +14,137 @@
 
 #include "clk.h"
 
-static const char *pll_ref_sels[] = { "clock-osc-24m", "dummy", "dummy", "dummy", };
-static const char *dram_pll_bypass_sels[] = {"dram_pll", "dram_pll_ref_sel", };
-static const char *arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", };
-static const char *sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel", };
-static const char *sys_pll2_bypass_sels[] = {"sys_pll2", "sys_pll2_ref_sel", };
-static const char *sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
+static const char * const pll_ref_sels[] = { "clock-osc-24m", "dummy", "dummy", "dummy", };
+static const char * const dram_pll_bypass_sels[] = {"dram_pll", "dram_pll_ref_sel", };
+static const char * const arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", };
+static const char * const sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel", };
+static const char * const sys_pll2_bypass_sels[] = {"sys_pll2", "sys_pll2_ref_sel", };
+static const char * const sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
 
-static const char *imx8mm_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m", "sys_pll2_1000m",
-					"sys_pll1_800m", "sys_pll1_400m", "audio_pll1_out", "sys_pll3_out", };
+static const char * const imx8mm_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m",
+					       "sys_pll2_1000m", "sys_pll1_800m", "sys_pll1_400m",
+					       "audio_pll1_out", "sys_pll3_out", };
 
-static const char *imx8mm_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
-					"sys_pll2_125m", "sys_pll3_out", "audio_pll1_out", "video_pll1_out", };
+static const char * const imx8mm_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m",
+					       "sys_pll1_400m", "sys_pll2_125m", "sys_pll3_out",
+					       "audio_pll1_out", "video_pll1_out", };
 
 #ifndef CONFIG_SPL_BUILD
-static const char *imx8mm_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_250m",
-					     "sys_pll2_200m", "audio_pll1_out", "video_pll1_out", "sys_pll3_out", };
+static const char * const imx8mm_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
+						    "sys_pll2_250m", "sys_pll2_200m", "audio_pll1_out",
+						    "video_pll1_out", "sys_pll3_out", };
 
-static const char *imx8mm_enet_ref_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m", "sys_pll2_100m",
-					     "sys_pll1_160m", "audio_pll1_out", "video_pll1_out", "clk_ext4", };
+static const char * const imx8mm_enet_ref_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m",
+						    "sys_pll2_100m", "sys_pll1_160m", "audio_pll1_out",
+						    "video_pll1_out", "clk_ext4", };
 
-static const char *imx8mm_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out", "clk_ext1", "clk_ext2",
-					       "clk_ext3", "clk_ext4", "video_pll1_out", };
+static const char * const imx8mm_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out",
+						      "clk_ext1", "clk_ext2", "clk_ext3",
+						      "clk_ext4", "video_pll1_out", };
 
-static const char *imx8mm_enet_phy_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m", "sys_pll2_200m",
-					     "sys_pll2_500m", "video_pll1_out", "audio_pll2_out", };
+static const char * const imx8mm_enet_phy_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m",
+						    "sys_pll2_200m", "sys_pll2_500m", "video_pll1_out",
+						    "audio_pll2_out", };
 #endif
 
-static const char *imx8mm_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_200m",
-					       "sys_pll1_133m", "sys_pll3_out", "sys_pll2_250m", "audio_pll1_out", };
+static const char * const imx8mm_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
+						      "sys_pll2_200m", "sys_pll1_133m", "sys_pll3_out",
+						      "sys_pll2_250m", "audio_pll1_out", };
 
-static const char *imx8mm_usb_bus_sels[] = {"clock-osc-24m", "sys_pll2_500m", "sys_pll1_800m", "sys_pll2_100m",
-					    "sys_pll2_200m", "clk_ext2", "clk_ext4", "audio_pll2_out", };
+static const char * const imx8mm_usb_bus_sels[] = {"clock-osc-24m", "sys_pll2_500m", "sys_pll1_800m",
+						   "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						   "clk_ext4", "audio_pll2_out", };
 
-static const char *imx8mm_usdhc1_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
-					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mm_usdhc1_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
-static const char *imx8mm_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
-					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mm_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
-static const char *imx8mm_i2c1_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll1_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mm_i2c1_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mm_i2c2_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll1_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mm_i2c2_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mm_i2c3_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll1_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mm_i2c3_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mm_i2c4_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
-					 "video_pll1_out", "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mm_i2c4_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
 #if CONFIG_IS_ENABLED(PCIE_DW_IMX)
-static const char *imx8mm_pcie1_ctrl_sels[] = {"clock-osc-24m", "sys_pll2_250m", "sys_pll2_200m", "sys_pll1_266m",
-					       "sys_pll1_800m", "sys_pll2_500m", "sys_pll2_333m", "sys_pll3_out", };
+static const char * const imx8mm_pcie1_ctrl_sels[] = {"clock-osc-24m", "sys_pll2_250m", "sys_pll2_200m",
+						      "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_500m",
+						      "sys_pll2_333m", "sys_pll3_out", };
 
-static const char *imx8mm_pcie1_phy_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll2_500m", "clk_ext1", "clk_ext2",
-					      "clk_ext3", "clk_ext4", "sys_pll1_400m", };
+static const char * const imx8mm_pcie1_phy_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll2_500m",
+						     "clk_ext1", "clk_ext2", "clk_ext3",
+						     "clk_ext4", "sys_pll1_400m", };
 
-static const char *imx8mm_pcie1_aux_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll2_50m", "sys_pll3_out",
-					      "sys_pll2_100m", "sys_pll1_80m", "sys_pll1_160m", "sys_pll1_200m", };
+static const char * const imx8mm_pcie1_aux_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll2_50m",
+						     "sys_pll3_out", "sys_pll2_100m", "sys_pll1_80m",
+						     "sys_pll1_160m", "sys_pll1_200m", };
 #endif
 
 #ifndef CONFIG_SPL_BUILD
-static const char *imx8mm_pwm1_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext1", "sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mm_pwm1_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mm_pwm2_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext1", "sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mm_pwm2_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mm_pwm3_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext2", "sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mm_pwm3_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mm_pwm4_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m", "sys_pll1_40m",
-					 "sys_pll3_out", "clk_ext2", "sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mm_pwm4_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
+						"sys_pll1_80m", "video_pll1_out", };
 #endif
 
-static const char *imx8mm_wdog_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_160m", "vpu_pll_out",
-					 "sys_pll2_125m", "sys_pll3_out", "sys_pll1_80m", "sys_pll2_166m", };
+static const char * const imx8mm_wdog_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_160m",
+						"vpu_pll_out", "sys_pll2_125m", "sys_pll3_out",
+						"sys_pll1_80m", "sys_pll2_166m", };
 
-static const char *imx8mm_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
-					   "sys_pll3_out", "sys_pll1_266m", "audio_pll2_clk", "sys_pll1_100m", };
+static const char * const imx8mm_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_clk", "sys_pll1_100m", };
 
 #if CONFIG_IS_ENABLED(NXP_FSPI)
-static const char *imx8mm_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m", "sys_pll2_500m",
-					   "audio_pll2_out", "sys_pll1_266m", "sys_pll3_out", "sys_pll1_100m", };
+static const char * const imx8mm_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m",
+						"sys_pll2_500m", "audio_pll2_out", "sys_pll1_266m",
+						"sys_pll3_out", "sys_pll1_100m", };
 #endif
 
-static const char *imx8mm_usb_core_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m", "sys_pll2_100m",
-					     "sys_pll2_200m", "clk_ext2", "clk_ext3", "audio_pll2_out", };
+static const char * const imx8mm_usb_core_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
+						    "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						    "clk_ext3", "audio_pll2_out", };
 
-static const char *imx8mm_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m", "sys_pll2_100m",
-					     "sys_pll2_200m", "clk_ext2", "clk_ext3", "audio_pll2_out", };
+static const char * const imx8mm_usb_phy_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
+						   "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						   "clk_ext3", "audio_pll2_out", };
 
 #if CONFIG_IS_ENABLED(DM_SPI)
-static const char *imx8mm_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m", "sys_pll1_160m",
-					   "sys_pll1_800m", "sys_pll3_out", "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mm_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mm_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m", "sys_pll1_160m",
-					   "sys_pll1_800m", "sys_pll3_out", "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mm_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mm_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m", "sys_pll1_160m",
-					   "sys_pll1_800m", "sys_pll3_out", "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mm_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_250m", "audio_pll2_out", };
 #endif
 
 static int imx8mm_clk_probe(struct udevice *dev)
-- 
2.43.0

[PATCH 4/4] clk: imx8mp: Make parent names arrays const pointers

[Michael Trimarchi]

The arrays containing the mux selectors need to be of const pointer
to const char.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 drivers/clk/imx/clk-imx8mp.c | 242 +++++++++++++++++------------------
 1 file changed, 121 insertions(+), 121 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index 1f498b6ba4..6b18483c81 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -14,178 +14,178 @@
 
 #include "clk.h"
 
-static const char *pll_ref_sels[] = { "clock-osc-24m", "dummy", "dummy", "dummy", };
-static const char *dram_pll_bypass_sels[] = {"dram_pll", "dram_pll_ref_sel", };
-static const char *arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", };
-static const char *sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel", };
-static const char *sys_pll2_bypass_sels[] = {"sys_pll2", "sys_pll2_ref_sel", };
-static const char *sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
+static const char * const pll_ref_sels[] = { "clock-osc-24m", "dummy", "dummy", "dummy", };
+static const char * const dram_pll_bypass_sels[] = {"dram_pll", "dram_pll_ref_sel", };
+static const char * const arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", };
+static const char * const sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel", };
+static const char * const sys_pll2_bypass_sels[] = {"sys_pll2", "sys_pll2_ref_sel", };
+static const char * const sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
 
-static const char *imx8mp_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m",
-					"sys_pll2_1000m", "sys_pll1_800m", "sys_pll1_400m",
-					"audio_pll1_out", "sys_pll3_out", };
+static const char * const imx8mp_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m",
+					       "sys_pll2_1000m", "sys_pll1_800m", "sys_pll1_400m",
+					       "audio_pll1_out", "sys_pll3_out", };
 
-static const char *imx8mp_hsio_axi_sels[] = {"clock-osc-24m", "sys_pll2_500m", "sys_pll1_800m",
-					     "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
-					     "clk_ext4", "audio_pll2_out", };
+static const char * const imx8mp_hsio_axi_sels[] = {"clock-osc-24m", "sys_pll2_500m", "sys_pll1_800m",
+						    "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						    "clk_ext4", "audio_pll2_out", };
 
-static const char *imx8mp_main_axi_sels[] = {"clock-osc-24m", "sys_pll2_333m", "sys_pll1_800m",
-					     "sys_pll2_250m", "sys_pll2_1000m", "audio_pll1_out",
-					     "video_pll1_out", "sys_pll1_100m",};
+static const char * const imx8mp_main_axi_sels[] = {"clock-osc-24m", "sys_pll2_333m", "sys_pll1_800m",
+						    "sys_pll2_250m", "sys_pll2_1000m", "audio_pll1_out",
+						    "video_pll1_out", "sys_pll1_100m",};
 
-static const char *imx8mp_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
-					     "sys_pll2_250m", "sys_pll2_200m", "audio_pll1_out",
-					     "video_pll1_out", "sys_pll3_out", };
+static const char * const imx8mp_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
+						    "sys_pll2_250m", "sys_pll2_200m", "audio_pll1_out",
+						    "video_pll1_out", "sys_pll3_out", };
 
-static const char *imx8mp_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
-					       "sys_pll2_200m", "sys_pll1_133m", "sys_pll3_out",
-					       "sys_pll2_250m", "audio_pll1_out", };
+static const char * const imx8mp_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m",
+						      "sys_pll2_200m", "sys_pll1_133m", "sys_pll3_out",
+						      "sys_pll2_250m", "audio_pll1_out", };
 
-static const char *imx8mp_noc_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll3_out",
-					"sys_pll2_1000m", "sys_pll2_500m", "audio_pll1_out",
-					"video_pll1_out", "audio_pll2_out", };
+static const char * const imx8mp_noc_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll3_out",
+					       "sys_pll2_1000m", "sys_pll2_500m", "audio_pll1_out",
+					       "video_pll1_out", "audio_pll2_out", };
 
-static const char *imx8mp_noc_io_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll3_out",
-					   "sys_pll2_1000m", "sys_pll2_500m", "audio_pll1_out",
-					   "video_pll1_out", "audio_pll2_out", };
+static const char * const imx8mp_noc_io_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll3_out",
+						  "sys_pll2_1000m", "sys_pll2_500m", "audio_pll1_out",
+						  "video_pll1_out", "audio_pll2_out", };
 
-static const char *imx8mp_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m",
-					"sys_pll1_400m", "sys_pll2_125m", "sys_pll3_out",
-					"audio_pll1_out", "video_pll1_out", };
+static const char * const imx8mp_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m",
+					       "sys_pll1_400m", "sys_pll2_125m", "sys_pll3_out",
+					       "audio_pll1_out", "video_pll1_out", };
 
-static const char *imx8mp_dram_alt_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll1_100m",
-					     "sys_pll2_500m", "sys_pll2_1000m", "sys_pll3_out",
-					     "audio_pll1_out", "sys_pll1_266m", };
+static const char * const imx8mp_dram_alt_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll1_100m",
+						    "sys_pll2_500m", "sys_pll2_1000m", "sys_pll3_out",
+						    "audio_pll1_out", "sys_pll1_266m", };
 
-static const char *imx8mp_dram_apb_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
-					     "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
-					     "sys_pll2_250m", "audio_pll2_out", };
+static const char * const imx8mp_dram_apb_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+						    "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
+						    "sys_pll2_250m", "audio_pll2_out", };
 
 static const char * const imx8mp_pcie_aux_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll2_50m",
 						    "sys_pll3_out", "sys_pll2_100m", "sys_pll1_80m",
 						    "sys_pll1_160m", "sys_pll1_200m", };
 
-static const char *imx8mp_i2c5_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
-					 "sys_pll3_out", "audio_pll1_out", "video_pll1_out",
-					 "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mp_i2c5_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mp_i2c6_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
-					 "sys_pll3_out", "audio_pll1_out", "video_pll1_out",
-					 "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mp_i2c6_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mp_enet_qos_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m",
-					     "sys_pll2_100m", "sys_pll1_160m", "audio_pll1_out",
-					     "video_pll1_out", "clk_ext4", };
+static const char * const imx8mp_enet_qos_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m",
+						    "sys_pll2_100m", "sys_pll1_160m", "audio_pll1_out",
+						    "video_pll1_out", "clk_ext4", };
 
-static const char *imx8mp_enet_qos_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out",
-						   "clk_ext1", "clk_ext2", "clk_ext3",
-						   "clk_ext4", "video_pll1_out", };
+static const char * const imx8mp_enet_qos_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out",
+							  "clk_ext1", "clk_ext2", "clk_ext3",
+							  "clk_ext4", "video_pll1_out", };
 
-static const char *imx8mp_usdhc1_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
-					   "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
-					   "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mp_usdhc1_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
-static const char *imx8mp_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
-					   "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
-					   "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mp_usdhc2_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
-static const char *imx8mp_i2c1_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
-					 "sys_pll3_out", "audio_pll1_out", "video_pll1_out",
-					 "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mp_i2c1_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mp_i2c2_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
-					 "sys_pll3_out", "audio_pll1_out", "video_pll1_out",
-					 "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mp_i2c2_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mp_i2c3_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
-					 "sys_pll3_out", "audio_pll1_out", "video_pll1_out",
-					 "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mp_i2c3_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mp_i2c4_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
-					 "sys_pll3_out", "audio_pll1_out", "video_pll1_out",
-					 "audio_pll2_out", "sys_pll1_133m", };
+static const char * const imx8mp_i2c4_sels[] = {"clock-osc-24m", "sys_pll1_160m", "sys_pll2_50m",
+						"sys_pll3_out", "audio_pll1_out", "video_pll1_out",
+						"audio_pll2_out", "sys_pll1_133m", };
 
-static const char *imx8mp_uart1_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
-					  "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
-					  "clk_ext4", "audio_pll2_out", };
+static const char * const imx8mp_uart1_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
+						 "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
+						 "clk_ext4", "audio_pll2_out", };
 
-static const char *imx8mp_uart2_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
-					  "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
-					  "clk_ext3", "audio_pll2_out", };
-
-static const char *imx8mp_uart3_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
-					  "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
-					  "clk_ext4", "audio_pll2_out", };
+static const char * const imx8mp_uart2_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
+						 "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
+						 "clk_ext3", "audio_pll2_out", };
 
-static const char *imx8mp_uart4_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
-					  "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
-					  "clk_ext3", "audio_pll2_out", };
+static const char * const imx8mp_uart3_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
+						 "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
+						 "clk_ext4", "audio_pll2_out", };
 
-static const char *imx8mp_usb_core_ref_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
-						 "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+static const char * const imx8mp_uart4_sels[] = {"clock-osc-24m", "sys_pll1_80m", "sys_pll2_200m",
+						 "sys_pll2_100m", "sys_pll3_out", "clk_ext2",
 						 "clk_ext3", "audio_pll2_out", };
 
-static const char *imx8mp_usb_phy_ref_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
-					        "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
-					        "clk_ext3", "audio_pll2_out", };
+static const char * const imx8mp_usb_core_ref_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
+							"sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+							"clk_ext3", "audio_pll2_out", };
+
+static const char * const imx8mp_usb_phy_ref_sels[] = {"clock-osc-24m", "sys_pll1_100m", "sys_pll1_40m",
+						       "sys_pll2_100m", "sys_pll2_200m", "clk_ext2",
+						       "clk_ext3", "audio_pll2_out", };
 
-static const char *imx8mp_gic_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
-					"sys_pll2_100m", "sys_pll1_800m",
-					"sys_pll2_500m", "clk_ext4", "audio_pll2_out" };
+static const char * const imx8mp_gic_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+					       "sys_pll2_100m", "sys_pll1_800m",
+					       "sys_pll2_500m", "clk_ext4", "audio_pll2_out" };
 
-static const char *imx8mp_pwm1_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
-					"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
-					"sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mp_pwm1_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mp_pwm2_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
-					"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
-					"sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mp_pwm2_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext1",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mp_pwm3_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
-					"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
-					"sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mp_pwm3_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mp_pwm4_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
-					"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
-					"sys_pll1_80m", "video_pll1_out", };
+static const char * const imx8mp_pwm4_sels[] = {"clock-osc-24m", "sys_pll2_100m", "sys_pll1_160m",
+						"sys_pll1_40m", "sys_pll3_out", "clk_ext2",
+						"sys_pll1_80m", "video_pll1_out", };
 
-static const char *imx8mp_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+static const char * const imx8mp_ecspi1_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
 						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
 						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mp_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+static const char * const imx8mp_ecspi2_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
 						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
 						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mp_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
+static const char * const imx8mp_ecspi3_sels[] = {"clock-osc-24m", "sys_pll2_200m", "sys_pll1_40m",
 						  "sys_pll1_160m", "sys_pll1_800m", "sys_pll3_out",
 						  "sys_pll2_250m", "audio_pll2_out", };
 
-static const char *imx8mp_wdog_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_160m",
-					 "vpu_pll_out", "sys_pll2_125m", "sys_pll3_out",
-					 "sys_pll1_80m", "sys_pll2_166m" };
+static const char * const imx8mp_wdog_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_160m",
+						"vpu_pll_out", "sys_pll2_125m", "sys_pll3_out",
+						"sys_pll1_80m", "sys_pll2_166m" };
 
-static const char *imx8mp_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m",
-					 "sys_pll2_500m", "audio_pll2_out", "sys_pll1_266m",
-					 "sys_pll3_out", "sys_pll1_100m", };
+static const char * const imx8mp_qspi_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll2_333m",
+						"sys_pll2_500m", "audio_pll2_out", "sys_pll1_266m",
+						"sys_pll3_out", "sys_pll1_100m", };
 
-static const char *imx8mp_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
-					   "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
-					   "audio_pll2_out", "sys_pll1_100m", };
+static const char * const imx8mp_usdhc3_sels[] = {"clock-osc-24m", "sys_pll1_400m", "sys_pll1_800m",
+						  "sys_pll2_500m", "sys_pll3_out", "sys_pll1_266m",
+						  "audio_pll2_out", "sys_pll1_100m", };
 
-static const char *imx8mp_enet_ref_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m",
-					     "sys_pll2_100m", "sys_pll1_160m", "audio_pll1_out",
-					     "video_pll1_out", "clk_ext4", };
+static const char * const imx8mp_enet_ref_sels[] = {"clock-osc-24m", "sys_pll2_125m", "sys_pll2_50m",
+						    "sys_pll2_100m", "sys_pll1_160m", "audio_pll1_out",
+						    "video_pll1_out", "clk_ext4", };
 
-static const char *imx8mp_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out",
-					       "clk_ext1", "clk_ext2", "clk_ext3",
-					       "clk_ext4", "video_pll1_out", };
+static const char * const imx8mp_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", "audio_pll1_out",
+						      "clk_ext1", "clk_ext2", "clk_ext3",
+						      "clk_ext4", "video_pll1_out", };
 
-static const char *imx8mp_enet_phy_ref_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m",
-						 "sys_pll2_200m", "sys_pll2_500m", "audio_pll1_out",
-						 "video_pll1_out", "audio_pll2_out", };
+static const char * const imx8mp_enet_phy_ref_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m",
+							"sys_pll2_200m", "sys_pll2_500m", "audio_pll1_out",
+							"video_pll1_out", "audio_pll2_out", };
 
-static const char *imx8mp_dram_core_sels[] = {"dram_pll_out", "dram_alt_root", };
+static const char * const imx8mp_dram_core_sels[] = {"dram_pll_out", "dram_alt_root", };
 
 static int imx8mp_clk_probe(struct udevice *dev)
 {
-- 
2.43.0