All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil V L <sunilvl@ventanamicro.com>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Bin Meng <bmeng.cn@gmail.com>, Weiwei Li <liwei1518@gmail.com>,
	Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
	Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Ani Sinha <anisinha@redhat.com>,
	Sunil V L <sunilvl@ventanamicro.com>
Subject: [PATCH v2 6/9] tests/qtest/bios-tables-test.c: Remove the fall back path
Date: Mon,  8 Jul 2024 17:17:38 +0530	[thread overview]
Message-ID: <20240708114741.3499585-7-sunilvl@ventanamicro.com> (raw)
In-Reply-To: <20240708114741.3499585-1-sunilvl@ventanamicro.com>

The expected ACPI AML files are moved now under ${arch}/{machine} path.
Hence, there is no need to search in old path which didn't have ${arch}.
Remove the code which searches for the expected AML files under old path
as well.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
 tests/qtest/bios-tables-test.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index f4c4704bab..498e0e35d9 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -267,15 +267,6 @@ static void dump_aml_files(test_data *data, bool rebuild)
                                        data->arch, data->machine,
                                        sdt->aml, ext);
 
-            /*
-             * To keep test cases not failing before the DATA files are moved to
-             * ${arch}/${machine} folder, add this check as well.
-             */
-            if (!g_file_test(aml_file, G_FILE_TEST_EXISTS)) {
-                aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir,
-                                           data->machine, sdt->aml, ext);
-            }
-
             if (!g_file_test(aml_file, G_FILE_TEST_EXISTS) &&
                 sdt->aml_len == exp_sdt->aml_len &&
                 !memcmp(sdt->aml, exp_sdt->aml, sdt->aml_len)) {
@@ -412,11 +403,6 @@ static GArray *load_expected_aml(test_data *data)
 try_again:
         aml_file = g_strdup_printf("%s/%s/%s/%.4s%s", data_dir, data->arch,
                                    data->machine, sdt->aml, ext);
-        if (!g_file_test(aml_file, G_FILE_TEST_EXISTS)) {
-            aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir, data->machine,
-                                       sdt->aml, ext);
-        }
-
         if (verbosity_level >= 2) {
             fprintf(stderr, "Looking for expected file '%s'\n", aml_file);
         }
-- 
2.43.0



  parent reply	other threads:[~2024-07-08 11:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 11:47 [PATCH v2 0/9] RISC-V: ACPI: Namespace updates Sunil V L
2024-07-08 11:47 ` [PATCH v2 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC Sunil V L
2024-07-11 13:17   ` Igor Mammedov
2024-07-11 13:21   ` Igor Mammedov
2024-07-08 11:47 ` [PATCH v2 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART Sunil V L
2024-07-11 13:25   ` Igor Mammedov
2024-07-11 14:41     ` Michael S. Tsirkin
2024-07-12  5:07       ` Sunil V L
2024-07-08 11:47 ` [PATCH v2 3/9] tests/acpi: Allow DSDT acpi table changes for aarch64 Sunil V L
2024-07-11 13:53   ` Igor Mammedov
2024-07-08 11:47 ` [PATCH v2 4/9] acpi/gpex: Create PCI link devices outside PCI root bridge Sunil V L
2024-07-11 13:43   ` Igor Mammedov
2024-07-08 11:47 ` [PATCH v2 5/9] tests/acpi: update expected DSDT blob for aarch64 and microvm Sunil V L
2024-07-08 11:47 ` Sunil V L [this message]
2024-07-10  0:54   ` [PATCH v2 6/9] tests/qtest/bios-tables-test.c: Remove the fall back path Alistair Francis
2024-07-11 13:53   ` Igor Mammedov
2024-07-08 11:47 ` [PATCH v2 7/9] tests/acpi: Add empty ACPI data files for RISC-V Sunil V L
2024-07-08 11:47 ` [PATCH v2 8/9] tests/qtest/bios-tables-test.c: Enable basic testing " Sunil V L
2024-07-08 11:47 ` [PATCH v2 9/9] tests/acpi: Add expected ACPI AML files " Sunil V L
2024-07-12 12:43 ` [PATCH v2 0/9] RISC-V: ACPI: Namespace updates Igor Mammedov
2024-07-12 12:51   ` Daniel P. Berrangé
2024-07-12 13:50     ` Igor Mammedov
2024-07-14  7:46       ` Michael S. Tsirkin
2024-07-15 12:43         ` Igor Mammedov
2024-07-16 12:26           ` Sunil V L
2024-07-16 14:28             ` Igor Mammedov
2024-07-16 14:33               ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708114741.3499585-7-sunilvl@ventanamicro.com \
    --to=sunilvl@ventanamicro.com \
    --cc=alistair.francis@wdc.com \
    --cc=anisinha@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=imammedo@redhat.com \
    --cc=liwei1518@gmail.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.