From: Oleg Nesterov <oleg@redhat.com>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
io-uring@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
Tycho Andersen <tandersen@netflix.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Julian Orth <ju.orth@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] kernel: rerun task_work while freezing in get_signal()
Date: Tue, 9 Jul 2024 21:38:29 +0200 [thread overview]
Message-ID: <20240709193828.GC3892@redhat.com> (raw)
In-Reply-To: <d2667002-1631-4f42-8aad-a9ea56c0762b@gmail.com>
On 07/09, Pavel Begunkov wrote:
>
> On 7/9/24 20:07, Oleg Nesterov wrote:
> >Hi Tejun,
> >
> >Thanks for looking at this, can you review this V2 patch from Pavel?
Just in case, I obviously meant our next (V2) patch
[PATCH v2 2/2] kernel: rerun task_work while freezing in get_signal()
https://lore.kernel.org/all/149ff5a762997c723880751e8a4019907a0b6457.1720534425.git.asml.silence@gmail.com/
> >Well, I don't really understand what can snapshot/restore actually mean...
>
> CRIU, I assume. I'll try it ...
Than I think we can forget about task_works and this patch. CRIU dumps
the tasks in TASK_TRACED state.
> ... but I'm inclined to think the patch makes sense regardless,
> we're replacing an infinite loop with wait-wake-execute-wait.
Agreed.
Oleg.
next prev parent reply other threads:[~2024-07-09 19:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 16:32 [PATCH 0/2] fix task_work interation with freezing Pavel Begunkov
2024-07-07 16:32 ` [PATCH 1/2] io_uring/io-wq: limit retrying worker initialisation Pavel Begunkov
2024-07-07 16:32 ` [PATCH 2/2] kernel: rerun task_work while freezing in get_signal() Pavel Begunkov
2024-07-08 10:42 ` Oleg Nesterov
2024-07-08 15:40 ` Pavel Begunkov
2024-07-08 18:48 ` Peter Zijlstra
2024-07-09 10:36 ` Oleg Nesterov
2024-07-09 14:05 ` Pavel Begunkov
2024-07-09 16:39 ` Tejun Heo
2024-07-09 19:07 ` Oleg Nesterov
2024-07-09 19:26 ` Pavel Begunkov
2024-07-09 19:38 ` Oleg Nesterov [this message]
2024-07-09 19:55 ` Pavel Begunkov
2024-07-10 0:54 ` Tejun Heo
2024-07-10 17:53 ` Pavel Begunkov
2024-07-10 19:10 ` Oleg Nesterov
2024-07-10 19:20 ` Tejun Heo
2024-07-10 21:34 ` Oleg Nesterov
2024-07-10 22:01 ` Tejun Heo
2024-07-10 22:17 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240709193828.GC3892@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=ju.orth@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tandersen@netflix.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.