From: Oleg Nesterov <oleg@redhat.com>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
io-uring@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
Tycho Andersen <tandersen@netflix.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Julian Orth <ju.orth@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] kernel: rerun task_work while freezing in get_signal()
Date: Wed, 10 Jul 2024 21:10:16 +0200 [thread overview]
Message-ID: <20240710191015.GC9228@redhat.com> (raw)
In-Reply-To: <933e7957-7a73-4c9a-87a7-c85b702a3a32@gmail.com>
On 07/10, Pavel Begunkov wrote:
>
> On 7/10/24 01:54, Tejun Heo wrote:
> >Yeah, the question is: If CRIU is to use cgroup freezer to freeze the tasks
> >and then go around tracing each to make dump, would the freezer be enough in
> >avoiding interim state changes? Using CRIU implementation is a bit arbitrary
> >but I think checkpoint-restart is a useful bar to measure what should stay
> >stable while a cgroup is frozen.
>
> Sounds like in the long run we might want to ignore task_work while
> it's frozen,
Just in case, this is what I have in mind right now, but I am still not sure
and can't make a "clean" patch.
If nothing else. CRIU needs to attach and make this task TASK_TRACED, right?
And once the target task is traced, it won't react to task_work_add(TWA_SIGNAL).
Oleg.
next prev parent reply other threads:[~2024-07-10 19:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 16:32 [PATCH 0/2] fix task_work interation with freezing Pavel Begunkov
2024-07-07 16:32 ` [PATCH 1/2] io_uring/io-wq: limit retrying worker initialisation Pavel Begunkov
2024-07-07 16:32 ` [PATCH 2/2] kernel: rerun task_work while freezing in get_signal() Pavel Begunkov
2024-07-08 10:42 ` Oleg Nesterov
2024-07-08 15:40 ` Pavel Begunkov
2024-07-08 18:48 ` Peter Zijlstra
2024-07-09 10:36 ` Oleg Nesterov
2024-07-09 14:05 ` Pavel Begunkov
2024-07-09 16:39 ` Tejun Heo
2024-07-09 19:07 ` Oleg Nesterov
2024-07-09 19:26 ` Pavel Begunkov
2024-07-09 19:38 ` Oleg Nesterov
2024-07-09 19:55 ` Pavel Begunkov
2024-07-10 0:54 ` Tejun Heo
2024-07-10 17:53 ` Pavel Begunkov
2024-07-10 19:10 ` Oleg Nesterov [this message]
2024-07-10 19:20 ` Tejun Heo
2024-07-10 21:34 ` Oleg Nesterov
2024-07-10 22:01 ` Tejun Heo
2024-07-10 22:17 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710191015.GC9228@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=ju.orth@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tandersen@netflix.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.