* [PATCH] fs/affs: struct affs_head: Replace 1-element array with flexible array
@ 2024-07-10 22:57 Kees Cook
2024-07-10 23:26 ` Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2024-07-10 22:57 UTC (permalink / raw)
To: David Sterba; +Cc: Kees Cook, linux-fsdevel, linux-kernel, linux-hardening
AFFS uses struct affs_head's "table" array as a flexible array. Switch
this to a proper flexible array[1]. There are no sizeof() uses; struct
affs_head is only ever uses via direct casts. No binary output
differences were found after this change.
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook <kees@kernel.org>
---
Cc: David Sterba <dsterba@suse.com>
Cc: linux-fsdevel@vger.kernel.org
---
fs/affs/amigaffs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
index 5509fbc98bc0..09dc23a644df 100644
--- a/fs/affs/amigaffs.h
+++ b/fs/affs/amigaffs.h
@@ -80,7 +80,7 @@ struct affs_head {
__be32 spare1;
__be32 first_data;
__be32 checksum;
- __be32 table[1];
+ __be32 table[];
};
struct affs_tail {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs/affs: struct affs_head: Replace 1-element array with flexible array
2024-07-10 22:57 [PATCH] fs/affs: struct affs_head: Replace 1-element array with flexible array Kees Cook
@ 2024-07-10 23:26 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2024-07-10 23:26 UTC (permalink / raw)
To: Kees Cook, David Sterba; +Cc: linux-fsdevel, linux-kernel, linux-hardening
On 10/07/24 16:57, Kees Cook wrote:
> AFFS uses struct affs_head's "table" array as a flexible array. Switch
> this to a proper flexible array[1]. There are no sizeof() uses; struct
> affs_head is only ever uses via direct casts. No binary output
> differences were found after this change.
>
> Link: https://github.com/KSPP/linux/issues/79 [1]
> Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> Cc: David Sterba <dsterba@suse.com>
> Cc: linux-fsdevel@vger.kernel.org
> ---
> fs/affs/amigaffs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
> index 5509fbc98bc0..09dc23a644df 100644
> --- a/fs/affs/amigaffs.h
> +++ b/fs/affs/amigaffs.h
> @@ -80,7 +80,7 @@ struct affs_head {
> __be32 spare1;
> __be32 first_data;
> __be32 checksum;
> - __be32 table[1];
> + __be32 table[];
> };
>
> struct affs_tail {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-10 23:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-10 22:57 [PATCH] fs/affs: struct affs_head: Replace 1-element array with flexible array Kees Cook
2024-07-10 23:26 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.