From: Cheng Ming Lin <linchengming884@gmail.com>
To: miquel.raynal@bootlin.com, vigneshr@ti.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: richard@nod.at, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw,
Cheng Ming Lin <chengminglin@mxic.com.tw>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] mtd: spinand: macronix: Fixed warning: Function paramteter or member not described
Date: Thu, 11 Jul 2024 16:36:11 +0800 [thread overview]
Message-ID: <20240711083611.364431-1-linchengming884@gmail.com> (raw)
From: Cheng Ming Lin <chengminglin@mxic.com.tw>
Fixed the warnings: Function paramteter or member 'xxx' not described
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407110520.pbPnrOlM-lkp@intel.com/
Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
---
drivers/mtd/nand/spi/macronix.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
index c61f1ba31f0c..ea956933e8a1 100644
--- a/drivers/mtd/nand/spi/macronix.c
+++ b/drivers/mtd/nand/spi/macronix.c
@@ -101,12 +101,16 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
}
/**
+ * write_Plane_Select_bit_in_cadd - Write Plane Select bit to the column address
+ * @spinand: SPI NAND device
+ * @req: NAND I/O request object
+ * @column: the column address
+ *
* Macronix serial NAND flash with a two-plane structure
- * should insert Plane Select bit to the column address
+ * should insert Plane Select bit into the column address
* during the write_to_cache operation.
- * Additionally, MX35{U,F}2G14AC also need to insert Plane
- * Select bit to the column address during the read_from_cache
- * operation.
+ *
+ * Return: the column address after insertion of Plane Select bit
*/
static unsigned int write_Plane_Select_bit_in_cadd(struct spinand_device *spinand,
const struct nand_page_io_req *req, unsigned int column)
@@ -116,6 +120,17 @@ static unsigned int write_Plane_Select_bit_in_cadd(struct spinand_device *spinan
return column | (req->pos.plane << fls(nanddev_page_size(nand)));
}
+/**
+ * read_Plane_Select_bit_in_cadd - Write Plane Select bit to the column address
+ * @spinand: SPI NAND device
+ * @req: NAND I/O request object
+ * @column: the column address
+ *
+ * MX35{U,F}2G14AC also need to insert Plane Select bit
+ * into the column address during the read_from_cache operation.
+ *
+ * Return: the column address after insertion of Plane Select bit
+ */
static u16 read_Plane_Select_bit_in_cadd(struct spinand_device *spinand,
const struct nand_page_io_req *req, u16 column)
{
base-commit: 6000ef48e571f49a636b0c51494c1326ff9b7736
prerequisite-patch-id: 5cea93c94f6237a2f8f51397ba76187952ef45b2
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Cheng Ming Lin <linchengming884@gmail.com>
To: miquel.raynal@bootlin.com, vigneshr@ti.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: richard@nod.at, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw,
Cheng Ming Lin <chengminglin@mxic.com.tw>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] mtd: spinand: macronix: Fixed warning: Function paramteter or member not described
Date: Thu, 11 Jul 2024 16:36:11 +0800 [thread overview]
Message-ID: <20240711083611.364431-1-linchengming884@gmail.com> (raw)
From: Cheng Ming Lin <chengminglin@mxic.com.tw>
Fixed the warnings: Function paramteter or member 'xxx' not described
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407110520.pbPnrOlM-lkp@intel.com/
Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
---
drivers/mtd/nand/spi/macronix.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
index c61f1ba31f0c..ea956933e8a1 100644
--- a/drivers/mtd/nand/spi/macronix.c
+++ b/drivers/mtd/nand/spi/macronix.c
@@ -101,12 +101,16 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
}
/**
+ * write_Plane_Select_bit_in_cadd - Write Plane Select bit to the column address
+ * @spinand: SPI NAND device
+ * @req: NAND I/O request object
+ * @column: the column address
+ *
* Macronix serial NAND flash with a two-plane structure
- * should insert Plane Select bit to the column address
+ * should insert Plane Select bit into the column address
* during the write_to_cache operation.
- * Additionally, MX35{U,F}2G14AC also need to insert Plane
- * Select bit to the column address during the read_from_cache
- * operation.
+ *
+ * Return: the column address after insertion of Plane Select bit
*/
static unsigned int write_Plane_Select_bit_in_cadd(struct spinand_device *spinand,
const struct nand_page_io_req *req, unsigned int column)
@@ -116,6 +120,17 @@ static unsigned int write_Plane_Select_bit_in_cadd(struct spinand_device *spinan
return column | (req->pos.plane << fls(nanddev_page_size(nand)));
}
+/**
+ * read_Plane_Select_bit_in_cadd - Write Plane Select bit to the column address
+ * @spinand: SPI NAND device
+ * @req: NAND I/O request object
+ * @column: the column address
+ *
+ * MX35{U,F}2G14AC also need to insert Plane Select bit
+ * into the column address during the read_from_cache operation.
+ *
+ * Return: the column address after insertion of Plane Select bit
+ */
static u16 read_Plane_Select_bit_in_cadd(struct spinand_device *spinand,
const struct nand_page_io_req *req, u16 column)
{
base-commit: 6000ef48e571f49a636b0c51494c1326ff9b7736
prerequisite-patch-id: 5cea93c94f6237a2f8f51397ba76187952ef45b2
--
2.25.1
next reply other threads:[~2024-07-11 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 8:36 Cheng Ming Lin [this message]
2024-07-11 8:36 ` [PATCH] mtd: spinand: macronix: Fixed warning: Function paramteter or member not described Cheng Ming Lin
2024-07-17 8:08 ` Miquel Raynal
2024-07-17 8:08 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711083611.364431-1-linchengming884@gmail.com \
--to=linchengming884@gmail.com \
--cc=alvinzhou@mxic.com.tw \
--cc=chengminglin@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.